File chromium-127-ninja-1.21.1-deps-part2.patch of Package chromium

Overview Repositories Revisions Requests Users Attributes Meta

File chromium-127-ninja-1.21.1-deps-part2.patch of Package chromium (Revision db59b906281bb3298ab08fa8381b0059)

Currently displaying revision db59b906281bb3298ab08fa8381b0059 , Show latest

commit 2c101186b60ed50f2ba4feaa2e963bd841bcca47
Author: Takuto Ikuta <tikuta@chromium.org>
Date:   Fri Jun 21 06:23:27 2024 +0000

chrome/browser: add missing dependency
    
    This is to fix build error due to missing dependency when we update
    ninja to 1.12.
    e.g. https://ci.chromium.org/ui/p/chromium/builders/build/linux-build-perf-no-rbe/1690/overview
    
    Bug: 346711540, 346699817, 345645751, 40253918
    Change-Id: Ife0a4e09969a4ad2e61dfc1598c9a63ac0b2abd5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641516
    Reviewed-by: Anthony Vallée-Dubois <anthonyvd@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1317790}

diff --git a/chrome/browser/ui/views/side_panel/BUILD.gn b/chrome/browser/ui/views/side_panel/BUILD.gn
index 96f2c30a6dd22..2957730277a29 100644
--- a/chrome/browser/ui/views/side_panel/BUILD.gn
+++ b/chrome/browser/ui/views/side_panel/BUILD.gn
@@ -201,5 +201,13 @@ source_set("side_panel") {
     "//ui/gfx:color_utils",
     "//ui/gfx/geometry:geometry_skia",
     "//ui/webui",
+
+    # TODO(crbug.com/346711540,crbug.com/346699817,crbug.com/345645751):
+    # Use //chrome/browser/ui instead after fixing cyclic dependency.
+    "//chrome/browser/ui:webui_name_variants",
+    "//components/enterprise/buildflags",
+    "//components/paint_preview/buildflags",
+    "//components/segmentation_platform/public/proto",
+    "//components/webapps/common:mojo_bindings",
   ]
 }

Places

File chromium-127-ninja-1.21.1-deps-part2.patch of Package chromium (Revision db59b906281bb3298ab08fa8381b0059)

Places