Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
Please login to access the resource
network:cryptocurrencies
monacoin
monacoin.changes
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File monacoin.changes of Package monacoin
------------------------------------------------------------------- Sat Oct 26 15:23:20 UTC 2024 - marec@detebe.org - Update to version 0.20.4: * Add change log for 0.20.4. * [block encodings] Make CheckBlock mockable for PartiallyDownloadedBlock * [block encodings] Avoid fuzz blocking asserts in PartiallyDownloadedBlock * chore(doc): Add a change log. ------------------------------------------------------------------- Sat May 21 08:56:15 UTC 2022 - marec@detebe.org - Update to version 0.20.3: * chore(configure): Bump to 0.20.3 . * fix(util/message): Fix the invalid value in MESSAGE_MAGIC. * Fix typo in sph_types.h ------------------------------------------------------------------- Mon Nov 15 17:47:00 UTC 2021 - marec@detebe.org - Update to version 0.20.2: * [monacoin] Update relase-notes. * [monacoin] Add the license notice. * [monacoin] Fix HRP parts in EXAMPLE_ADDRESSes. * Add testnet seeder(testnet-dnsseed.tamami-foundation.org) * [monacoin] Use newer osslsigncode. * [monacoin] Use `gitian.sigs.mona` instead of `gitian.sigs.ltc`. * [monacoin] Add `rename` to packages of gitian-win. * [monacoin] Use `*-0.20` instead of `*-0.19` . * [monacoin] Drop arm-linux-gnueabihf. * [Monacoin] Use the Verge version of scrypt.c . * Monacoin: fix comments. * Monacoin: Avoid nFeePaid overflow. * Monacoin: Remove bignum.h * Monacoin: Update copyright * Monacoin: Add monacoinproject-key.pgp * Monacoin: Fee system * Monacoin: 3rd hardfork 2/2 (DGWv3) * Monacoin: 3rd hardfork 1/2 (Lyra2REv2) * Monacoin: 2nd hardfork (DigiShield) * Monacoin: 1st hardfork (KGW) * Monacoin: Bugfix:Allow old private key at import * Monacoin: Adjust chain parameters and blockchain size * Monacoin: Disable tests and bench * Monacoin: Update hardcoded seeds * Monacoin: Adjust port strings * Monacoin: Adjust coin amount * Monacoin: Branding * Monacoin: Update splashscreen and icon * Litecoin: M prefix added for script addresses * Litecoin: Remove unused IsScriptWitnessEnabled * Litecoin: Protocol and default settings * Litecoin: Fix various tests * Litecoin: Add scrypt N=1024 PoW * release: bump RC to 0 (-final) * build: bump version to 0.20.2rc3 * doc: update release notes for rc3 * doc: add historical release notes for 0.20.1 * doc: add historical release notes for 0.20.0 * doc: mention bech32m/BIP350 in doc/descriptors.md * Use latest signapple commit * gitian: Remove codesign_allocate and pagestuff from MacOS build * gitian: use signapple to create the MacOS code signature * gitian: use signapple to apply the MacOS code signature * gitian: install signapple in gitian-osx-signer.yml * build: Bump version to 0.20.2rc2 * 0.20: Update translations after closing 0.20.x on Transifex * Update Windows code signing certificate * Backport invalid address tests * naming nits * Use Bech32m encoding for v1+ segwit addresses * Add Bech32m test vectors * Implement Bech32m encoding/decoding * [doc] Add permissions to the getpeerinfo help. * doc: Extract net permissions doc * rpc: Add missing description of vout in getrawtransaction help text * doc: Update manual pages pre-rc1 * gui: Pre-rc1 translations update * build: Bump version to 0.20.2rc1 * tests: Test that a fully signed tx given to signrawtx is unchanged * Revert "Merge #19606: Backport wtxid relay to v0.20" * doc: Update data directory path comments * util: Add StripRedundantLastElementsOfPath function * macOS deploy: use the new plistlib API * build: fix mutex detection when building bdb on macOS * random: fixes read buffer resizing in RandAddSeedPerfmon * net: Send post-verack handshake messages at most once * rpc: Adjust witness-tx deserialize error message * rpc: Properly deserialize txs with witness before signing * Avoid the use of abs64 in timedata * docs: Correct description for getblockstats's txs field * build: set minimum required Boost to 1.48.0 * Further improve comments around recentRejects * Disconnect peers sending wtxidrelay message after VERACK * test: Use wtxid relay generally in functional tests * test: Add tests for wtxid tx relay in segwit test * test: Update test framework p2p protocol version to 70016 * Rename AddInventoryKnown() to AddKnownTx() * Make TX_WITNESS_STRIPPED its own rejection reason * Delay getdata requests from peers using txid-based relay * Add p2p message "wtxidrelay" * ignore non-wtxidrelay compliant invs * Add support for tx-relay via wtxid * Add wtxids to recentRejects * Add wtxids of confirmed transactions to bloom filter * Add wtxid-index to orphan map * Add a wtxid-index to mapRelay * Just pass a hash to AddInventoryKnown * Add a wtxid-index to the mempool * Update the vcpkg checkout commit ID in appveyor config. * Set appveyor vm version to previous Visual Studio 2019 release. * Simplify and fix CWallet::SignTransaction * test addition of unknown segwit spends to txid reject filter * Add txids with non-standard inputs to reject filter * doc: Update 0.20.1 release notes with psbt changes * build: Bump version to 0.20.1-final * [0.20] lint: fix shellcheck URL in CI install * doc: Add changelog and authors to release notes for 0.20.1 * qt: Translation update for 0.20.1rc1 * doc: Regenerate man pages for 0.20.1rc1 * build: Bump version to 0.20.1rc1 * qt: Fix QFileDialog for static builds * Increment input value sum only once per UTXO in decodepsbt * Remove cached directories and associated script blocks from appveyor CI configuration. * appveyor: Remove clcache * doc: move-only release notes for 0.20.1 * doc: Clear release notes for minor release * Clean up separated ban/discourage interface * Replace automatic bans with discouragement filter * test: remove Cirrus CI FreeBSD job * qa: Test concurrent wallet loading * wallet: Handle concurrent wallet loading * tests: Check that segwit inputs in psbt have both UTXO types * psbt: always put a non_witness_utxo and don't remove it * psbt: Allow both non_witness_utxo and witness_utxo * rpc: show both UTXOs in decodepsbt * trivial: Suggested cleanups to surrounding code * wallet: Minimal fix to restore conflicted transaction notifications * Fix WSL file locking by using flock instead of fcntl * gui: update Qt base translations for macOS release * build: improved output of configure for build OS * util: Don't reference errno when pthread fails. * Add missing QPainterPath include * doc: Manpages update pre-final * build: Set rc to 0 for -final * doc: Merge 0.20.0 release notes from wiki * build: Bump RC to rc2 * qt: Pre-rc2 translations update * test: disable script fuzz tests * fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer * [net processing] Only send a getheaders for one block in an INV * test: Remove const to work around compiler error on xenial * miner: Avoid stack-use-after-return in validationinterface * test: Add unregister_validation_interface_race test * gui: Fix manual coin control with multiple wallets loaded * test: Add test for conflicted wallet tx notifications * rpc: Relock wallet only if most recent callback * rpc: Add mutex to guard deadlineTimers * [docs] Improve commenting in ProcessGetData() * [test] test that an invalid GETDATA doesn't prevent processing of future messages * [net processing] ignore unknown INV types in GETDATA messages * [net processing] ignore tx GETDATA from blocks-only peers * gui: Fix itemWalletAddress leak when not tree mode * travis: Remove s390x * travis: Remove valgrind * build: Ensure source tarball has leading directory name * rpc: Do not advertise dumptxoutset as a way to flush the chainstate * Fix naming of macOS SDK and clarify version * Do not expose and consider -logthreadnames when it does not work * build: fix ASLR for bitcoin-cli on Windows * build: Set libevent minimum version to 2.0.21 * Avoid non-trivial global constants in SHA-NI code * gitian: Add missing automake package to gitian-win-signer.yml * qt: Update translations pre-rc1 * doc: Update manpages pre-rc1 * build: Bump version to 0.20.0 * Correct scripted-diff example link * ci: Rename RUN_CI_ON_HOST to DANGER_RUN_CI_ON_HOST * ci: Add native s390x * test: Set -use_value_profile=1 when merging fuzz inputs * tests: Add coverage of {,Incremental}DynamicUsage(const std::set<X, Y>& s) to existing fuzzer * tests: Add fuzzing harness for classes/functions in cuckoocache.h * tests: Add fuzzing harness for classes/functions in checkqueue.h * tests: Add coverage of GetVirtualTransactionSize(...) to existing fuzzer * tests: Add fuzzing harness for AdditionOverflow(...) * tests: Add fuzzing harness for FeeFilterRounder * ci: Run unit tests sequential once * appveyor: Enable minimal unit test logging to aid debugging * Fix unregister_all_during_call cleanup * test: Properly raise FailedToStartError when rpc shutdown before warmup finished * build: Update ax_boost_mase.m4 to the latest serial * Add test for UnregisterAllValidationInterfaces bug * Do not clear validationinterface entries being executed * Reorder the test instructions by number * Merge and generalize case 3 and case 6 * Only run sanity check once at the end * Assert immediately rather than caching failure * Make a fuzzer-based copy of the prevector randomized test * qt: Fix Window -> Minimize menu item * Wallet: Change IsMine check in CWallet::DelAddressBook from assert to failure * Wallet: Replace CAddressBookData.name with GetLabel() method * QA: Test that change doesn't turn into non-change when spent in an avoid-reuse wallet * test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction * rpc: Make verifychain default values static, not depend on global args * test: wallet_bumpfee assertion fixup * test: relax bumpfee dust_to_fee txsize an extra vbyte * Remove PID file at the very end * tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions * test: skip backwards compat tests if not compiled with wallet * scripted-diff: Replace strCommand with msg_type * rpc: Avoid initialization-order-fiasco on static CRPCCommand tables * fuzz: Add process_messages harness * build: create test_fuzz library from src/test/fuzz/fuzz.cpp * tests: Add proof-of-work fuzzing harness * refactor: drop boost::signals2 in validationinterface * scripts: add MACHO lazy bindings check to security-check.py * test: remaining replacements of (send_message+sync_with_ping) with send_and_ping * fuzz: Extend script fuzz test * fuzz: Extend descriptor fuzz test * test: remove rapidcheck integration and tests * net: Hardcoded seeds update for 0.20 * test: add BIP37 remote crash bug [CVE-2013-5700] test to p2p_filter.py * [doc] fix git add argument * fuzz: Add CScriptNum::getint coverage * fuzz: Avoid running over all inputs after merging them * Wallet: Add warning comments and assert to CWallet::DelAddressBook * Wallet: Avoid unnecessary/redundant m_address_book lookups * rpc: Fix rpcRunLater race in walletpassphrase * Wallet: Avoid treating change-in-the-addressbook as non-change everywhere * Wallet: New FindAddressBookEntry method to filter out change entries (and skip ->second everywhere) * Wallet: Add CAddressBookData::IsChange which returns true iff label has never been set * Wallet: Require usage of new CAddressBookData::setLabel to change label * scripted-diff: Wallet: Rename mapAddressBook to m_address_book * test: Add basic addr relay test * Bugfix: RPC: JSON null is not "None" * Bugfix: RPC: Don't use a continuation elipsis after an elision elipsis * Bugfix: RPC: Add missing commas and correct indentation of explicit ELISION * net: Pass connman const when relaying address * doc: Update webchat URLs in README.md * init: Replace URL_WEBSITE with PACKAGE_URL * build: Detect gmtime_* definitions via configure * chainparams: Bump assumed valid hash * rpc: Make rpc documentation not depend on rpc args * test: replace (send_message + sync_with_ping) with send_and_ping * test: remove redundant sync_with_ping after add_p2p_connection * qt: Translations update pre-branch * Correctly compute redeemScript from witnessScript for signrawtransaction * doc: Explain new test logging * test: Remove redundant sync_with_ping after add_p2p_connection * test: Wait for both veracks in add_p2p_connection * gui: Delete progress dialog instead of hidding it * wallet: Handle duplicate fileid exception * doc: note the costs of fetching all pull requests * test: add BIP37 'filterclear' test to p2p_filter.py * ci: Use Focal for fuzzers * test: check that peer is connected when calling sync_* * test: Remove unsafe BOOST_TEST_MESSAGE * doc: block-relay-only is not blocksonly * net: Add missing cs_vNodes lock * tests: Add fuzzing harness for functions/classes in random.h * tests: Add fuzzing harness for LimitedString (serialize.h) * tests: Add fuzzing harness for functions/classes in span.h * tests: Add fuzzing harness for functions/classes in merkleblock.h * tests: Add fuzzing harness for functions/classes in flatfile.h * Update -blocksonly documentation * rpc: remove unused getbalances() code * Bugfix: RPC: Remove final comma for last entry of fixed-size Arrays and Objects in RPCResult * serialization: prevent int overflow for big Coin::nHeight * net: Make addr relay mockable * gui: Handle WalletModel::unload asynchronous * Fix wallet unload race condition * util: Replace i64tostr with ToString * util: Remove unused itostr * Limit decimal range of numbers ParseScript accepts * test: add coverage for script parse error in ParseScript * tests: Add fuzzing harness for functions/classes in chain.h * tests: Add fuzzing harness for functions/classes in protocol.h * ci: Remove misplaced comments from folded block scalar * wallet: remove CreateTotalBumpTransaction() * wallet: remove totalfee from createBumpTransaction() * rpc: remove deprecated totalFee arg from RPC bumpfee * ci: Use Homebrew addon on native macOS * ci: Fix brew in Travis * scripts: rename test_64bit_PE to test_PE * scripts: add MACHO NX check to security-check.py * scripts: add MACHO tests to test-security-check.py * ci: Only clone bitcoin-core/qa-assets when fuzzing * build: remove double LIBBITCOIN_SERVER from bench-Makefile * test: Add basic test for BIP 37 * [scripts] previous_release: improve failed download error message * tests: Add fuzzing harness for classes/functions in blockfilter.h * tests: Add integer serialization/deserialization fuzzing harness * Update with new Windows code signing certificate * test: listsinceblock block height checks * tests: Add fuzzing harness for functions in net_permissions.h * tests: Add fuzzing harness for functions in timedata.h * tests: Add fuzzing harness for functions in addrdb.h * gui: avoid QT Designer/Form Editor re-formatting * gui: display Mapped AS in peers info window * Make VerifyWitnessProgram use a Span stack * script: fix SCRIPT_ERR_SIG_PUSHONLY error string * Check for overflow when calculating sum of outputs * test: add executable flag for rpc_estimatefee.py * ci: Run feature_block and feature_abortnode in valgrind * tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOverflow(...) fuzzing harness * test: delete wallet_bumpfee_totalfee_deprecation.py * test: update bumpfee testing from totalFee to fee_rate * scripts: add PE dylib checking to symbol-check.py * rpc: fix broken RPCExamples for waitforblock(height) * build: Fix typo in EVENT_CFLAGS variable * build: Fix libevent linking for bench_bitcoin binary * rpc: add missing HelpExampleRpc for getblockfilter * test: Remove ci timeout restriction in test_runner * doc: Add internal interface conventions to developer notes * refactor: Change createWallet, fillPSBT argument order * refactor: Change Chain::broadcastTransaction param order * refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods * refactor: Rename Node::disconnect methods * refactor: Get rid of Wallet::IsWalletFlagSet method * doc: Temporary note that release notes should be edited in wiki * build: fix sysctl() detection on macOS * doc: Add fuzzing quickstart guides for libFuzzer and afl-fuzz. Simplify instructions. * Add bn2vch test to functional tests * Simplify bn2vch using int.to_bytes * Update merkle.cpp * net: fix use-after-free in tests * test: use fs namespace in dbwrapper unicodepath test * doc: mention MAKE=gmake workaround when building on a BSD * tests: Add harness which fuzzes EvalScript and VerifyScript using a fuzzed signature checker * tests: simplify next_block() function in feature_block * doc: fix GetTimeMicros() comment in random.cpp * rand: remove getentropy() fallback for macOS < 10.12 * tx: Bump transifex slug to 020x * qt: Periodical translations update * Fix missing header in sync.h * build: Drop needless EXTRA_DIST content * tests: Add fuzzing harness for various functions taking std::string as input * tests: Add fuzzing harness for MultiplicationOverflow(...) * tests: Add fuzzing harness for CFeeRate * tests: Add fuzzing harness for CBlockHeader * tests: Add fuzzing harness for count_seconds(...) * test: Bump timeouts to avoid valgrind failures * Replace std::to_string with locale-independent alternative * Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests * Replace remaining literals BTC with CURRENCY_UNIT * rpc: Document an RPCResult for all calls; Enforce at compile time * rpc: Add missing newline in RPCResult description * Fix nit in getblockchaininfo * util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero) * refactor: Remove mempool global from net * build: Drop SOURCEDIST reordering * build: Use git archive as source tarball * [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks * [validation] Remove pool member from ConnectTrace * [validation] Remove NotifyEntryRemoved callback from ConnectTrace * [validation] Remove conflictedTxs from PerBlockConnectTrace * [validation interface] Remove vtxConflicted from BlockConnected * [wallet] Notify conflicted transactions in TransactionRemovedFromMempool * guix: Remove now-unnecessary gcc make flag * fuzz: Add missing ECC_Start to key_io test * test: Bump rpc timeout in feature_assumevalid to avoid valgrind timeouts * test: Bump walletpassphrase timeouts in wallet_createwallet to avoid valgrind timeouts * util: HelpExampleRpc formatting fixup * tests: Add fuzzing of CSubNet, CNetAddr and CService related functions * tests: Fuzz HasAllDesirableServiceFlags(...) and MayHaveUsefulAddressDB(...) * tests: Fuzz DecodeBase64PSBT(...) * tests: Simplify code by removing unwarranted use of unique_ptr:s * tests: Fuzz DecodeHexBlk(...) * tests: Fuzz RecursiveDynamicUsage(const std::shared_ptr<X>& p) * tests: Fuzz operator!= of CService * tests: Increase fuzzing coverage of DecompressScript(...) * tests: Fuzz currently uncovered code path in TxToUniv(...) * tests: Re-arrange test cases in parse_univalue to increase coverage * doc: Explain rebase/squash policy in CONTRIBUTING.md * tests: Remove unit test from fuzzing harness * tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot), uint160 and uint256 * tests: Add one specialized ProcessMessage(...) fuzzing binary per message type for optimal results when using coverage-guided fuzzing * tests: Add fuzzing harness for ProcessMessage(...) * ci: Enable all functional tests in valgrind * bumpfee test: exit loop at proper time with new fee value being compared * Add some test logging to wallet_bumpfee.py * doc: asmap release note * fuzz: Remove option --export_coverage from test_runner * refactor: move DUMP_BANS_INTERVAL to banman.h * scheduler: Make schedule* methods type safe * test: Explain why test logging should be used * qa: Add getdescriptorinfo functional test * Make lifetime correctness easier to see (avoid reference lifetime extension) * tests: Add fuzzing harness for CScriptNum operations * test: add logging to wallet_listsinceblock.py * tests: Add fuzzing harness for CScript operations * tests: Add common Consume* fuzzing functions * doc: Warn about wallet.dat re-use and backups * doc: Add historical release notes for 0.19.1 * tests: Remove FUZZERS_MISSING_CORPORA * tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) * Clear any input_errors for an input after it is signed * Replace GetSigningProvider with GetSolvingProvider * Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan * Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT * Move FillPSBT to be a member of CWallet * fuzz: Add option to merge input dir to test runner * doc: Remove --disable-ccache from docs * tests: Reset FUZZERS_MISSING_CORPORA to enable regression fuzzing for more harnesses * rpc/wallet: initialize nFeeRequired to avoid using garbage value on failure * Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet * Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction * Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan * Refactor rawtransaction's SignTransaction into generic SignTransaction function * fuzz: Add assert(script == decompressed_script) * build: Set minimum Automake version to 1.13 * Cache parent xpub inside of BIP32PubkeyProvider * Only cache xpubs that have a hardened last step * Cache the immediate derivation parent xpub * Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey * Rename BIP32PubkeyProvider.m_extkey to m_root_extkey * Track the index of the key expression in PubkeyProvider * Introduce DescriptorCache struct which caches xpubs * tests: Fuzz additional functions in the script fuzzing harness * tests: Fuzz additional functions in the transaction fuzzing harness * scheduler: Use C++11 member initialization, add shutdown assert * tests: Fuzz additional functions in the integer fuzzing harness * tests: Fuzz additional functions in the hex fuzzing harness * tests: Add key_io fuzzing harness * doc: remove Boost Chrono from install docs * test: remove Boost Chrono installation from CI * build: remove Boost Chrono detection from build system * build: remove chrono package from depends Boost * build: Add locale fuzzer to FUZZERS_MISSING_CORPORA * test: Check that wait_until returns if time point is in the past * lint-cppcheck: Remove -DHAVE_WORKING_BOOST_SLEEP_FOR * tests: Add fuzzing harness for locale independence testing * scheduler_tests: re-enable mockforward test * Drop unused reverselock.h * scheduler: switch from boost to std * sync.h: add REVERSE_LOCK * scheduler: don't rely on boost interrupt on shutdown * tests: Add fuzzing harness for CKey related functions * tests: Add float to FUZZERS_MISSING_CORPORA (temporarily) * tests: Add serialization/deserialization fuzzing for integral types * compressor: Make the domain of CompressAmount(...) explicit * [rpc] changed MineBlocksOnDemand to IsMockableChain * Remove redundant type information from rpc docs * refactor: Cast ping values to double before output * lockedpool: When possible, use madvise to avoid including sensitive information in core dumps * refactor: Convert ping wait time from double to int64_t * refactor: Convert min ping time from double to int64_t * refactor: Convert ping time from double to int64_t * doc: Merge release notes for 0.20.0 release * init: move asmap code earlier in init process * rpc: fix getpeerinfo RPCResult `mapped_as` type * net: extract conditional to bool CNetAddr::IsHeNet * logging: asmap logging and #include fixups * test: add functional test for an empty, unparsable asmap * config: separate the asmap finding and parsing checks * config: enable passing -asmap an absolute file path * config: use default value in -asmap config * test: add feature_asmap functional tests * test: Add bad-txns-*-toolarge test cases to invalid_txs * doc: Correct spelling errors in comments * test: Bump timeouts to accomodate really slow disks * wallet: use constant CWallets in rpcwallet.cpp * wallet: make ReserveDestination pwallet ivar const * wallet: make BackupWallet() const * wallet: make getters const * wallet/spkm: make GetOldestKeyPoolTime() const * wallet: use constant CWallets in rpcdump.cpp * wallet/db: make IsDummy() const * wallet/db: make Backup() const * wallet: make CanGetAddresses() const * wallet: make KeypoolCountExternalKeys() const * wallet: make CanGenerateKeys() const * make BlockUntilSyncedToCurrentChain() const * Change example addresses to bech32 * Drop unused mach time headers * test: Add missing syncwithvalidationinterfacequeue * test: add unit test for non-standard "scriptsig-not-pushonly" txs * refactor: test/bench: dedup SetupDummyInputs() * test: check specific reject reasons in feature_csv_activation.py * util: Fail to parse empty string in ParseMoney * util: Remove unused ParseMoney that takes a c_str * Make AnalyzePSBT next role calculation simple, correct * test: eliminiated magic numbers in feature_csv_activation.py * test: check for OP_CSV empty stack fail reject reason in feature_csv_activation.py * test: test OP_CSV empty stack fail in feature_csv_activation.py * Templatize ValidationState instead of subclassing * Remove ValidationState's constructor * Refactor FormatStateMessage into ValidationState * test: Fix race in p2p_segwit * Add missing step in win deployment instructions * build: add --enable-determinism configure flag * test: check custom descendant limit in mempool_packages.py * test: Disable mockforward scheduler unit test for now * Convert blockencodings.h to new serialization framework * Add CustomUintFormatter * tests: Add fuzzing harness for rolling bloom filter class CRollingBloomFilter * tests: Add fuzzing harness for bloom filter class CBloomFilter * test: Reduce unneeded whitelist permissions in tests * rpc: Auto-format RPCResult * rpc: Move OuterType enum to header * test: Add cost_of_change parameter assertions to bnb_search_test * scripted-diff: Wallet: Rename incorrectly named *UsedDestination * util: Remove unused MilliSleep * scripted-diff: Replace MilliSleep with UninterruptibleSleep * util: Add UnintrruptibleSleep * test: Set catch_system_errors=no on boost unit tests * util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t nTime) by checking gmtime_s/gmtime_r return value * test: Remove incorrect assumptions in validation_flush_tests * test: Tabs to spaces in all tests * Add static_asserts to ser_X_to_Y() methods * tests: Improve test runner output in case of target errors * tests: Add --exclude integer,parse_iso8601 (temporarily) to make Travis pass until uninitialized read issue in FormatISO8601DateTime is fixed * tests: Add support for excluding fuzz targets using -x/--exclude * tests: Remove -detect_leaks=0 from test/fuzz/test_runner.py - no longer needed * add: test that transactions expire from mempool * httpserver: use own HTTP status codes * ci: Run fuzz testing test cases under valgrind * doc: Minor grammatical changes and flow improvements * [rpc] expose ability to mock scheduler via the rpc * [lib] add scheduler to node context * Fix a violation of C++ standard rules that unions cannot be switched. * gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged * tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind * Add DifferenceFormatter * Make VectorFormatter support stateful formatters * Convert CCompactSize to proper formatter * Refactor message hashing into a utility function * Deduplicate the message signing code * Deduplicate the message verifying code * ci: use --enable-werror on more hosts * build: add Wreturn-type to Werror flags * [test] add chainparams property to indicate chain allows time mocking * [test] unit test for new MockForward scheduler method * [util] allow scheduler to be mocked * refactor: rpc: Remove vector copy from listtransactions * rpc: update validateaddress RPCExamples to bech32 * build: pass -fno-ident in Windows gitian descriptor * gui: Throttle GUI update pace when -reindex * [REFACTOR] Abstract out script execution out of VerifyWitnessProgram() * Revert "Store p2sh scripts in AddAndGetDestinationForScript" * [test] check for addmultisigaddress regression * wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition * tests: Avoid hitting some known minor tinyformat issues when fuzzing strprintf(...) * doc: remove PPA note from release-process.md * gui: Fix race in WalletModel::pollBalanceChanged * [test] add 0.19 backwards compatibility tests * [test] add v0.17.1 wallet upgrade test * [tests] add wallet backwards compatility tests * [scripts] support release candidates of earlier releases * [tests] check v0.17.1 and v0.18.1 backwards compatibility * [scripts] build earlier releases * Get the OutputType for a descriptor * net: Remove forcerelay of rejected txs * Get rid of VARINT default argument * Ignore only auto-generated .vcxproj files * Specify ignored bitcoin-qt file precisely * ci: Check for submodules * build: Add cov_fuzz target * build: link fuzz/test_runner.py for out-of-tree builds * build: Remove unused USE_COVERAGE * test: set a name for CI Docker containers * test: Disable s390 build on travis * build: Skip i686 build by default in guix and gitian * depends: Remove reference to win32 * qt: Fix deprecated QCharRef usage * Squashed 'src/univalue/' changes from 5a58a46671..98261b1e7b * scripted-diff: Add missing spaces in RPCResult, Fix type names * Qt: pass clientmodel changes from walletframe to walletviews * Convert undo.h to new serialization framework * Make std::vector and prevector reuse the VectorFormatter logic * Add custom vector-element formatter * doc: link to homebrew's troubleshooting page * refactor: Work around GCC 9 `-Wredundant-move` warning * net: Fail instead of truncate command name in CMessageHeader * logging: enable thread_local usage on macOS * build: don't embed a build-id when building libdmg-hfsplus * random: don't special case clock usage on macOS * test: replace 'regtest' leftovers by self.chain * build: add additional attributes to Win installer * gui: Fix unintialized WalletView::progressDialog * gui: Drop PeerTableModel dependency to ClientModel * build: use macOS 10.14 SDK * depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8 * depends: clang 6.0.1 * net: reference instead of copy in BlockConnected range loop * Remove false positive GCC warning * build: Fix behavior when ALLOW_HOST_PACKAGES unset * Make asmap Interpret tolerant of malicious map data * Use ASNs for mapped IPv4 addresses correctly * Mark asmap const in statistics code * Avoid asmap copies in initialization * test: Check wallet name in -walletnotify script * tests: Add fuzzing harness for functions taking floating-point types as input * Add missing includes * gui: Drop ShutdownWindow dependency to BitcoinGUI * [test] PSBT RPC: check that bip32_derivs are present by default * gui: Drop BanTableModel dependency to ClientModel * Output a descriptor in createmultisig and addmultisigaddress * Add missing supported rpcs to doc/descriptors.md * Remove GitHub Actions CI workflow. * tests: Add fuzzer asmap to FUZZERS_MISSING_CORPORA (temporarily) * tests: Add fuzzing harness for AS-mapping (asmap) * gui: Remove WalletView and BitcoinGUI circular dependency * gui: Add transactionClicked and coinsSent signals to WalletView * psbt_wallet_tests: use unique_ptr for GetSigningProvider * Add a constant for the maximum vector allocation (5 Mbyte) * tests: reset fIsBareMultisigStd after bare-multisig tests * on startup, write config options to debug.log * build: Fix appveyor test_bitcoin build of *.raw * Use rolling bloom filter of recent block tx's for AlreadyHave() check * test: only declare a main() when fuzzing with AFL * doc: Improve fuzzing docs for macOS users * test: Add ubsan surpression for crc32c * build: Disable msvc warning 4722 for leveldb build * build: MSVC changes for leveldb update * build: CRC32C build system integration * build: Add LCOV exception for crc32c * test: Add crc32c exception to various linters and generation scripts * test: Add crc32c to subtree check linter * doc: Add crc32c subtree to developer notes * build: Update build system for new leveldb * Squashed 'src/crc32c/' content from commit 224988680f7673cd7c769963d4035cb315aa3388 * Squashed 'src/leveldb/' changes from f545dfabff4c2e9836efed094dba99a34fbc6b88..f8ae182c1e5176d12e816fb2217ae33a5472fdd7 * Fix benchmarks filters * test: rename test suite name "tx_validationcache_tests" to match filename * guix: Update documentation for time-machine * guix: Pin Guix using `guix time-machine` * tests: Add fuzzing harness for strprintf(...) * tests: Add fuzzer strprintf to FUZZERS_MISSING_CORPORA (temporarily) * tests: Update FuzzedDataProvider.h from upstream (LLVM) * Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open * build: remove --large-address-aware linker flag * Updated appveyor job to checkout a specific vcpkg commit ID. * bump test timeouts so that functional tests run in valgrind * gui: Shortcut to close ModalOverlay * Refactor: Replace SigningProvider pointers with unique_ptrs * Cleanup: Drop unused GUI learnRelatedScripts method * Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan * Box the wallet: Add multiple keyman maps and loops * refactor: define a UINT256_ONE global constant * HD Split: Avoid redundant upgrades * Make UpgradeKeyMetadata work only on LegacyScriptPubKeyMan * Store p2sh scripts in AddAndGetDestinationForScript * Always try to sign for all pubkeys in multisig * List output types in an array in order to be iterated over * Refactor: Allow LegacyScriptPubKeyMan to be null * Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman * wallet: Improve CWallet:MarkDestinationsDirty * Add extra logging of asmap use and bucketing * Return mapped AS in RPC call getpeerinfo * doc: Use proper RPC help syntax in importmulti * doc: Remove duplicate "comment" from listsinceblock RPC help * doc: Properly document proxy_randomize_credentials as bool in getnetworkinfo * doc: Fix syntax error (trailing square bracket) in finalizepsbt * doc: Fix syntax error (trailing square bracket) in walletprocesspsbt * doc: Add missing "optional" to "long" estimaterawfee RPC help * src/init: correct a typo * test: Add p2p test for forcerelay permission * test: Fix whitespace in p2p_permissions.py * test: Make msg_tx a witness tx * build: remove configure checks for win libraries we don't link against * Refactor message transport packaging * tests: Add fuzzing harness for V1TransportDeserializer (P2P transport) * tests: Add amount compression/decompression fuzzing to existing fuzzing harness: test compression round-trip * test: add missing #include to fix compiler errors * Convert compression.h to new serialization framework * refactor: Remove redundant conditional * Revert "refactor: Remove never used default parameter" * Revert "refactor: Simplify connection syntax" * Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters * QA: feature_segwit: Check that template "rules" includes "!segwit" as appropriate * Bugfix: Include "csv","!segwit" in "rules" * Fix doxygen errors * wallet: Improve CWallet:MarkDestinationsDirty * refactor: Simplify connection syntax * refactor: Remove never used default parameter * test: add unit test for non-standard txs with too large tx size * gui: Remove warning "unused variable 'wallet_model'" * depends: Consistent use of package variable * gui: hide HD & encryption icons when no wallet loaded * QT: Change bumpFee asserts to simple error message * Replace coroutine with async def in p2p_invalid_messages.py * wallet: Replace %w by wallet name in -walletnotify script * Make UpdateTransactionsFromBlock use Epochs * Add Epoch Guards to CTXMemPoolEntry and CTxMemPool * bug-fix macos: give free bytes to F_PREALLOCATE * Don't allow implementers to think ScriptHash(Witness*()) results in nesting computation * scripted-diff: Bump copyright of files changed in 2020 * scripted-diff: Replace CCriticalSection with RecursiveMutex * IsUsedDestination shouldn't use key id as script id for ScriptHash * bitcoin-wallet: Use PACKAGE_NAME in usage help * GUI: Use PACKAGE_NAME in modal overlay * gui: Make Intro consistent with prune checkbox * gui: Add Intro::UpdateFreeSpaceLabel() * refactor: Add Intro::UpdatePruneLabels() * refactor: Replace static variable with data member * Convert chain to new serialization * Convert VARINT to the formatter/Using approach * Add a generic approach for (de)serialization of objects using code in other classes * wallet: Reset reused transactions cache * windows: remove call to SetProcessDEPPolicy * windows: Enable heap terminate-on-corruption * build: remove double LIBBITCOIN_SERVER linking * doc: update release notes with getaddressinfo label deprecation * Fix improper Doxygen inline comments * gui: Set CConnman byte counters earlier to avoid uninitialized reads * init: Stop indexes on shutdown after ChainStateFlushed callback. * test: getaddressinfo label deprecation test * rpc: deprecate getaddressinfo label field * test: remove getaddressinfo label tests * doc: address pr17578 review feedback * Ignore msvc linker warning and update to msvc build instructions. * ci: Combine 32-bit build with CentOS 7 build * util: Add PruneGBtoMiB() function * util: Add PruneMiBtoGB() function * tests: Avoid using C-style NUL-terminated strings as arguments * tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters * net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface * qa: Fix double-negative arg test * qt: Rename SetPrune() to InitializePruneSetting() * refactor: Drop `bool force' parameter * qt: Force set nPruneSize in QSettings after intro * QT: bump fee returns PSBT on clipboard for watchonly-only wallets * Restore English translation option * contrib: makeseeds: Read suspicious hosts from a file instead of hardcoding * gui: renamed 'debug window' to 'node window' * psbt: check output index is within bounds before accessing * doc: Add a note about backporting * build: add Wdate-time to Werror flags * qt: Add LogQtInfo() function * doc: Add to Doxygen documentation guidelines * scripted-diff: Add missed copyright headers * refactor: Remove unused defines in bitcoinunits.h * scripts: add MACHO dylib checking to symbol-check.py * scripts: fix check-symbols & check-security argument passing * IsUsedDestination should count any known single-key address * Add logging for CValidationInterface events * Refactor FormatStateMessage for clarity * Format CValidationState properly in all cases * Add VALIDATION to BCLog::LogFlags * doc: update release notes * test: getaddressinfo labels purpose deprecation test * rpc: simplify getaddressinfo labels, deprecate previous behavior * script: Update EXLUDE list in copyright_header.py * script: Add empty line after C++ copyright * script: Add ability to insert copyright to *.sh * gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy * ci: Set LC_ALL=C when running in qemu-s390x * ci: Use debian to avoid apt install 404 errors * ci: Install needed gcc and qemu-user iff cross-compiling * ci: Fix QEMU_USER_CMD parse issues * ci: Move wrap-qemu into separate script * scripts: fix check-symbols & check-security argument passing * test: Show debug log on unit test failure * tests: Add std::to_string to list of locale dependent functions * Add missing typeinfo includes * Convert addrdb/addrman to new serialization * Introduce new serialization macros without casts * ci: Fix brew python link * scripts: add MACHO NOUNDEFS check to security-check.py * scripts: add MACHO PIE check to security-check.py * build: remove linking librt for backwards compatibility * build: remove deprecated key from macOS Info.plist * doc: Added running functional tests in valgrind * scripted-diff: Bump copyright of files changed in 2019 * doc: Update dependencies.md * doc: developer notes guideline on RPCExamples addresses * rpc: incorporate review feedback from PR 17283 * build: Add default configure cache to .gitignore * test: Change filemode of rpc_whitelist.py * doc: Update license year range to 2020 * Integrate ASN bucketing in Addrman and add tests * ci: Update vcpkg cache on MSBuild update * ci: Update Qt binaries for GitHub Actions * rpc: Remove mempool global from miner * test: Properly document blockinfo size in miner_tests * util: Disallow network-qualified command line options * build: Sort fuzzing harnesses to avoid future merge conflicts * tests: Add fuzzing harness for DecodeHexTx(...) * build: set AC_PREREQ to 2.69 * Add asmap utility which queries a mapping * Document better -keypool as a look-ahead safety mechanism * doc: Mention PR Club in CONTRIBUTING.md * Test watchonly wallet bumpfee with PSBT return * bumpfee: Return PSBT when wallet has privkeys disabled * Change bumpfee to use watch-only funds for legacy watchonly wallets * use preferred shebang approach for documentation * doc: Add formatting to the good first issue template * net: Log to net category for exceptions in ProcessMessages * test: add IsRFC2544 tests * CNetAddr: fix IsRFC2544 comment * tests: Add fuzzing harness for various hex related functions * tests: Add fuzzing harness for various Base{32,58,64} related functions * util: Move TrimString(...). Introduce default pattern (trims whitespace). Add NODISCARD. * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * build: remove WINDOWS_BITS from build system * rest: Use mempool from node context instead of global * tests: Add tests for decoding/parsing of base32, base64 and money strings containing NUL characters * util: Don't allow DecodeBase32(...) of strings with embedded NUL characters * util: Don't allow DecodeBase64(...) of strings with embedded NUL characters * util: Don't allow ParseMoney(...) of strings with embedded NUL characters * fix directory path for secp256k1 subtree in developer-notes * tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * [style] Code style fixups in GetWarnings() * doc: Add release note for RPC Whitelist * doc: Add ci prefix to CONTRIBUTING.md * util: change GetWarnings parameter to bool * [qt] remove unused parameter from getWarnings() * ci-s390x: Add qemu and depends support in the ci script * build: add -bind_at_load to hardened LDFLAGS * Moved the include of the system projects to before the build depends on task. Otherwise it doesn't get run. * depends: disable unused qt networking features * depends: -optimized-qmake is now -optimized-tools * depends: skip building qt proxies * Included test_bitcoin-qt in msvc build. * doc: update developer notes wrt unix epoch time * qa: unify unix epoch time descriptions * test: Add test for rpc_whitelist * Update msvc build for Visual Studio 2019 v16.4 * tests: add tests for GetCoinsCacheSizeState * refactoring: introduce CChainState::GetCoinsCacheSizeState * build: fix typo * util: Don't allow base58-decoding of std::string:s containing non-base58 characters * tests: Add tests for base58-decoding of std::string:s containing non-base58 characters * rpc: require second argument only for scantxoutset start action * Add RPC Whitelist Feature from #12248 * ci: Use python 3.7 on Windows Github Actions * wallet: unbreak with boost 1.72 * Don't calculate tx fees for PSBTs with invalid money values * ci: Add valgrind run * rpc: add missing newline in analyzepsbt rpcresult * doc: Add release notes for 17447 * doc: Update release process with latest changes * tests: Add fuzzing harnesses for various JSON/univalue parsing functions * tests: Add fuzzing harnesses for various number parsing functions * tests: Add ParseScript(...) (core_io) fuzzing harness * tests: Add ParseHDKeypath(...) (bip32) fuzzing harness * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * Activate no-privkey -> ISMINE_WATCH_ONLY behavior for LegacySPKM only * build: Use dnl for all comments in configure.ac, rather than # * build: Remove backticks from configure.ac * test: Remove ubsan alignment suppressions * prevector: avoid misaligned member accesses * test: re-enable CLI test support by using EncodeDecimal in json.dumps() * Adds GitHub Action workflow which duplicates AppVeyor job. * qt: Normalize placeholder to avoid using "address book" in sendcoinsentry * gui: Move static placeholder texts to forms * ui: disable 3rd-party tx-urls when wallet disabled * Make env data logging optional * lcov: filter /usr/lib64 from coverage report * depends: don't configure xcb_proto * util: Replace magics with DEFAULT_PRUNE_TARGET_GB * gui: disable File->CreateWallet during startup * cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * Replace LegacyScriptPubKeyMan::IsCrypted with LegacyScriptPubKeyMan::HasEncryptionKeys * Remove SetCrypted() and fUseCrypto; Change IsCrypted()'s implementation * Rename EncryptKeys to Encrypt and pass in the encrypted batch to use * Clear mapKeys before encrypting * Move fDecryptionThoroughlyChecked from CWallet to LegacyScriptPubKeyMan * Move Unlock implementation to LegacyScriptPubKeyMan * Replace LegacyScriptPubKeyMan::vMasterKey with GetDecryptionKey() * Add GetEncryptionKey() and HasEncryptionKeys() to WalletStorage * ci: Remove trusty build * ci: Add CentOS 7 build * tests: Fix fuzzing harness for descriptor parsing (descriptor_parse) * lcov: filter depends from coverage report * tests: Use a default of supports_cli=True (instead of supports_cli=False) * tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such * tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. Avoid code repetition. * tests: Add fuzzing harness for various functions consuming only integrals * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * tests: Add fuzzing harness for various CTxOut related functions * tests: Add fuzzing harness for various CTxIn related functions * util: Update tinyformat to upstream * Add bounds checks in key_io before DecodeBase58Check * gitian: fixed SC2001 regex * node: Use mempool from node context instead of global * rpc: Use mempool from node context instead of global * Move events_hasher into RNGState() * depends: Support for S390X targets * depends: Support for 64-bit POWER targets * keypool: Add comment about TopUp and when to use it * depends: don't use OpenGL in Qt on macOS * build: pass -dead_strip_dylibs to ld on macOS * tests: Add initialization order fiasco detection in Travis * Fixed wget call in gitian-build.py * ci: Remove unparseable lines from supp file for old xenial clang tsan * ci: ubsan report_error_type=1 and add suppressions * test: Print stderr when subprocess fails * test: Use char instead of unsigned char * ci: Bump to clang-8 for asan build to avoid segfaults on ppc64le * util: remove unwanted fields from bitcoin-cli -getinfo * build: pass -dead_strip_dylibs to ld on macOS * depends: add ability to skip building qrencode * doc: rename wallet-tool references to bitcoin-wallet * Key pool: Fix omitted pre-split count in GetKeyPoolSize * Key pool: Change ReturnDestination interface to take address instead of key * Key pool: Move LearnRelated and GetDestination calls * Fix origfee return for bumpfee with feerate arg * tests: Add option --valgrind to run nodes under valgrind in the functional tests * Add unit test for DB creation with unicode path * script: Add Keyserver to verify-commits README * Use correct C++11 header for std::swap() * Fix comparison function signature * net: Fix uninitialized read in ProcessMessage(...) * script: Enable SC2001 rule for Gitian scripts * script: Enable SC2155 rule for Gitian scripts * tests: Add a test for funding with sufficient preset inputs and subtractFeeFromOutputs * Default to bnb_used = false as there are many cases where BnB is not used * Add OutputType and CPubKey parameters to KeepDestination * Rename Keep/ReturnKey to Keep/ReturnDestination and remove the wrapper * util: make ScheduleBatchPriority advisory only * [gui] send: show watch-only balance in send screen * [test] qt: add send screen balance test * qt: Use proper class for Ui::ReceiveCoinsDialog * qt: Fix class name of Ui::ModalOverlay * ci: Print free disk space * test: Properly deserialize integers in little-endian * ci: Run functional tests on s390x * doc: Change doxygen URL to doxygen.bitcoincore.org * [test] move wallet helper functions into test library * [test] move mining helper functions into test library * Appveyor install libevent[thread] vcpkg * Add s390x tests to travis * Add ci script to install on s390x * [test] move string helper functions into test library * test: add rpc getaddressinfo labels test coverage * test: add listlabels test in wallet_labels.py * rpc: add getaddressinfo code documentation * rpc: update getaddressinfo RPCExamples to bech32 * rpc: clarify label vs labels in getaddressinfo RPCHelpman * rpc: improve getaddressinfo RPCHelpman content * wallet: replace raw pointer with const reference in AddrToPubKey * rpc: improve getaddressinfo RPCHelpman formatting * build: Add NX workaround for RV64 * doc: Add historical release notes for 0.19.0.1 * Seed RNG with precision timestamps on receipt of net messages. * Added libtest_util library to msvc build configuration. * build: Allow export of environ symbols * refactor: Nuke coincontrol circular dependency * keypool: Move opportunistic TopUps from LegacyScriptPubKeyMan to CWallet and ReserveDestination * keypool: Remove superfluous topup from CWallet::GetNewChangeDestination * Key pool: Move CanGetAddresses call * gui: remove macOS start on login code * doc: add glibc 2.17 requirement to release-notes * build: Bump minimum versions in symbol checker * build: Disallow dynamic linking against c++ library * ci: Remove use of cd * doc: Changed MiniUPnPc link to https in dependencies.md * test: add unit test for non-standard txs with wrong nVersion * build: Create test utility library from src/test/util/ * Fire TransactionRemovedFromMempool from mempool * Remove out of date comments for CalculateMaximumSignedTxSize * tests: Add deserialization fuzzing harnesses * tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus * build: set minimum supported macOS to 10.12 * ci: Remove unmaintained extended_lint * scripted-diff: Use ci DEPENDS_DIR, remove BASE_BUILD_DIR * ci: Add DEPENDS_DIR variable, Add documentation for folders * test: add unit test for non-standard bare multisig txs * build: Fix configure report about qr * scripted-diff: Move various folders to ci scratch dir * refactor: Remove unused COINBASE_FLAGS * test: add functional test for non-standard bare multisig txs * build: remove libanl.so.1 from ALLOWED_LIBRARIES * Put bounds on the number of CPUID leaves explored * doc: Update and improve Developer Notes * Allow BnB when subtract fee from outputs * Use BnB when preset inputs are selected * depends: only use dbus with qt on linux * test: add functional test for non-standard txs with too large scriptSig * Pass a maximum output length to DecodeBase58 and DecodeBase58Check * Fix CPUID subleaf iteration * Mark PSBTs spending unspendable outputs as invalid in analysis * Have a PSBTAnalysis state that indicates invalid PSBT * test: Wait until mempool is loaded in wallet_abandonconflict * refactor: Cleanup headers from walletmodel.h * refactor: Nuke walletmodel circular dependency * refactor: Nuke walletmodeltransaction circular dep * refactor: Nuke guiutil circular dependency * refactor: Move SendCoinsRecipient in own header * doc: Add some better examples for scripted diff * test: Remove libssl-dev packages from CI scripts * test: remove lsan suppression for libcrypto * build: remove libcrypto as internal dependency in libbitcoinconsensus.pc * doc: Remove ssl as a required dependency from build-unix * test: skip tool_wallet test when bitcoin-wallet isn't compiled * test: skip wallet_listreceivedby test when the cli isn't compiled * test: skip bitcoin_cli test when the cli isn't compiled * Refactor: Require scriptPubKey to get wallet SigningProvider * Accumulate result UniValue in SignTransaction * tests: Add fuzzing harness for various PSBT related functions * random: mark RandAddPeriodic and SeedPeriodic as noexcept * doc: correct random.h docs after #17270 * doc: add OpenSSL removal to release-notes.md * ci: remove OpenSSL installation * doc: remove OpenSSL from build instructions and licensing info * depends: remove OpenSSL package * build: remove OpenSSL detection and libs * random: Remove remaining OpenSSL calls and locking infrastructure * random: stop retrieving random bytes from OpenSSL * random: stop feeding RNG output back into OpenSSL * doc: Remove bitness from bitcoin-qt help message and manpage * Changed tooltips of receive form to highlight difference between Label and Message * refactor: Remove unused signal * Fix segfault in allocator_tests/arena_tests * Define ARENA_DEBUG in Travis test runs * Fix compilation errors in support/lockedpool.cpp * test: fix bitcoind already running warnings on macOS * Fix input size assertion in wallet_bumpfee.py * scripted-diff: Replace ::mempool with m_node.mempool in tests * test: Replace recursive lock with locking annotations * node: Add reference to mempool in NodeContext * [build] ./configure --enable-werror: add unused-variable * scripted-diff: Set gitian arch back to amd64 * test: add unit test for non-standard txs with too large scriptSig * fuzz: Bump timeout in test_runner to accomodate for slow arm64 CPUs * test: Remove fragile assert_memory_usage_stable * GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing * Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr * ci: Use clang-8 for fuzzing to run on aarch64 ci systems * refactor: Remove null setting check in GetSetting() * [gui] watch-only wallet: copy PSBT to clipboard * depends: qt: Fix C{,XX} pickup * [wallet] add fillPSBT to interface * [gui] send: include watch-only * [wallet] ListCoins: include watch-only for wallets without private keys * tests: Update valgrind suppressions * scripted-diff: Remove unused ArgsManager type flags in tests * refactor: Add util_CheckValue test * refactor: Add ArgsManager::GetSettingsList method * refactor: Get rid of ArgsManagerHelper class * refactor: Replace FlagsOfKnownArg with GetArgFlags * refactor: Clean up includeconf comments * refactor: Clean up long lines in settings code * fix uninitialized variable nMinerConfirmationWindow * Report amount of data gathered from environment * Use thread-safe atomic in perfmon seeder * Run background seeding periodically instead of unpredictably * Add information gathered through getauxval() * Feed CPUID data into RNG * Use sysctl for seeding on MacOS/BSD * Gather additional entropy from the environment * Seed randomness with process id / thread id / various clocks * [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid * [MOVEONLY] Move perfmon data gathering to new randomenv module * doc: minor corrections in random.cpp * doc: Explain $LIB in LD_PRELOAD in gitian descriptors * util: Add missing headers to util/fees.cpp * wallet: Make -walletdir network only * rpc: Expose block height of wallet transactions * zmq: Fix due to invalid argument and multiple notifiers * test: check custom ancestor limit in mempool_packages.py * wallet: Avoid showing GUI popups on RPC errors (take 2) * fix Typo: "merkelRoot" -> "merkleRoot" * test: Use proper MAX_SCRIPT_ELEMENT_SIZE * refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE const * ci: Extend docs * travis: Rework CACHE_ERR_MSG * Add TheCharlatan's pgp key * Moves vcpkg list to a text file and updates the appveyor job and readme to use it. * refactor: Styling w/ clang-format, comment update * qt: Fix missing qRegisterMetaType for size_t * Remove unnecessary forward declaration * ci: Make ci system read-only on the git work tree * ci: Remove git from required packages on host * ci: Make all filesystem operations inside docker * doc: Add relase note for db→walletdb rename * doc: add historical 0.19.0 release notes * scripted-diff: Change `BCLog::DB` to `BCLog::WALLETDB` * Rename `db` log category to `walletdb` (like `coindb`) * scripted-diff: Avoid hardcoded libfaketime dir in gitian * Add settings_tests * Deduplicate settings merge code * Add util::Settings struct and helper functions. * Remove includeconf nested scope * Rename includeconf variables for clarity * Clarify emptyIncludeConf logic * wallet: Remove unused boost::this_thread::interruption_point * Remove redundant class file includes from test_bitcoin project. * [validation] fix comments in CheckInputScripts() * scripted-diff: [validation] Rename CheckInputs to CheckInputScripts * ci: Guess the native host when not cross compiling * Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic * [refactor] interpreter: define interface for vfExec * Benchmark script verification with 100 nested IFs * test: speed up wallet_avoidreuse.py * test: add logging to wallet_avoidreuse.py * doc: Added regtest config for linearize script * Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per #17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. * [refactor] Replace global int nScriptCheckThreads with bool * [tests] Don't use TestingSetup in the checkqueue_tests * [tests] Don't stop-start unnecessarily in rpc_fundrawtransaction.py * [tests] Use -whitelist in rpc_fundrawtransaction.py * Remove getBlockDepth method from Chain::interface * Remove locked_chain from GetDepthInMainChain and its callers * Use CWallet::m_last_block_processed_height in GetDepthInMainChain * Only return early from BlockUntilSyncedToCurrentChain if current tip is exact match * Refactor some importprunedfunds checks with guard clause * Add block_height field in struct Confirmation * doc: Add documentation for new test/lib * scripted-diff: test: Move setup_common to test library * Replace CWalletTx::SetConf by Confirmation initialization list * script: Enable SC2006 rule for Gitian scripts * script: Lint Gitian descriptors with ShellCheck * build: Remove install command samples * Add util_ArgParsing test * wallet_importmulti: use addresses of the same type as being imported * Add missing newline in util_ChainMerge test * Improve "Hide" button tool-tip message * rpc: Remove unused boost::this_thread::interruption_point * test: add dumptxoutset RPC test * devtools: add utxo_snapshot.sh * rpc: add dumptxoutset * Add m_last_block_processed_height field in CWallet * Pass block height in Chain::BlockConnected/Chain::BlockDisconnected * doc: Add template for good first issues * coinstats: add coins_count * Add missing SetupGeneration error handling in EncryptWallet * remove old bootstrap relevant code * Clean up nested scope in GetReservedDestination * Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method * Pass CTxDestination to ScriptPubKeyMan::GetMetadata * doc: Update doc/bips.md with recent changes in master * Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp * TestShell: Return self from setup() * TestShell: Simplify default setting of num_nodes * Doc: Remove backticks in test-shell.md code block * TestShell: Fix typo in TestShell warning printout * [tools] update nNextInvSend to use mockable time * [tools] add PoissonNextSend method that returns mockable time * depends: move README.md Android instructions to a separate section * tests: Add fuzzing harness for Bech32 encoding/decoding * tests: Move CaseInsensitiveEqual to test/util/str * cli: fix -getinfo output when compiled with no wallet * logs: add timing information to FlushStateToDisk() * logs: add BCLog::Timer and related macros * ci: Run non-cross-compile builds natively * ci: Run CI_WAIT only on travis * [tests] Speed up rpc_fundrawtransaction.py * wallet: LearnRelatedScripts only if KeepDestination * wallet: Lock address type in ReserveDestination * test: Reset global args between test suites * bump libevent to 2.1.11 in depends * test: Add ASSERT_DEBUG_LOG to unit test framework * logging: Add member for arbitrary print callbacks * depends: update README.md with working Android targets and API levels * Add documentation for test_shell submodule * test: add "diamond" unit test to MempoolAncestryTests * doc: Fix some misspellings * Add TestShell class * Move argparse() to init() * Move assert num_nodes is set into main() * Clear TestNode objects after shutdown * Add closing and flushing of logging handlers * Refactor TestFramework main() into setup/shutdown * Remove network_event_loop instance in close() * wallet: Reuse existing batch in CWallet::SetUsedDestinationState * wallet: Avoid recursive lock in CWallet::SetUsedDestinationState * doc: Add ShellCheck to lint tests dependencies * Refactor: Move nTimeFirstKey accesses out of CWallet * Refactor: Move GetKeypoolSize code out of CWallet * Refactor: Move RewriteDB code out of CWallet * Refactor: Move SetupGeneration code out of CWallet * Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile * Refactor: Move Upgrade code out of CWallet::CreateWalletFromFile * Refactor: Move MarkUnusedAddresses code out of CWallet::AddToWalletIfInvolvingMe * Refactor: Move GetMetadata code out of getaddressinfo * Refactor: Move LoadKey LegacyScriptPubKeyMan method definition * Refactor: Move SetAddressBookWithDB call out of LegacyScriptPubKeyMan::ImportScriptPubKeys * refactor: Replace UnsetWalletFlagWithDB with UnsetBlankWalletFlag in ScriptPubKeyMan * Refactor: Remove UnsetWalletFlag call from LegacyScriptPubKeyMan::SetHDSeed * Remove SetWalletFlag from WalletStorage * Refactor: Move SetWalletFlag out of LegacyScriptPubKeyMan::UpgradeKeyMetadata * Refactor: Move SetAddressBook call out of LegacyScriptPubKeyMan::GetNewDestination * Refactor: Add new ScriptPubKeyMan virtual methods * Refactor: Declare LegacyScriptPubKeyMan methods as virtual * MOVEONLY: Reorder LegacyScriptPubKeyMan methods * bench: Remove redundant copy constructor in mempool_stress * refactor: Remove redundant PSBT copy constructor * doc: compiling with Visual Studio is now supported on Windows * doc: update MSVC instructions to remove Qt configuration * test: Do not instantiate CAddrDB for static call * doc: Remove explicit network name references * test: rm ascii art in rpc_fundrawtransaction * test: add rpc_fundrawtransaction logging * [qa] Add shrinkdebugfile=0 to regtest bitcoin.conf * Minor refactoring to remove implied m_addr_relay_peer. * log: Fix log message for -par=1 * GuessVerificationProgress: cap the ratio to 1 * [linter] Strip trailing / in path for git-subtree-check * build: update retry to current version * Fix incorrect help-debug for -checkpoints * Squashed 'src/univalue/' changes from 7890db99d6..5a58a46671 * QA: Add wallet_implicitsegwit to test the ability to transform keys between address types * travis: Run unit and functional tests on native arm * test: Add RegTestingSetup to setup_common * Walk pindexBestHeader back to ChainActive().Tip() if it is invalid * test: move-only ComputeFilter to src/test/lib/blockfilter * replace asserts in RPC code with CHECK_NONFATAL and add linter * [tests] remove bignum.py * [tests] remove bn2bin() * [tests] remove bn_bytes() function * [tests] remove mpi2vch() function * [tests] don't encode the integer size in bignum * [tests] add function comments to bignum * [tests] fix flake8 warnings in script.py and bignum.py * rpc: Add generatetodescriptor * docs: Add undefined to --with-sanitizers=fuzzer,address * tests: Add fuzzing harness for ISO-8601 related functions * refactor: Replace all uses of boost::optional with our own Optional type * doc: Add developer note on c_str() * [validation] Remove fMissingInputs from AcceptToMemoryPool() * [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders() * [validation] Remove useless ret parameter from Invalid() * [validation] Remove error() calls from Invalid() calls * [validation] Tidy Up ValidationResult class * [validation] Add CValidationState subclasses * Chainparams: Use name constants in chainparams initialization * nsis: Write to correct filename in first place * cli: Add "headers" and "verificationprogress" to -getinfo * add unused SnapshotMetadata class * wallet: Remove left-over BIP70 comment * Fix missing strFailReason in CreateTransaction * Fix misplaced AssertLockHeld * doc: Clarify WalletStorage / Wallet relation * Add back mistakenly removed AssertLockHeld * Refactor: Add GetLegacyScriptPubKeyMan helper * test: add reason checks for non-standard txs in test_IsStandard * refactor: Remove addrdb.h dependency from node.h * Add assertion to randrange that input is not 0 * Add new mempool benchmarks for a complex pool * contrib: remove accounts from bash completion * pubkey: Assert CPubKey's ECCVerifyHandle precondition * Avoid using g_rpc_node global in wallet code * scripted-diff: Remove g_connman, g_banman globals * Pass NodeContext, ConnMan, BanMan references more places * MOVEONLY: Move NodeContext struct to node/context.h * scripted-diff: Rename InitInterfaces to NodeContext * Fix issue with conflicted mempool tx in listsinceblock * Fix occurences of c_str() used with size() to data() * refactor: Remove redundant c_str() calls in formatting * bench: Fix negative values and zero for -evals flag * Add search for first blk file with pruned node * tests: Add fuzzer initialization (hold ECCVerifyHandle) * Add roundtrip and more tests to ParseISO8601DateTime and FormatISO8601DateTime * Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp * gui: Fix duplicate wallet showing up * Drop signal CClientUIInterface::LoadWallet * Tests: Use self.chain instead of 'regtest' in almost all current tests * [rpc] set default bip32derivs to true for psbt methods * Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes * MOVEONLY: Move key handling code out of wallet to keyman file * Move wallet enums to walletutil.h * added asserts to check m_addr_known when it's used * [net] SocketHandler: log peer id for close and disconnect * gui: disable font antialiasing for QR image address * test: fix script_p2sh_tests OP_PUSHBACK2/4 missing * gui: Make polling in ClientModel asynchronous * Avoid unused call to GuessVerificationProgress in NotifyHeaderTip * http: add missing header bootlegged by boost < 1.72 * tests: Add fuzzing harness for various CScript related functions * ci: Remove ccache requirement on the host * compat: remove bswap_* check on macOS * build: skip building OpenSSL lib_ssl * build: remove OpenSSL from Qt build * build: remove EVP_MD_CTX_new detection * build: remove SSL lib detection * gui: Update BIP70 support message * build: remove BIP70 entries from macOS Info.plist * gui: remove payment request file handling from OpenURI dialog * Remove BIP70 Support * docs: remove protobuf from docs * build: remove protobuf from depends * consensus: Explain why fCheckDuplicateInputs can not be skipped and remove it * [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache * ci: Disable functional tests on mac host * doc: Changed miniupnp links to https * tests: Remove Cygwin WinMain workaround * tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed. * depends: fix boost mac cross build with clang 9+ * Add unit testing for the CompressScript functions * tests: Add Parse(...) (descriptor) fuzzing harness * tests: Allow for using non-default fuzzing initialization * gui: Fix payAmount tooltip in SendCoinsEntry * Add override/final modifiers to V1TransportDeserializer * Make resetting implicit in TransportDeserializer::Read() * Remove oversized message detection from log and interface * Continue relaying transactions after they expire from mapRelay * refactor: test/bench: dedup Build{Crediting,Spending}Transaction() * Replace the LogPrint function with a macro * static tooltip * test: use default address type (bech32) for wallet_bumpfee tests * Force CNetMessage::m_recv to use std::move * build: use osslsigncode 2.0 in gitian * refactor: Remove unused CExt{Pub,}Key (de)serialization methods * Expand on wallet_balance.py comment from https://github.com/bitcoin/bitcoin/pull/16766\#issuecomment-527563982 * Update release notes to mention changes to IsTrusted and impact on wallet * Systematize style of IsTrusted single line if * update variable naming conventions for IsTrusted * Update comment in test/functional/wallet_balance.py * Update wallet_balance.py test to reflect new behavior * Reuse trustedParents in looped calls to IsTrusted * Cache tx Trust per-call to avoid DoS * Make IsTrusted scan parents recursively * tests: Remove no longer needed UBSan suppressions (issues fixed). Add documentation. * Add testcase to simulate bitcoin schema in leveldb * ci: Enable address sanitizer (ASan) stack-use-after-return checking * wallet: Remove unused GetLabelName * doc: Added instructions for how to add an upsteam to forked repo * Send amount shows minimum amount placeholder * util: Add CHECK_NONFATAL and use it in src/rpc * Android: add all arch support * random: remove call to RAND_screen() (Windows only) * [wallet] Remove `state` argument from CWallet::CommitTransaction * [wallet] Remove return value from CommitTransaction() * [wallet] Add doxygen comment to CWallet::CommitTransaction() * gui: Add placeholder text to the sign message field * Use adapter pattern for the network deserializer * Remove transport protocol knowhow from CNetMessage / net processing * Refactor: split network transport deserializing from message container * util: Filter out macOS process serial number * doc: Describe log files + consistent paths in test READMEs * ci: Remove redundant check for TRAVIS_OS_NAME * doc: Document that GNU tools are required for linters * ci: Cleanup macOS runs * doc: correct function name in ReportHardwareRand() * p2p: Avoid allocating memory for addrKnown where we don't need it * chain: Set all CBlockIndex members to null, remove SetNull helper * Add tests for util/vector.h's Cat and Vector * Add some general std::vector utility functions * [wallet] Fix whitespace in CWallet::CommitTransaction() * Remove unused includes * tests: Add fuzzing harness for descriptor Span-parsing helpers * rpc: fix -rpcclienttimeout 0 option * gui: Added label & tooltip for Verify Message labels * gui: remove OpenSSL PRNG seeding (Windows, Qt only) * gui: Make RPCConsole::TabTypes an enum class * Update macdeploy README to include correctly named `.dmg` file produced from `make deploy` * tests: Fix fs_tests for unknown locales * util: Filter control characters out of log messages * github: Add warning for bug reports * [test] rename SegwitVersion1SignatureHash() * travis: run tests on macOS native * test: Fix bug in blockfilter_index_tests. * [wallet] Remove pruning check for -rescan option * [wallet] Remove package limit config access from wallet * [rpc] Fix broken bitcoin-cli examples * test: fix "tx-size-small" errors after default address change * doc: Add switch on enum example * util: Add AllowShortCaseLabelsOnASingleLine option * gui: Fix start timer from non QThread * test: speed up wallet_address_types by whitelisting peers (immediate tx relay) * gui: don't disable the sync overlay when wallet is disabled * tests: Add test for loadblock option * test: speedup wallet_backup by whitelisting peers (immediate tx relay) * tests: Add EvalScript(...) fuzzing harness * [build] depends macOS: point --sysroot to SDK * depends: export dynamic JNI symbols from static qtforandroid.a * Qt: patch androidjnimain.cpp to make sure JNI is initialised when statically compiled * doc: update bips.md with buried BIP9 deployments * build: pass --enable-option-checking to applicable packages * build: only pass --disable-dependency-tracking to packages that understand it * doc: Add missing indexes/blockfilter/basic/ to doc/files.md * change wallet pointers to references in feebumper * tests: Add FuzzedDataProvider fuzzing helper from the Chromium project * doc: Doxygen-friendly CuckooCache comments * [docs] Add release notes for removal of REJECT reasons * [validation] Fix REJECT message comments * [validation] Remove REJECT code from CValidationState * typo and unneccessary parentheses * [logging] Don't log REJECT code when transaction is rejected * [validation] Fix peer punishment for bad blocks * build: Add README.md to DIST target * test: add unit tests for Span-parsing helpers * Add missing fields in TransactionDescriptionString and others * MOVEONLY : move RPC wallets helpers to TransactionDescriptionString * test: Seed test RNG context for each test case, print seed * build: Add variable printing target to Makefiles * lint: Install grep and git via brew on mac for --perl-regexp * lint: Fix shellcheck SC2155 * lint: Run the linters against Mac OS on Travis * depends: pull upstream libdmg-hfsplus changes * depends: latest config.guess & config.sub * tests: Remove TRANSACTION_DESERIALIZE (replaced by transaction fuzzer) * tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions * ci: Run tests on arm * init: Change fallback locale to C.UTF-8 * [test] Add coverage to estimaterawfee and estimatesmartfee * build: Fix #include sys/poll.h to just poll.h (without sys/) * [doc] fix Makefile target in benchmarking.md * Add release note * Update descriptors.md to include sortedmulti * Test sortedmulti descriptor using BIP 67 tests * Add sortedmulti descriptor and unit tests * gitian: Put things in the right place to begin with * gitian: Eliminate rename dependency * gitian: Smaller diff with gitian-linux.yml * gitian: Fix README inclusion in archives * wallet: Avoid showing GUI popups on RPC errors * Fix bug where duplicate PSBT keys are accepted * Added double quotes * Disable _FORTIFY_SOURCE when enable-debug * tests: Pass fuzzing inputs as constant references * Always generate `bitcoinstrings.cpp` on `make translate` * build: Remove workaround for ancient libtool * build: Ensure a minimal version of libtool * Fix Python Docstring to include all Args. * util: Simplify path argument for CBlockTreeDB ctor * scripts: update copyright_header script to include additional files * build: Bump gitian descriptor versions * contrib: fix minor typos in makeseeds.py * doc: Fix amount typo in release notes * modify p2p_feefilter test to catch rounding error * Disallow implicit conversion for CFeeRate constructor * feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic * ci: Make apt-get more verbose, to debug travis timeouts * Don't rename main thread at process level * Prevent processing duplicate payment requests * gitian: Use split-debug.sh for Win builds * doc: Add detailed info about Bitcoin Core files * doc: Update bips.md for default bech32 addresses in 0.20.0 * doc: move-only release notes fragments for 0.20.0 * Truly decouple wallet from chainparams for -fallbackfee * p2p: Remove BIP61 reject messages * ci: Use busybox utils for one build * doc: move-only: Steps for "before major release branch-off" * doc: reset release notes after 0.19 split-off * build: 0.19 release updates on master * contrib: Remove invalid nodes from seeds list * gui: Add shortcuts for tab tools * qa: Do not force overwrite of QT_QPA_PLATFORM on windows for gui tests * doc: Explain QT_QPA_PLATFORM for gui tests * doc: Consolidate release notes before 0.19.0 * doc: Add missing release notes for 16383 * chainparams: Bump assumed chain params * net: 0.19 hardcoded seeds update * contrib: makeseeds: More fancy output * contrib: makeseeds: Limit per network, instead of total * contrib: makeseeds: dedup by ip,port * contrib: makeseeds: Factor out ASN lookup * contrib: makeseeds: Improve logging and filtering * Enable UBSan for Travis fuzzer job * doc: Bump version in bips.md, mention bumping in release process * add newline after -stdin* * cli: add -stdinwalletpassphrase for (slightly more) secure CLI * add stdin helpers for password input support * build: Installed Qt version only appears if being built * util: Make thread names shorter * doc: Remove mention of renamed mapBlocksUnlinked * doc: Add mention of BIP158 indexing since v0.19.0 * doc: Add mention of BIP125 used by wallet GUI by default since v0.18.1 * scripts: search for next position of magic bytes rather than fail * When BIP70 is disabled, get PaymentRequest merchant using string search * doc: Add mention of BIP70 disabling by default in bips.md * test bumpfee fee_rate argument * qa: Fix service flag comparison check in rpc_net test * test: Avoid whitespace linting in qt translations * qt: Periodic translations update * Correct docstring param name. * build: Factor out qt translations from build system * rpc bumpfee check fee_rate argument * rpc bumpfee: add fee_rate argument * test: add unittests for CheckProofOfWork * test: Fix combine_logs.py for AppVeyor build * Add release note for bech32 by default in wallet * Revert "gui: Generate bech32 addresses by default (take 2, fixup)" * Change default address type to bech32 * qt: Change default size of intro frame * refactor: Remove Qt function to disable menu icons on macOS * doc: Improve test READMEs * doc: Remove MSVC update step from translation process * [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response * make SaltedOutpointHasher noexcept * refactor: consolidate PASTE macros * Change sendcoins dialogue Yes to Send * doc: Put PR template in comments * test: Remove python dead code linter * doc: replace outdated OpenSSL comment in test README * ci: Remove TRAVIS env vars * ci: Set $HOST before setting fallback values * validation: Make GetWitnessCommitmentIndex public * make sure to update the UI when deleting a transaction * doc: Doxygen-friendly descriptor.h comments * doc: Improve doxygen readme navigation section * doc: Move doxygen intro to file for USE_MDFILE_AS_MANPAGE * travis: Disable feature_block in tsan run * builds: remove superfluous config_opts_aarch64_android * txmempool: Make entry time type-safe (std::chrono) * build: remove mingw linker workaround from win gitian descriptor * Patch libevent when building for Android (fix arc4random_addrandom) * Update bitcoin_qt.m4 * Define TARGET_OS when host is android * test: use named args for sendrawtransaction calls * doc: improve rawtransaction code/test docs * test: fix incorrect value in rpc_rawtransaction.py * gui: Rename address checkbox back to bech32 * Add OpenSSL termios fix for musl libc * Refresh ZeroMQ 4.3.1 patch * Only check the hash of transactions loaded from disk * tests: Add information on how to add Vulture suppressions * test: Fix extra_args in wallet_import_rescan.py * doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util * test: Make PORT_MIN in test runner configurable * util: Add count_seconds time helper * test: mempool entry time is persisted * Test: Move common function assert_approx() into util.py * Fix Android zlib cross compilation issue (https://stackoverflow.com/questions/21396988/zlib-build-not-configuring-properly-with-cross-compiler-ignores-ar) * Add full Android build example command and instructions on getting SDK/NDK * Add config opts and patch for aarch64_android build of Qt * Add ranlib to android.mk hosts file (fix OSX Android NDK build) * Add example Android host-platform-triplet and options * Add support for building Android dependencies * [doc] update brew instruction for doxygen * Update tx-size-small comment with relevant CVE disclosure * Add documenting comments to spanparsing.h * Abstract out some of the descriptor Span-parsing helpers * test: lint: Add DisabledOpcodeTemplates to whitelist * test: Remove unused connect_nodes_bi * scripted-diff: test: Replace connect_nodes_bi with connect_nodes * test: Use connect_nodes when connecting nodes in the test_framework * test: Reformat python imports to aid scripted diff * refactoring: move ReplayBlocks under CChainState * refactoring: move LoadChainTip to CChainState method * doc: fix CChainState::ActivateBestChain doc * doc: Fix whitespace errs in .md files, bitcoin.conf, Info.plist.in, and find_bdb48.m4 * test: add unit test for wallet watch-only methods involving PubKeys * test: add some unit tests for merkle.cpp * test: Bump timeouts in slow running tests * depends: qt: Fix LDFLAGS pickup * [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts * qt: Run "make translate" in ./src * test: Add notes on how to generate data/wallets/high_minversion * build: remove unnecessary qt xcb patching * build: remove unnecessary macOS qt patching * Add python bech32 impl round-trip test * test: improve gettransaction test coverage * rpc: fix regression in gettransaction * build: make protobuf optional in depends * doc: clarify protobuf build requirements * build: update boost macros to latest upstream * [wallet] Rename 'decode' argument in gettransaction method to 'verbose' * Clarify includeWatching for fundrawtransaction * bitcoin-wallet: Add a missing closing parenthesis in the help * Elaborate on the need to re-login on Debian-based systems to use tor following usermod * Prevent UpdateTip log message from being broken up * Qt: advise users not to switch wallets when opening a BIP70 URI. * doc: specify protobuf as optional in build docs * build: disable BIP70 support by default * tests: rename 'test_getnetworkinginfo' in 'test_getnetworkinfo' * tests: add a test for the 'servicesnames' RPC field * doc: add comments clarifying how local services are advertised * Fix block index inconsistency in InvalidateBlock() * util: CBufferedFile fixes * doc: move-only ActivateBestChain doxygen comment to header * signrawtransaction*: improve error for partial signing * signrawtransactionwithkey: better error messages for bad redeemScript/witnessScript * depends: qt: Fix C{,XX}FLAGS pickup * gui: fix autofocus in CreateWalletActivity::askPassphrase() * gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog * gui: rename encrypt(), blank(), and askPasshprase() * qa: Check scantxoutset result against gettxoutsetinfo * rpc: Improve scantxoutset response and help message * Escape ampersands (&) in wallet names in Open Wallet menu * HTML escape address labels in more dialogs and notifications * HTML escape the wallet name in more dialogs and notifications * refactor: Cleanup walletinitinterface.h * doc: Add issue templates for bug and feature request * Added libbitcoin_qt and bitcoin-qt to the msbuild configuration. * Testchains: Qt: Simplify network/chain styles * Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest * Set init stop timeout to 10 min * Add Create Wallet menu action * Expose wallet creation to the GUI via WalletController * Add CreateWalletDialog to create wallets from the GUI * Optionally allow AskPassphraseDialog to output the passphrase * refactor: Avoid locking cs_main in ProcessNewBlockHeaders * gui: Refactor OpenWalletActivity * contrib: guix: Remove ssp spec file hack * contrib: guix: More robust search paths, add checks * depends: zlib: Move toolchain options to configure * Ignore old versionbit activations * doc: add a release note for the new field in 'getpeerinfo' and 'getnetworkinfo' * rpc/net: decode the services flags in a new entry * Assert that the HRP is lowercase in Bech32::Encode * Test that joinpsbts randomly shuffles the inputs * Shuffle inputs and outputs after joining psbts * Conservatively accept RBF bumps bumping one tx at the package limits * Make lint-includes.sh work from any directory * Disconnect peers violating blocks-only mode * doc: improve comments relating to block-relay-only peers * Don't relay addr messages to block-relay-only peers * Add 2 outbound block-relay-only connections * Add comment explaining intended use of m_tx_relay * Check that tx_relay is initialized before access * test: Remove incorrect and unused try-block in assert_debug_log * Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate * devtools: Accomodate block-style copyright blocks * lint: Bump flake8 to 3.7.8 * lint: Disable flake8 W504 warning * test/contrib: Fix invalid escapes in regex strings * wallet: Fix segmentation fault in CreateWalletFromFile * test: Print both messages on failure in assert_raises_message * wallet: Fix documentation around WalletParameterInteraction * doc: ActivateBestChainStep return value * gui: Update English source translation * gui: Update transifex slug for 0.19 * Avoid unnecessary "Synchronizing blockheaders" log messages * qt: Replace objc_msgSend with native syntax * Check for codespell in lint-spelling.sh * GUI: Remove unused menu items for Windows and Linux * doc: Add release note for the new gettransaction argument * tests: Add a new functional test for gettransaction * gettransaction: add an argument to decode the transaction * Don't show addresses or P2PK in decoderawtransaction * [qt] Change uninstall icon on Windows * qt: Replace QFontMetrics::width() with TextWidth() * Add a test wallet_reorgsrestore * Modify wallet tx status if has been reorged out * Add window final block height to getchaintxstats * wallet: extract PubKey from P2PK script with Solver * doc: Delete stale URL in test README * Added the bench_bitcoin project to the list automatically produced by the msvc-autogen python script. * wallet: Translate all initErrors in CreateWalletFromFile * util: Make util/error bilingual_str (refactor) * doc: Tidy up shadowing section * [refactor] Change tx_relay structure to be unique_ptr * [refactor] Move tx relay state to separate structure * test: add executable flag for wallet_watchonly.py * Adds an option to msbuild common configuration to ignore linker warning 4221. This warning is for object files that do not include any symbols. The warning is harmless and occurs due to some classes that are *nix only having no source to compile for an msvc build. * qa: Relax so that the subscriber is ready before publishing zmq messages * ci: Move CCACHE_DIR and test_runner tmp dir into ./ci/scratch/ * ci: Pass down $MAKEJOBS to test_runner.py * test: Establish only one connection between nodes in rpc_invalidateblock * move-only: move coins statistics utils out of RPC * doc: Add spacing to command in translation_process.md * Remove unused fScriptChecks parameter from CheckInputs * Support serialization of std::vector<bool> * rpc bumpfee: move feerate estimation logic into separate method * lint: Catch use of [] or {} as default parameter values in Python functions * Avoid using mutable default parameter values * doc: Update labels in CONTRIBUTING.md * qt: Remove QSignalMapper from TransactionView * qt: Replace obsolete functions of QDesktopWidget * qt: Remove obsolete QModelIndex::child() * wallet: Use wallet name instead of pointer on unload/release * [gui] intro: enable pruning by default unless disk is big * [gui] intro: add prune preference * [gui] intro: inform caller if intro was shown * [gui] add explicit prune setter * [node] add forceSetArg to interface * [Doc] Add documentation for the new whitelist permissions * Replace obsolete functions of QSslSocket * qt: Remove QSignalMapper from RPCConsole * Release notes: add previously undocumented changes * Release notes: edit previously-detached notes * Remove SyncTransaction for conflicted txn in CWallet::BlockConnected * Encapsulate tx status in a Confirmation struct * qt: Add TextWidth() wrapper * gui: Ensure tx send error highlight is visible * packages.md: document depends build targets * Clarify need to specify --prefix with depends * Doc: move detached release notes into release-notes.md * gui: remove unused PlatformStyle::TextColorIcon * refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound * refactor: replace qSort with std::sort * refactor: replace qStableSort with std::stable_sort * build: update RapidCheck Makefile * QA: fix rpc_setban.py race * Make descriptor test deterministic * rpc: Use Join helper in rpc/util * util: Add Join helper to join a list of strings * Unrecommend making config file owned by bitcoin * Set ProtectHome in systemd service file * Chgrp config dir to bitcoin in systemd service * Improve clarity of systemd service file comments * scripts: move update-translations.py to maintainer-tools repo * doc: add default bitcoin.conf locations * scripts: remove github-merge.py * doc: initial RapidCheck property-based testing documentation * doc: add release-notes for getmempoolentry weight field addition * qa: Add RPC tests for weight in mempool entry * RPC: add weight to mempool entry output * Bugfix: QA: Run tests with UPnP disabled * qa: Test ZMQ notification after chain reorg * qa: Refactor ZMQ test * doc: Add note regarding ZMQ block notification * test: Add test for default maxfeerate in sendrawtransaction * wallet/rpc: Use the default maxfeerate value as BTC/kB * doc: Add ZMQ dependencies to Fedora build * Additional tests for other failure cases * Check error messages in descriptor tests * Give more errors for specific failure conditions * Return an error from descriptor Parse that gives more information about what failed * test: Test that low difficulty chain fork is rejected * Reformat p2p_permissions.py * [Fix] The default whitelistrelay should be true * doc: Refer in rpcbind doc to the manpage * test: Pass down correct chain name in tests * [doc] mention whitelist is inbound, and applies to blocksonly * ci: Set --ansi in test_runner * ci: Add environment files for all settings * build: echo prop tests status during build * Add test for setban * Fix spelling error chache -> cache. * Cover UTXO set access with lock annotations * ci: Add note that this assumes a fresh git clone * ci: Use ./ci/ on non-travis host * ci: Remove dependence on travis, use it as fallback env * ci: Add retry * ci: Rename .travis/ to ./ci/ * refactor: have CCoins* data managed under CChainState * doc: Improve versionbits.h documentation * util: Move ResolveErrMsg to util/error * [Fix] Allow connection of a noban banned peer * lint: Add false positive to python dead code linter * qt: Remove menu icons * tests: Use colors and dots in test_runner.py output only if standard output is a terminal -- allows for using the test runner output as input to other programs * test: Test p2sh-witness and bech32 in wallet_import_rescan * test: Replace fragile "rng" with call to random() * test: Generate one block for each send in wallet_import_rescan * [Consensus] Bury segwit deployment * [docs] Add release notes for burying bip 9 soft fork deployments * [Consensus] Bury CSV deployment height * [tests] Add coverage for the content of getblockchaininfo.softforks * Remove unused variable * doc: Fix typos in COPYRIGHT * build: Remove src/obj directory from repository * depends: zeromq: disable draft classes and methods * depends: xproto: configure flags cleanup * depends: qrencode: configure flags cleanup * depends: fontconfig: configure flags cleanup * depends: libxcb: configure flags cleanup * depends: libXau: configure flags cleanup * descriptor: fix missed m_script_arg arg renaming in #14934 * Add missing contributor to release notes * build: ignore macOS make deploy artefacts & add them to clean-local * [rpc] Tidy up reporting of buried and ongoing softforks * Moved and renamed hash256 from util.py to zmq_interface.py * rpc: Fix getblocktemplate CLI example (#16594) * Add test for AddTimeData * travis: Bump timeout from 50 minutes to 90 * doc: Mention other ways to conserve memory on compilation * build: Remove unused src/obj-test folder * doc: Update Markdown syntax for bdb packages * Add functional tests for flexible whitebind/list * Replace the use of fWhitelisted by permission checks * Do not disconnect peer for asking mempool if it has NO_BAN permission * Make whitebind/whitelist permissions more flexible * sipsorcery gitian key. * Give QApplication dummy arguments * [wallet] Restore confirmed/conflicted tx check in SubmitMemoryPoolAndRelay() * doc: Add historical release notes for 0.18.1 * build: disable libsecp256k1 benchmarks * Remove p2pEnabled from Chain interface * Fix Char as Bool in interfaces * util: refactor upper/lowercase functions * Do not query all DNS seed at once * Add unmodified-but-with-checksum to getdescriptorinfo * Factor out checksum checking from descriptor parsing * [wallet] restore coinbase check in SubmitMemoryPoolAndRelay() * refactor: pcoinsTip -> CChainState::CoinsTip() * build: disable libxcb extensions * test: only include and init openSSL where it's actually used * [doc] chain: Declare BLOCK_VALID_HEADER reserved * doc: Fix grammar and punctuation in developer notes * test: Add missing sync_blocks to feature_pruning * [doc] Update and extend benchmarking.md * test: Explain why -whitelist is used in feature_fee_estimation * test: Format feature_fee_estimation with pep8 * test: Avoid hardcoding the chain name in combine_logs * [build] .gitignore add Qt Creator Makefile.am.user * log: harmonize bitcoind server logging * Tidy up BroadcastTransaction() * Remove unused submitToMemoryPool and relayTransactions Chain interfaces * Remove duplicate checks in SubmitMemoryPoolAndRelay * Introduce CWalletTx::SubmitMemoryPoolAndRelay * Add BroadcastTransaction utility usage in Chain interface * Test: Set -acceptnonstdtxn in feature_fee_estimation * gui: Remove unused RPCConsole::tabFocus * test: Adapt test framework for chains other than "regtest" * test: Fix “local variable 'e' is assigned to but never used” * test: Make tests arg type specific * Revamp option negating policy * wallet: Drop unused OldKey * doc: Add release note for the deprecated totalFee option of bumpfee * Changes the verbosity of msbuild from quiet to normal in the appveyor script. Increasing the verbosity helps to identify the cause of build errors which is the main purpose of the appveyor script. * autoconf: Sane --enable-debug defaults. * test: Add -acceptnonstdtxn to self.extra_args[3] * gui: Generate bech32 addresses by default (take 2, fixup) * [wallet] Remove CMerkleTx serialization logic * [wallet] Flatten CWalletTx class hierarchy * [wallet] Move CMerkleTx functions into CWalletTx * test: Bump rpc_timeout in feature_dbcrash * Add setting as known type * qa: fix deprecated log.warn in feature_dbcrash test * doc: update labels in CONTRIBUTING.md * Allow createwallet to take empty passwords to make unencrypted wallets * Updated python command in readme so it will work on systems that have both python2 and 3 installed. * scripts: filter more qt plugins we don't use in macdeployqtplus * scripts: misc cleanups in macdeployqtplus * scripts: use format() in macdeployqtplus * scripts: add type annotations to macdeployqtplus * Trivial: add missing space * wallet: Rename CWalletKey to OldKey * wallet: Enumerate walletdb keys * Replace IsArgKnown() with FlagsOfKnownArg() * Use ArgsManager::NETWORK_ONLY flag * rpc: sendrawtransaction unconditionality/privacy note * [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 * [doc] rpc: remove "fallback to" from RBF default help * [rpc] walletcreatefundedpsbt: use wallet default RBF * Remove unused m_debug_only member from Arg struct * scripted-diff: Use ArgsManager::DEBUG_ONLY flag * scripted-diff: Use Flags enum in AddArg() * Add Flags enum to ArgsManager * Refactor InterpretNegatedOption() function * refactoring: Check IsArgKnown() early * [mempool] log correct messages when CPFP fails * test: Fail early on disconnect in mininode.wait_for_* * Add RPC bumpfee totalFee deprecation test * deprecate totalFee argument in bumpfee RPC call * Exclude depends/Makefile in .gitignore * [qa] Ensure we don't generate a too-big block in p2sh sigops test * [qa] Fix race condition in example_test.py * doc: add note on precedence of options in bitcoin.conf * refactor : use RelayTransaction in BroadcastTransaction utility * doc: Remove downgrading warning in release notes, per 0.18 branch * Enable all tests in feature_config_args.py * Use CheckDataDirOption() for code uniformity * Fix datadir handling in bitcoin-cli * Fix datadir handling in bitcoin-qt * Fix datadir handling in bitcoind * Add CheckDataDirOption() function * Return absolute path early in AbsPathForConfigVal * Have importwallet use ImportPrivKeys and ImportScripts * Optionally allow ImportScripts to set script creation timestamp * Have importaddress use ImportScripts and ImportScriptPubKeys * Have importpubkey use CWallet's ImportScriptPubKeys and ImportPubKeys functions * scripted-diff: Make translation bilingual * Add bilingual message type * Refactor out translation.h * tests: functional watch-only wallet tests * doc: add release note for include_watchonly default changes * depends: disable unused Qt features * doc: remove line numbers from qt package links * doc: fix typo in bitcoin_qt.m4 comment * build: remove jpeg lib check from bitcoin_qt.m4 * build: disable libjpeg in qt * test: Skip flaky p2p_invalid_messages test on macOS * wallet: Recognize -disablewallet option early * travis: Print memory and number of cpus * extract min & max depth onto coin control * Remove ReadVersion and WriteVersion * Log the actual wallet file version * Remove nFileVersion from CWalletScanState * Specify AM_CPPFLAGS for ZMQ. * txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN * move-onlyish: move CCoinsViewErrorCatcher out of init.cpp * doc: Update bips 35, 37 and 111 status * build: Treat -Wswitch as error when --enable-werror * Use switch on status in RpcWallet * Return error for ignored passphrase through disable private keys option * Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and ImportScriptPubKeys * Log when an import is being skipped because we already have it * test: remove redundant setup in addrman_tests * depends: qt: Patch to remove dep on libX11 * gitignore: Actually pay attention to depends patches * Add release notes for DEFAULT_BLOOM change * rpcwallet: document include_watchonly default for watchonly wallets * rpcwallet: default include_watchonly to true for watchonly wallets * QA: Fix race condition in wallet_encryption test * Get rid of PendingWalletTx class. * depends: Bump QT to LTS release 5.9.8 * net: Make poll in InterruptibleRecv only filter for POLLIN events. poll should block until there is data to be read or the timeout expires. * symbol-check: Disallow libX11-*.so.* shared libraries * depends: libXext isn't needed by anyone * build-aux: Remove check for x11-xcb * depends: libX11: Make package headers-only * depends: qt: Explicitly stop using Xlib/libX11 * depends: xproto is only directly needed by libXau * fix: tor: Call event_base_loopbreak from the event's callback * Use strong enum for WalletCreationStatus * Place out args at the end for CreateWallet * Remove wallet settings from chainparams * qa: Add --filter option to test_runner.py * docs: Improve netbase comments * doc: describe how to pass wildcard names to test runner * test: enable passing wildcards with path to test runner * Remove unused bits from the service flags enum * contrib: guix: Additional clarifications re: substitutes * Fix autostart filenames on Linux * contrib: guix: Various improvements. * contrib: guix: Clarify SOURCE_DATE_EPOCH. * contrib: Add deterministic Guix builds. * Change ImportScriptPubKeys' internal to apply_label * Call node->initError instead of InitError from GUI code * init: Use InitError for all errors in bitcoind/qt * Restrict lifetime of ReserveDestination to CWallet::CreateTransaction * CreateTransaction calls KeepDestination on ReserveDestination before success * Remove redundant pre-TopUpKeypool checks * test: Add test for maxtxfee option * Move wallet creation out of the createwallet rpc into its own function * Add GetNewChangeDestination for getting new change Destinations * Replace CReserveKey with ReserveDestinatoin * Add GetNewDestination to CWallet to fetch new destinations * Move WatchOnly stuff from SigningProvider to CWallet * Remove CCryptoKeyStore and move all of it's functionality into CWallet * Move various SigningProviders to signingprovider.{cpp,h} * Move KeyOriginInfo to its own header file * scripted-diff: rename CBasicKeyStore to FillableSigningProvider * Move HaveKey static function from keystore to rpcwallet where it is used * [mempool] Allow one extra single-ancestor transaction per package * Remove CKeyStore and squash into CBasicKeyStore * test: Add test for BIP30 duplicate tx * test: Properly serialize BIP34 coinbase height * Remove redundant WalletController::addWallet slot * depends: expat 2.2.7 * Update doc and CI config * qt: Assert QMetaObject::invokeMethod result * gui: Fix missing qRegisterMetaType(WalletModel*) * test: rpc_users: Make variable names more clear. * test: rpc_users: Also test rpcauth.py with specified password. * test: rpc_users: Add function for testing auth params. * test: rpc_users: Add function for auth'd requests. * refactoring: remove mapBlockIndex global * refactoring: make pindexBestInvalid internal to validation.cpp * refactoring: add block_index_candidates arg to LoadBlockIndex * refactoring: move block metadata structures into BlockManager * refactor: Rename getWallets to getOpenWallets in WalletController * gui: Sort wallets in open wallet menu * test: Tool wallet test coverage for unexpected writes to wallet * test: Split tool_wallet.py test into subtests * test: Add log messages to test/functional/tool_wallet.py * rpc: switch to using RPCHelpMan.Check() * Make the RPCHelpMan aware of JSONRPCRequest and add Check() helper * build: prune dbus from depends * Remove unused guard * doc: Include static members in Doxygen * docs: add reduce-memory.md * [build]: use #if HAVE_SYSTEM instead of defined(HAVE_SYSTEM) * bench: Benchmark blockToJSON * [docs] Add release notes for PR 15427 * rpc: migrate JSONRPCRequest functionality into request.cpp * Disable other targets when enable-fuzz is set * Enable ShellCheck rules * [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables * Add HaveKey and HaveCScript to SigningProvider * Use placeholder instead of key expiration date * Add logpath description for getrpcinfo * Suppress output in test_bitcoin for expected errors * Add ChaCha20Poly1305@Bitcoin AEAD benchmark * Add ChaCha20Poly1305@Bitcoin tests * rpc: fix RPC help requirements for getblocktemplate * test: Split fundrawtx test into subtests * test: Make local symbols in run_test members * test: Add tests for getblockchaininfo.softforks * bench: Move generated data to a dedicated translation unit * rpc: Clarify that block count means height excl genesis * wallet: Remove unreachable code in CreateTransaction * wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction * Add antialiasing to traffic graph widget * TEST: Replace hard-coded hex tx with classes * Improve documentation of memory_cleanse() * [MSVC] Copy build output to src/ automatically after build * Fix: "Bitcoin Core" -> "The Bitcoin Core" * Drop no-longer-relevant copyright holder name * Include Objective-C source files * doc: Fix broken link in doc/build-osx.md * [MSVC] allow user level project customization * [wallet] abort when attempting to fund a transaction above maxtxfee * test: Add missing sync_all to wallet_balance test * [MSVC] Enable Fuzz for functional tests * qt: test: Create at most one testing setup * util: No translation of `Bitcoin Core` in the copyright * util: Explain why the path is cached * tests: Switch one of the Travis jobs to an unsigned char environment (-funsigned-char) * tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests * qt: Run «make translate» in ./src/ * scripted-diff: Avoid passing PACKAGE_NAME for translation * build: Stop translating PACKAGE_NAME * Add Travis check for single parameter constructors not marked "explicit" * Add missing ECC_Stop(); in GUI rpcnestedtests.cpp * Remove extra CBlockIndex declaration * Fix GCC 7.4.0 warning * Add ChaCha20Poly1305@Bitcoin AEAD implementation * signrawtransactionwithkey: report error when missing redeemScript/witnessScript param * rpc: Allow shutdown while in generateblocks * build: dont compile rapidcheck with -Wall * test: Require standard txs in regtest * docs: release note wording * wallet/rpc: use static help text * wallet/rpc/getbalances: add entry for 'mine.used' balance in results * Use qInfo() if no error occurs * [MSVC]: Create the config.ini as part of bitcoind build * doc: remove orphaned header in developer notes * ci: Run extended tests * Set AA_EnableHighDpiScaling attribute early * test: Log to debug.log in all tests * Make and get the multisig redeemscript and destination in one function instead of two * net: Document what happens to getdata of unknonw type * test: use common setup in gui tests * test: Create data dir in BasicTestingSetup * MSVC: Fix error in debug mode (Fix #16245) * Change ismine to take a CWallet instead of CKeyStore * Move ismine to wallet module * [qa] Test that getdata requests work as expected * Make AbortNode() aware of MSG_NOPREFIX flag * Add MSG_NOPREFIX flag for user messages * Prepend the error/warning prefix for GUI messages * doc: Remove travis badge from readme * docs: add rapidcheck to vcpkg install list * Cleaned up and consolidated msvc build files to allow faster builds and easier migration to vs2019. * test: Suppress false positive leak in secure_allocator<RNGState> * test: Log output even if fuzzer failed * test: Add test that mainnet requires standard txs * chainparams: Remove unused fMineBlocksOnDemand * test: Add test for unknown args * gui: Fix open wallet menu initialization order * net: Use mockable time for tx download * tests: Make coins_tests/updatecoins_simulation_test deterministic * devtools: Fetch and display ACKs at sign-off time in github-merge * getrawtransaction: inform about blockhash argument when lookup fails * doc: Add release notes for 14897 & 15834 * travis: Use absolute paths for cache dirs * travis: Fix caching issues * Improve build-osx formatting * doc: Remove explicit mention of version from SECURITY.md * addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. * Add example 2nd arg to signrawtransactionwithkey * Update configure to reject unsafe miniUPnPc API ver * Replace remaining fprintf with tfm::format manually * Failing functional tests stop lcov * Add log output during initial header sync * scripted-diff: Replace fprintf with tfm::format * doc: Rework section on ACK * tinyformat: Add doc to Bitcoin Core specific strprintf * Delete error-prone CScript constructor * devtools: Always use unabbreviated commit IDs in github-merge.py * depends: xtrans: Configure flags cleanup. * Fix spelling errors identified by codespell 1.15.0 * fixup: Fix prunning test * Fix RPC/pruneblockchain returned prune height * scripted-diff: gitian: Use REFERENCE_DATETIME directly. * Remove -mempoolreplacement to prevent needless block prop slowness. * Add test for dumping the private key imported from descriptor * Extend importmulti descriptor tests * [test] Add test to check mempool consistency in case of reorgs * validation: Add missing mempool locks * txpool: Make nTransactionsUpdated atomic * doc: update release process with SECURITY.md * doc: clarify support in SECURITY.md * scripts: add key for fanquake to trusted keys list * doc: Add release notes for 15993 * Align formatting with clang-format * Use PACKAGE_NAME in UPnP description * Drop support of insecure miniUPnPc versions * Move DEFAULT_PEERBLOOMFILTERS from validation.h to net_processing.h * Disable bloom filtering by default. * Import private keys from descriptor with importmulti if provided * Add private key derivation functions to descriptors * [build]: check std::system for -[alert|block|wallet]notify * [build] MSVC: set HAVE_SYSTEM for desktop apps * [build] detect std::system or ::wsystem * Clean up logic in memory_cleanse() for MSVC * Include core_io.h from core_read.cpp * Don't use global (external) symbols for symbols that are used in only one translation unit * depends: remove usage of TAR_OPTIONS * docs: create security policy * [qa] Test disconnect block failure -> shutdown * [validation] Crash if disconnecting a block fails * wallet: do not encrypt wallets with disabled private keys * tests: Mark unit test blockfilter_index_initial_sync as non-deterministic * build: remove export GZIP from gitian descriptors * Add riscv64 to outputs list in release-process.md * qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 * gui: Set progressDialog to nullptr * New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. * Added comments referencing multiple CVEs in tests and production code. * Make reasoning about dependencies easier by not including unused dependencies * Add test for GCC bug 90348 * Don't GPG sign intermediate commits with github-merge tool * gui: Enable console line edit on setClientModel * Limit Python linting to files in the repo * gui: Enable open wallet menu on setWalletController * bitcoind: update -avoidpartialspends description to account for auto-enable for avoid_reuse wallets * doc: release notes for avoid_reuse * wallet: enable avoid_partial_spends by default if avoid_reuse is set * test: add test for avoidreuse feature * wallet/rpc: add 'avoid_reuse' option to RPC commands * wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS * wallet: enable avoid_reuse feature * wallet: avoid reuse flags * wallet: make IsWalletFlagSet() const * wallet: rename g_known_wallet_flags constant to KNOWN_WALLET_FLAGS * Fix bug around transaction requests * Expire old entries from the in-flight tx map * logging: Add threadsafety comments * Log early messages with -printtoconsole * Replace OpenDebugLog() with StartLogging() * docs: add release note for 14954 * contrib: add curl as a required program in gitian-build.py * gui: move coin control OK to the right * wallet: Pass WalletBatch to CWallet::UnsetWalletFlag * Apply the batch treatment to CWallet::SetAddressBook via ImportScriptPubKeys * depends: libX*: --disable-malloc0returnsnull in conf * Move some of ProcessImport into CWallet::Import* * depends: libXext: Bump to 1.3.3 to fix _XEatDataWords * depends: Purge libtool archives * depends: Build secondary deps statically. * Exceptions should be caught by reference, not by value. * Add vertical spacer * Remove global symbols: Avoid using the global namespace if possible * depends: add ability to skip building zeromq * contrib: use newer config.guess & config.sub in install_db4.sh * remove parameters -addresstype=legacy in rpc_rawtransaction test * configure: Add flag for enabling thread_local. * util: Add type safe GetTime * doc: add bitcoin_config.h PACKAGE updates to release process * build: bump bitcoin_config.h packages to v0.18 * wallet_balance.py: Prevent edge cases * replace tx hash with txid in test rawtransaction * refactor: Improve CRollingBloomFilter::reset by using std::fill * bench: Add benchmark for CRollingBloomFilter::reset * rpc: Mention getwalletinfo where a rescan is triggered * RPC: Hint for importmulti in help output of importpubkey and importaddress * parameterize hard coded numbers referring to miner conf window * depends: switch to secure download of all dependencies * mempool: remove unused magic number from consistency check * Make --setup command independent * depends: add patch to common dependencies * doc: fix/improve analyzepsbt in doc/psbt.md * Do not show list for the only recipient. * Batch writes for importmulti * Have WalletBatch automatically flush every 1000 updates * Add AddWatchOnlyWithDB, AddKeyOriginWithDB, AddCScriptWithDB functions * Fix gitian-build.py --verify option * Set/unset USE_LXC, USE_VBOX, USE_DOCKER explicitly * Fix Docker related issues for gitian-build.py * test: Speed up cache creation * test: Bump MAX_NODES to 12 * scripted-diff: Rename LockAnnotation to LockAssertion * Make sure the compile-time locking promises given via LockAnnotation:s hold also in practice at runtime (ifdef DEBUG_LOCKORDER) * Move LockAnnotation to make it reflect the truth * Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code) * Add a 'logpath' field to getrpcinfo * rpc: bugfix: Properly use iswitness in converttopsbt * Remove temporary method assumeLocked(). Remove LockingStateImpl. Remove redundant cs_main locks. * wallet: Use chain.lock() instead of temporary chain.assumeLocked() * rpc: Switch touched RPCs to IsValidNumArgs * Run all lint scripts * refactoring: IsInitialBlockDownload -> CChainState * refactoring: FlushStateToDisk -> CChainState * refactoring: introduce ChainstateActive() * move-only: make the CChainState interface public * build with -fstack-reuse=none * tests: Fail if RPC has been added without tests * netaddress: Update CNetAddr for ORCHIDv2 * docs: Add productivity notes for "dummy rebases" * [doc] rpcwallet: Only fail rescan when blocks have been pruned * validation: Hold cs_main when reading chainActive in RewindBlockIndex * [rpc] deriveaddresses: Correct descriptor checksum in RPCExamples * Disallow extended encoding for non-witness transactions (take 3) * Add option to create an encrypted wallet * [refactor] interfaces: Add missing LockAnnotation for cs_main * init: Remove dead code in LoadChainTip * doc: Mention blocksonly in reduce-traffic.md, unhide option * test: Add test for p2p_blocksonly * QA: add test for HKDF HMAC_SHA256 L32 * Add HKDF HMAC_SHA256 L=32 implementations * Add support for descriptors to utxoupdatepsbt * Abstract out UpdatePSBTOutput from FillPSBT * Abstract out EvalDescriptorStringOrObject from scantxoutset * Abstract out IsSegWitOutput from utxoupdatepsbt * [docs] Update release-notes.md * [docs] Update release-process.md * rpc: faster getblockstats using BlockUndo data * test: Format predicate source as multiline on error * Give WalletModel::UnlockContext move semantics * [tests] Make random seed logged and settable * net: Rename ::fRelayTxes to ::g_relay_txes * tests: Make msg_block a witness block * doc: Remove win32 from the release process * test: Remove True argument to CBlock::serialize * Show loaded wallets as disabled in open menu instead of nothing * Add LOCKS_EXCLUDED(cs_main) to LimitValidationInterfaceQueue(...) which does AssertLockNotHeld(cs_main) * .gitignore: Don't ignore depends patches * Add test for ArgsManager::GetChainName * Add unit test NextString, ForEachNoDup functions * util_SettingsMerge test cleanup * fix static_assert for macro HAVE_THREAD_LOCAL * Fix portability issue with pthreads * Document strenghtening * Add hash strengthening to the RNG * Do not construct out-of-bound pointers in SHA512/SHA1/RIPEMD160 code * scripted-diff: Bump copyright headers in wallet * wallet: Only fail rescan when blocks have actually been pruned * Add ChaCha20 bench * test_runner: Move pruning back to extended * refactoring: remove unused chainActive * scripted-diff: replace chainActive -> ::ChainActive() * refactoring: introduce unused ChainActive() * rename: CChainState.chainActive -> m_chain * Add ChaCha20 encryption option (XOR) * rpc: Deprecate getunconfirmedbalance and getwalletinfo balances * Remove Windows 32 bit build * [tests] Comment for why logging config is set as command-line args. * Install bitcoin-wallet manpage. * [depends] boost: update to 1.70 * Separate reason for premature spends (coinbase/locktime) * Assert validation reasons are contextually correct * [refactor] Update some comments in validation.cpp as we arent doing DoS there * [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible() * scripted-diff: Remove DoS calls to CValidationState * [refactor] Prep for scripted-diff by removing some \ns which annoy sed. * Allow use of state.Invalid() for all reasons * Fix handling of invalid headers * [refactor] Use Reasons directly instead of DoS codes * CorruptionPossible -> BLOCK_MUTATED * CorruptionPossible -> TX_WITNESS_MUTATED * LookupBlockIndex -> CACHED_INVALID * [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible * [refactor] Add useful-for-dos "reason" field to CValidationState * rpc: Add lock annotations to block{,header}ToJSON * Ban all peers for all block script failures * Clean up banning levels * [refactor] drop IsInvalid(nDoSOut) * [refactor] Refactor misbehavior ban decisions to MaybePunishNode() * [refactor] rename stateDummy -> orphan_state * Drop obsolete sigops comment * rpc: Add getbalances RPC * doc: Add historical release notes for 0.18.0 * rpcwallet: Make helper methods const on CWallet * Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp * GUI: Move QRImageWidget to its own file-pair * doc: Add release notes for 15730 * rpc: Show scanning details in getwalletinfo * wallet: Track current scanning progress * doc: Explain how to pass in non-fundamental types into functions * [docs] Add doxygen comment for CReserveKey * [docs] Add doxygen comment for CKeyPool * rpc: Serialize in getblock without cs_main * rpc: Use IsValidNumArgs in getblock * wallet: Use IsValidNumArgs in getwalletinfo rpc * GUI: Refactor actual QR code rendering into new QRImageWidget::setQR * [tests] log thread names by default in functional tests * test: Add reorg test to wallet_balance * test: Check that wallet txs not in the mempool are untrusted * test: Add getunconfirmedbalance test with conflicts * test: Add wallet_balance test for watchonly * [qa] test_runner: Move feature_pruning to base tests * Replace deprecated Boost Filesystem function * [tests] fix block time in feature_pruning.py * Remove dead code for walletFile check * threads: add thread names to deadlock debugging message * threads: prefix log messages with thread names * tests: add threadutil tests * threads: introduce util/threadnames, refactor thread naming * GetKeyBirthTimes should return key ids, not destinations * Replace CScriptID and CKeyID in CTxDestination with dedicated types * add missing debian contrib files to tarball * Remove unused OpenSSL includes to make it more clear where OpenSSL is used * wallet: Avoid logging no_such_file_or_directory error * lint: Check that all wallet args are hidden * wallet: Track scanning duration * Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options * dummywallet: Reformat ignored wallet options list * remove extraneous scope * wallet: log on rescan completion * Include bitcoin_config.h in release process * Align MSVC build options with Linux build ones * disable HAVE_THREAD_LOCAL on unreliable platforms * appveyor: Write @PACKAGE_NAME@ to config * doc: explain AcceptToMemoryPoolWorker's coins_to_uncache * Remove NOTFOUND transactions from in-flight data structures * Add an explicit memory bound to m_tx_process_time * Improve NOTFOUND comment * Add test for superfluous witness record in deserialization * Fix missing input template by making minimal tx * QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one * QA: feature_filelock, interface_bitcoin_cli: Use PACKAGE_NAME in messages rather than hardcoding Bitcoin Core * QA: Avoid re-reading config.ini unnecessarily * Doc: remove text about txes always relayed from -whitelist * Align code example with clang-format * Show recipient list as detailedText of QMessageBox * Make SendConfirmationDialog fully fledged * doc: Fix -dustrelayfee= argument docs grammar * refactor: replace isPotentialtip/waitForNotifications by higher method * Resolve the qt/guiutil <-> qt/optionsmodal CD * wallet: add cachable amounts for caching credit/debit values * test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan * Add settings merge test to prevent regresssions * rpc: Speedup getaddressesbylabel * Ensure repos are up-to-date * Add WITH_LOCK macro: run code while locking a mutex * wallet: Remove unused import checkpoints.h * Add comments to Python ECDSA implementation * [POLICY] Make sending to future native witness outputs standard * Pure python EC * [wallet] Move maxTxFee to wallet * tests: fix outdate include in blockfilter_index_tests * [test] combine_logs: append node stderr and stdout if it exists * contrib: gh-merge: Use pagination to fetch all review comments * refactor: Add handleNotifications method to wallet * Filter IPv6 by ASN * rpc: Remove dependency on interfaces::Chain in SignTransaction * test: Add test that addmultisigaddress fails for watchonly addresses * test: Fixup creatmultisig documentation and whitespace * doc: Remove upgrade note in release notes from EOL versions * qt: update request payment button text and tab description * bench: Add wallet_balance benchmarks * remove out-of-date comment on pay-to-witness support * doc: Clarify RPC versioning * [wallet] move-only: move CReserveKey to be next to CKeyPool * Include cstring for sanity_test_fdelt if required * [moveonly] Split glibc sanity_test_fdelt out * Extract ParseDescriptorRange * gitignore: add *.plist (clang-check) * gitignore: add *.dat * doc: mention creating application support bitcoin folder on OSX * GUI: Options: Remove the upper-bound limit from pruning size setting * GUI: Options: Set the range of pruning size before loading its value * [rpc] Remove the addresses field from the getaddressinfo return object * travis: Bump second timeout to 33 minutes, Add rationale * scripted-diff: Bump copyright headers in test, bench * docs: Clarify PR guidelines w/re documentation * scripted-diff: Rename test_bitcoin to test/setup_common * doc: describe onlynet option in doc/tor.md * wallet_bumpfee.py: add test for change key preservation * add functional tests for feerate bumpfee with adding inputs * generalize bumpfee to add inputs when needed * test: Use test_bitcoin setup in bench, Add test utils * test: Have segwit always active in (Basic)TestingSetup * docs: Improve netaddress comments * [cleanup] Remove unused CReserveKey * [rpc] simplify generate RPC * bitcoin-wallet tool: Drop libbitcoin_server.a dependency * Remove access to node globals from wallet-linked code * bitcoin-wallet tool: Drop MakeChain calls * [wallet] Refactor CWalletTx::RelayWalletTransaction() * Avoid redefine warning * [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp * [docs] Document src subdirectories and different libraries * [build] Move wallet load functions to wallet/load unit * [build] Add several util units * [build] Move several units into common libraries * [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp * [build] Move rpc utility methods to rpc/util * [build] Move policy settings to new src/policy/settings unit * [build] Move CheckTransaction from lib_server to lib_consensus * test: Remove unused imports * scripted-diff: use self.sync_* methods * test: Pass self to test_simple_bumpfee_succeeds * test: Add BitcoinTestFramework::sync_* methods * test: Pass at most one node group to sync_all * [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransactions * [wallet] Schedule tx rebroadcasts in wallet * [wallet] Keep track of the best block time in the wallet * qa: Prevent concurrency issues reading .cookie file * scripted-diff: Rename sync_blocks to send_blocks to avoid name collisions and confusion * test: Properly log named args in authproxy * rpc: Validate maxfeerate with AmountFromValue * doc: correct bitcoinconsensus_version in shared-libraries * Upgrade gitian image before signing * doc: Clarify sendrawtransaction::maxfeerate==0 help * blockfilter: Update BIP 158 test vectors. * rpc: Add getblockfilter RPC method. * init: Add CLI option to enable block filter index. * index: Access functions for global block filter indexes. * test: Unit test for block filter index reorg handling. * test: Unit tests for block index filter. * index: Implement lookup methods on block filter index. * index: Implement block filter index with write operations. * serialize: Serialization support for big-endian 32-bit ints. * blockfilter: Functions to translate filter types to/from names. * index: Ensure block locator is not stale after chain reorg. * index: Allow atomic commits of index state to be extended. * Take non-importing keys into account for spendability warning in descriptor import * Update bips.md for 0.18.0 * Mention new descriptor RPCs in descriptors.md * travis: Properly cache and error on timeout * Mention new PSBT RPCs in psbt.md * Remove unused var * rpc: getrpcinfo docs * qa: Make swap_magic_bytes in p2p_invalid_messages atomic * Speed up deriveaddresses for large ranges * Import all origin info in importmulti; even for non-importing pubkeys * Keep full pubkeys in FlatSigningProvider::origins * wallet: Get all balances in one call * rpc: RPCHelpMan: Always push_name when outer type is an object * rpc: Add some doxygen comments to utils * change default Python block serialization to witness * [qa] Overhaul p2p_compactblocks.py * [wallet] Remove ResendWalletTransactionsBefore * gui: Generate bech32 addresses by default * Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063 * qa: Check unconfirmed balance after loadwallet * wallet: Update transactions with current mempool after load * interfaces: Add Chain::requestMempoolTransactions * [rpc] remove resendwallettransactions RPC * Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. Remove no-op CClientUIInterface::[signal_name]_disconnect. * [tests] make pruning test faster * [tests] style fixes in feature_pruning.py * travis: Switch to ubuntu keyserver to avoid timeouts * Silence "Test case [...] did not check any assertions" warnings when running "test_bitcoin --log_level=test_suite" * Avoid repeated log messages in tests by connecting to signal handlers (ThreadSafeMessageBox, etc.) only once * tests: Reduce noise level in test_bitcoin output * Comment for seemingly duplicate LIBBITCOIN_SERVER * doc: rpc-mining: Clarify error messages * doc/dependencies: Fix typo libsrvg->librsvg * rpc: Fix help text for signtransactionwithXXX * release: Update the Windows Codesigning certificate * refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight * wallet: Move CWallet::ReacceptWalletTransactions locks to callers * [tests] Add test for wallet rebroadcasts * QA: add test for CKey::Negate() * CKey: add method to negate the key * Add documentation of struct PSBTAnalysis et al * Refactor analyzepsbt for use outside RPC code * Move PSBT decoding functions from core_io to psbt.cpp * Poly1305: tolerate the intentional unsigned wraparound in poly1305.cpp * Add Poly1305 bench * Add Poly1305 implementation * [docs] fix comment: the return value of findFork is _not_ an ancestor when the specified block is on the active chain * Remove unused AES-128 code * depends: latest rapidcheck, use INSTALL_ALL_EXTRAS * rpc: Rename size to vsize in mempool related calls * Handle the result of posix_fallocate system call * Resolve the checkpoints <-> validation CD. * net: Remove unused unsanitized user agent string CNode::strSubVer * torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently * Interrupt orphan processing after every transaction * [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx * Simplify orphan processing in preparation for interruptibility * docs: Add more tips to productivity.md * [docs] remove reference to signrawtransaction in the developer docs. * doc: Fix all typos reported by codespell * contrib: gh-merge: Include review comments in merge commit * [rpc] Remove deprecated functionality message from validateaddress help * [rpc] Remove signrawtransaction warning * gui: Defer removeAndDeleteWallet when no modal widget is active * Move g_is_mempool_loaded into CTxMemPool::m_is_loaded * rpc: Expose g_is_mempool_loaded via getmempoolinfo and /rest/mempool/info.json * doc: Add release notes for 15629 * qa: Add test for missing testnet section in conf file * doc: documents how to calculate m_assumed_blockchain_size and m_assumed_chain_state_size on the release process. * doc: Add release notes for 15596 * Doc: update ACK description in CONTRIBUTING.md * refactor: Remove unused function * qa: mininode: Clearer error message on invalid magic bytes * doc: Add release notes for 15620 * init: Throw error when network specific config is ignored * rpc: Mention all output types in decodescript doc * refactor: Expose UndoReadFromDisk in header * rpc: Uncouple rpcs from maxTxFee global * rpc: Use IsValidNumArgs over hardcoded size checks * refactor: Remove unused function * depends: qt: Don't hardcode pwd path * depends: tar: Always extract as yourself * depends: Defer to Python detected by autoconf * Do not relay banned IP addresses * rpc: decodescript use IsValidNumArgs over hardcoded check * rpc: Clarify decodescript RPCResult doc * Add Gitian key for droark * Set 'distro' explicitly * [docs] release note for disabling reject messages by default * wallet: Improve log output for errors during load * wallet: Remove unused GetLegacyBalance * scripted-diff: wallet: Rename pcoin to wtx * build: depends: Switch to python3 * Generate log entry when blocks messages are received unexpectedly. * wallet/rpc: add maxfeerate parameter to sendrawtransaction * wallet/rpc: add maxfeerate parameter to testmempoolaccept * wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree * rpc: Document that minconf is an ignored dummy value * rpc: return a number for estimated_feerate in analyzepsbt * doc: correct analysepsbt rpc doc * Fix overflow bug in analyzepsbt fee: CAmount instead of int * depends: native_protobuf: avoid system zlib * Enable TLS in link to chris.beams.io * dead code: Remove dead option in HexStr conversion * cli: remove duplicate wallet fields from -getinfo * cli: replace testnet with chain and return network name as per BIP70. * doc: remove release note fragments * doc: correct path in build-windows.md * rest/rpc: Make mempoolinfo atomic * rpc: Speedup getrawmempool when verbose=true * build: use full version string in setup.exe * gitian: Improve error handling * Remove remaining wallet accesses to node globals * test: Refactor vout fetches in rpc_rawtransaction * tests: Print remaining jobs in test_runner.py * wallet_bumpfee.py: Make sure coin selection produces change * Remove use of CCoinsViewMemPool::GetCoin in wallet code * Remove use of CRPCTable::appendCommand in wallet code * Remove use CValidationInterface in wallet code * Document assumptions about C++ compiler * Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter * In lint-format-strings, open files sequentially * test: .style.yapf: Set column_limit=160 * test: Remove python3.4 workaround in feature_dbcrash * doc: Move wallet lock annotations to header * Suggested interfaces::Chain cleanups from #15288 * contrib: Bump gitian descriptors for 0.19 * doc: Remove pr release notes file in wrong dir * Add sizeof(size_t) assumptions * Fixup whitespace * scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SIZE * Make SignatureExtractorChecker private to its own file * Make last disconnected block BLOCK_FAILED_VALID, even when aborted * doc: Remove ppa from linux build instructions * .python-version: Specify full version 3.5.6 * scripted-diff: Update copyright in ./test * scripted-diff: test: Remove brackets after assert * build: Require python 3.5 * scripted-diff: test: Use py3.5 bytes::hex() method * build: Bump version to 0.18.99 * docs: Update Transifex links * docs: add "sections" info to example bitcoin.conf * [addrman] Improve collision logging and address nits * modify test for memory locked in case locking pages failed at some point * [rpc] deriveaddresses: add range to CRPCConvertParam * [wallet] remove unused GetScriptForMining * Add regtests for HTTP status codes. * Make deriveaddresses use stop/[start,stop] notation for ranges * test: Bump timeout on tests that timeout on windows * appveyor: Don't build debug libraries instead of "build and delete" * Optimization: don't add txn back to mempool after 10 invalidates * Prevent callback overruns in InvalidateBlock and RewindBlockIndex * Release cs_main during InvalidateBlock iterations * Use stop/[start,stop] notation in importmulti desc range * Add support for stop/[start,stop] ranges to scantxoutset * Support ranges arguments in RPC help * Add ParseRange function to parse args of the form int/[int,int] * fuzz: Link BasicTestingSetup (shared with unit tests) * test: Move main_tests to validation_tests * test: Remove useless test_bitcoin_main.cpp * test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD * msvc: Use a single file to specify the include path * [addrman] Ensure collisions eventually get resolved * [rpc] remove deprecated generate method * [net] feeler connections can be made to outbound peers in same netgroup * doc: Update release process for snap package * test: Add .style.yapf * add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo * [addrman] Improve tried table collision logging * refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction * doc: Remove misleading hint in getrawtransaction * test: Simplify create_cache * bench: Benchmark MempoolToJSON * rpc: Pass mempool into MempoolToJSON * rpc/gui: Remove 'Unknown block versions being mined' warning * Enable PID file creation on Windows - Add available WIN PID function - Consider WIN32 in each relevant case - Add new preprocessor definitions to suppress warning - Update error message for generic OS * Call InvalidateBlock without cs_main held * Make RewindBlockIndex interruptible * Call RewindBlockIndex without cs_main held * Release cs_main during RewindBlockIndex operation * Merge the disconnection and erasing loops in RewindBlockIndex * Move erasure of non-active blocks to a separate loop in RewindBlockIndex * Abstract EraseBlockData out of RewindBlockIndex * wallet: Use fsbridge::ifstream to fix Windows path issue * gui: Fix async open wallet call order * Style cleanup. * flatfile: Unit tests for FlatFileSeq methods. * scripted-diff: Rename CBlockDiskPos to FlatFilePos. * Move CDiskBlockPos from chain to flatfile. * validation: Refactor file flush logic into FlatFileSeq. * validation: Refactor block file pre-allocation into FlatFileSeq. * validation: Refactor OpenDiskFile into method on FlatFileSeq. * validation: Extract basic block file logic into FlatFileSeq class. * util: Move CheckDiskSpace to util. * Change brace formatting * Remove use of IsInitialBlockDownload in wallet code * Remove use of uiInterface.LoadWallet in wallet code * circular-dependencies: Avoid treating some .h/.cpp files as a unit * Remove use of AcceptToMemoryPool in wallet code * Remove uses of InitMessage/Warning/Error in wallet code * Remove uses of GetAdjustedTime in wallet code * Remove use of g_connman / PushInventory in wallet code * Remove uses of g_connman in wallet code * Remove uses of fPruneMode in wallet code * Remove uses of fee globals in wallet code * Remove use of CalculateMemPoolAncestors in wallet code * Remove use of GetTransactionAncestry in wallet code * Remove use of GetCountWithDescendants in wallet code * Remove use of IsRBFOptIn in wallet code * Remove uses of CheckFinalTx in wallet code * gui: Drop unused return values in WalletFrame * Remove travis_wait from lint script * refactor: Drop redundant wallet reference * rpc: Actually throw help when passed invalid number of params * rpc: Add RPCHelpMan::IsValidNumArgs() * depends: Add commands for each package for each stage * depends: Preprocessing doesn't care about deps * qa: Fix wallet_txn_doublespend issue * qa: Always refresh stale cache to be out of ibd * [doc] productivity: more advanced git range-diff * [doc] devtools: mention clang-format dependency * qa: Remove mocktime unless required * [doc] productivity: fix broken link * [test] functional: set cwd of nodes to tmpdir * tests: remove byte.hex() to keep compatibility * Fix lack of warning of unrecognized section names * Add missing #include. * Address test todos by removing -txindex to nodes. Originally added when updating getrawtransaction to stop searching unspent utxos. * Use a single wallet batch for UpgradeKeyMetadata * appveyor: Remove unused NDEBUG removal * scripted-diff: Remove NDEBUG pre-define * Update assumevalid, minimumchainwork, and getchaintxstats to height 563378. * [Doc] importmulti: add missing description of keypool option * [Doc] add missing newline to witnessScript in listunspent help * Implement analyzepsbt RPC and tests * Add checksums to descriptors.md * Make descriptor checksums mandatory in deriveaddresses and importmulti * Add getdescriptorinfo to compute checksum * Descriptor checksum * Move PSBT UTXO fetching to a separate method * Figure out what is missing during signing * Implement joinpsbts RPC and tests * Implement utxoupdatepsbt RPC and tests * doc: update FreeBSD build guide for 12.0 * tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree * tests: Add script checking for deterministic line coverage * Import public keys in order * Test pubkey import to keypool * Add option to importmulti add an imported pubkey to the keypool * Fetch keys from keypool when private keys are disabled * Add a method to add a pubkey to the keypool * Add release notes for importing key origin info change * Test importing descriptors with key origin information * Import KeyOriginData when importing descriptors * Implement a function to add KeyOriginInfo to a wallet * Store key origin info in key metadata * Move all PID file stuff to init.cpp * fuzz: test_runner: Better error message when built with afl * travis: Combine --disable-bip70 into existing job * test: txindex: interrupt threadGroup before calling destructor * Remove hdmasterkeyid * Add a method to CWallet to write just CKeyMetadata * Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} * Refactor keymetadata writing to a separate method * Remove unused TransactionError constants * [build] AppVeyor: clean cache when build configuration changes * [build] Makefile.am: add rule for src/bitcoin-wallet * Add compile time verification of assumptions we're currently making implicitly/tacitly * fixes m_assumed_blockchain_size variables values: * msvc: Fix silent merge conflict between #13926 and #14372 part II * Bump minimum Qt version to 5.5.1 * qa: Add test/fuzz/test_runner.py * fuzz: Script validation flags * fuzz: Move deserialize tests to test/fuzz/deserialize.cpp * Remove manual byte editing in wallet_tx_clone func test * Add release note for listunspent P2WSH change * Add test for P2SH-P2WSH in signrawtransactionwithkey and listunspent * Make listunspent and signrawtransaction RPCs support witnessScript * Log full paths for wallets * gui: Add close wallet action * gui: Add closeWallet to WalletController * interfaces: Add remove to Wallet * Replace script name with special parameter * Remove unnecessary const_cast * [wallet] Close bdb when flushing wallet. * [rpc] mining: Omit uninitialized currentblockweight, currentblocktx * tests: Added missing tests for RPC wallet errors * Factor out combine / finalize / extract PSBT helpers * Remove op== on PSBTs; check compatibility in Merge * Switch away from exceptions in refactored tx code * appveyor: Remove outdated libraries * tests: accept unicode characters on Windows * Move PSBT definitions and code to separate files * Factor BroadcastTransaction out of sendrawtransaction * Split DecodePSBT into Base64 and Raw versions * Add pf_invalid arg to std::string DecodeBase{32,64} * Travis: Add test without BIP70 (but still full wallet + tests) * GUI: If BIP70 is disabled, give a proper error when trying to open a payment request file * GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing * RPCHelpMan: Check default values are given at compile-time * trivial: correct parameter name in comments * [wallet] Support creating a blank wallet * gui: Uppercase bech32 addresses in qr codes * Move ParseConfirmTarget from rpc/mining to rpc/util * Move maxTxFee initialization to init.cpp * qa: Add tool-prefix to functional test readme * A few textual improvements * test_runner: Remove unused --force option * Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) * wallet: Add lock annotation for mapAddressBook * Change in transaction pull scheduling to prevent InvBlock-related attacks * util: Add SetupHelpOptions() * doc: Add missing wallet-tool manpages * contrib: Add missing wallet tool to gen-manpages.sh * Update linearize-hashes.py * qa: Drop RPC connection if --usecli * travis: Only exit early if compilation took longer than 30 min * doc: Add separate productivity notes document * Add release notes for importmulti descriptor support * Add test for importing via descriptor * [wallet] Allow descriptor imports with importmulti * [wallet] Refactor ProcessImport() to call ProcessImportLegacy() * [wallet] Add ProcessImportLegacy() * [wallet] Refactor ProcessImport() * rpc: Fix for segfault if combinepsbt called with empty inputs * Fix issue #9683 "gui, wallet: random abort (segmentation fault) running master/HEAD". * Fix build after pr 15266 merged * qa: Test .walletlock file is closed * netaddress: Make IPv4 loopback comment more descriptive * netaddress: Fix indentation in IsLocal * net: Correct comparison of addr count * [Docs] Small updates to getrawtransaction description * remove deprecated mentions of signrawtransaction from fundraw help * qt: Pre-0.18 split-off translations update * init: Modify docs and add release note for 12255 * msvc: add rapid check property tests * gui: Show indeterminate progress dialog while opening walllet * gui: Add OpenWalletActivity * wallet: Close wallet env lock file * wallet: Close dbenv error file db.log * interfaces: Avoid interface instance if wallet is null * gui: Add thread to run background activity in WalletController * gui: Add Open Wallet menu * gui: Add openWallet and getWalletsAvailableToOpen to WalletController * interfaces: Add loadWallet to Node * wallet: Factor out LoadWallet * Use RdSeed when available, and reduce RdRand load * Check m_internals in UnregisterValidationInterface * gui: Fix m_node.startShutdown() order * gui: Expose BitcoinGUI::unsubscribeFromCoreSignals * gui: Fix WalletController deletion * cirrus ci: Inital config * speed up Unserialize_impl for prevector * tests: Make updatecoins_simulation_test deterministic * test: Fix race in p2p_invalid_messages * travis: Revert "Run extended tests once daily" * test: Make bloom tests deterministic * Make PID file creating errors fatal * Improve PID file removing errors logging * msvc: Fix silent merge conflict between #13926 and #14372 * Rename Chain getLocator -> getTipLocator * Drop redundant get_value_or * Fix ScanForWalletTransactions start_block comment * wallet: Add missing cs_db lock * Document rescanblockchain returned stop_height being null * doc: Add cs_main lock annotations for mapBlockIndex * travis: Save cache when compilation took very long * Add suggested rescanblockchain comments * Update ScanForWalletTransactions result comment * Rename ScanResult stop_block field * Update release notes through to cb35f1d3 * Release notes: integrate detached & rm backports * travis: Document whether functional tests are run in the job name * Revert "travis: Compile trusty with depends for now" * Prefer boost::optional#get_value_or over #value_or * Piecewise construct to avoid invalid construction * Do not import private keys to wallets with private keys disabled * Refactor importwallet to extract data from the file and then import * Slight tweak to the verify-commits script directions * tests: unify RPC argument to cli argument conversion and handle dicts and lists * travis: Remove unused FUNCTIONAL_TESTS_CONFIG * msvc: build leveldb locally * msvc: build secp256k1 locally * Fix assertion in CKey::SignCompact * gdb attaching to process during tests has non-sudo solution * Explain that unused mempool memory is added to -dbcache * [tests] Add wallet-tool test * [tools] Add wallet inspection and modification tool * Remove 'boost::optional'-related gcc warnings * build: prefer python3.4 even if newer versions are present on the system * Correct units for "-dbcache" and "-prune" * test: Build fuzz targets into seperate executables * log: Construct global logger on first use * wallet: Fixup rescanblockchain result doc * [rpc] util: add deriveaddresses method * [doc] descriptor: explain GetPubKey() usage with cached public key * scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg * doc: correct logging rpc return type and example * Fix UB with bench on genesis block * travis: Compile trusty with depends for now * travis: Compile once on trusty * Add gitian PGP key for hebasto * rpc: Compile on GCC4.8 * qa: Use wallet to retrieve raw transactions * [RPC] Update getrawtransaction interface * Squashed 'src/leveldb/' changes from 524b7e36a8..f545dfabff * build: Remove WINVER pre define in Makefile.leveldb.inlcude * [test] fuzz: make test_one_input return void * Trivial: Doxygenize existing CBufferedFile and VectorReader comments * RPCHelpMan: Pass through Result and Examples * Descriptor expansions only need pubkey entries for PKH/WPKH * qa: Style-only fixes in touched files * Add warning messages to the debug window * Scripts and tools: Drop no-longer-relevant copyright holder names * Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions * Prevent mutex lock fail even if --enable-debug * Trivial: fixup a few doxygen comments * Docs: Update python docs to reflect that wildcard imports are disallowed * Drop defunct Windows compat fixes * qa: Add tests for invalid message headers * tests: unify RPC argument to cli argument conversion and handle dicts and lists * [doc] add notes on release notes * submitheader: more directly test missing prev block header * remove some magic mining constants in functional tests * Doc: add information about security to the JSON-RPC doc * Move non-linux source tarball to bitcoin-binaries * Notify the GUI that the keypool has changed to set the receive button * Added some factors that affect the dependency list * windows: Call SetProcessDEPPolicy directly * windows: Set _WIN32_WINNT to 0x0601 (Windows 7) * Allow connections from misbehavior banned peers. * Default -whitelistforcerelay to off * docs: add perf section to developer docs * tests: add utility to easily profile node performance with perf * Fix macOS launch-at-startup memory issue * Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11 * Check for more than private keys disabled to show receive button * [Docs] add short documentation for /rest/blockhashbyheight * [QA] add rest tests for /rest/blockhashbyheight/<HEIGHT>.<FORMAT> * REST: add "blockhashbyheight" call, fetch blockhash by height * Delete README_osx.md and move its contents into build-osx.md * lint: Enable python linters via an array * Remove errant past from walletcreatefundedpsbt for nLocktime replaceability * gui: Fix window title update * Add locking annotation for vNodes. vNodes is guarded by cs_vNodes. * zmq: log outbound message high water mark when reusing socket * Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible * Update zmq to 4.3.1 * rpc: remove duplicate solvable field from getaddressinfo * doc: Clarify -blocksdir usage * gui: Refactor to use WalletController * gui: Add WalletController * gui: Use AutoConnection for WalletModel::unload signal * Add comment describing fDisconnect behavior * docs: Spelling error fix on fuzzing.md * Document RNG design in random.h * Use secure allocator for RNG state * Encapsulate RNGState better * DRY: Implement GetRand using FastRandomContext::randrange * Sprinkle some sweet noexcepts over the RNG code * Remove hwrand_initialized. * Switch all RNG code to the built-in PRNG. * Integrate util/system's CInit into RNGState * Abstract out seeding/extracting entropy into RNGState::MixExtract * Add thread safety annotations to RNG state * Rename some hardware RNG related functions * Automatically initialize RNG on first use. * Don't log RandAddSeedPerfmon details * build: Drop macports support * scripted-diff: batch-recase BanMan variables * banman: Add, use CBanEntry ctor that takes ban reason * banman: reformulate nBanUtil calculation * banman: add thread annotations and mark members const where possible * scripted-diff: batch-rename BanMan members * net: move BanMan to its own files * banman: pass in default ban time as a parameter * banman: pass the banfile path in * banman: create and split out banman * net: split up addresses/ban dumps in preparation for moving them * tests: remove member connman/peerLogic in TestingSetup * net: Break disconnecting out of Ban() * Remove no longer needed shellcheck suppressions * Fix warnings introduced in shellcheck v0.6.0 * Remove repeated suppression. Fix indentation. * Pin shellcheck version to v0.6.0 * qa: Improve tests of /rest/headers and /rest/block * doc: /rest/block responds with 404 if block does not exist * qa: Remove race between connecting and shutdown on separate connections * Improve "help-console" message * doc: Explain empty result of /rest/headers * [docs] Expand help text for importmulti changes * Fix remaining compiler warnings (MSVC). Move disabling of specific warnings from /nowarn to project file. * [doc] explain what .python-version does * Remove remaining chainActive references from CWallet * Convert CWallet::ScanForWalletTransactions and SyncTransaction to the new Chain apis * Add findFork and findBlock to the Chain interface * Add time methods to the Chain interface * Add height, depth, and hash methods to the Chain interface * gui: Show current wallet name in window title * gui: Keep network style in BitcoinGUI * gui: Remove unused return type in some BitcoinGUI methods * refactor/lint: Add ignored suggestions to an array * doc: Add release notes for unloadwallet change to synchronous call * rpc: Make unloadwallet wait for complete wallet unload * Add workaround for QProgressDialog bug on macOS * Fix wallet selector size adjustment * contrib: Allow use of github API authentication in github-merge * contrib: Add support for http[s] URLs in github-merge * contrib: Detailed reporting for http errors in github-merge * qa: Ignore shellcheck warning SC2236 * Drop IsLimited in favor of IsReachable * Use FRC::randbytes instead of reading >32 bytes from RNG * Replace remaining 0 with nullptr in Qt code * Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) * configure: bitcoin-tx doesn't need libevent, so don't pull it in * Use C++11 default member initializers * util: Make ToLower and ToUpper take a char * util: remove unused [U](BEGIN|END) macros * Replace use of BEGIN and END macros on uint256 * Remove redundant stopExecutor() signal * Remove redundant stopThread() signal * Add checksum in gitian build scripts for ossl * Do not deselect peer when switching away from tab * Improve Peers tab layout * docs: Clarifying testing instructions * Fail if either disk space check fails * Error if rpcpassword contains hash in conf sections * docs: Add FreeBSD build notes link to doc/README.md * Fix download link * Fix out-of-bounds write in case of failing mmap(...) in PosixLockedPageAllocator::AllocateLocked * Show addresses for "SendToSelf" transactions * build: Allow to configure --with-sanitizers=fuzzer * Use C++11 default member initializers * test: Run invalid_txs.InputMissing test in feature_block * Fix the build problem in libbitcoin_server * init: Use systemd automatic directory creation * [tests] move wallet util functions to wallet_util.py * [tests] tidy up wallet_importmulti.py * Qt: Fix update headers-count * Qt: update header count regardless of update delay * Fix minimized window bug on Linux * qt: Use WalletModel* instead of wallet name in console window * qt: Use WalletModel* instead of wallet name in main window * qt: Factor out WalletModel::getDisplayName() * rpc: Avoid permanent cs_main lock in getblockheader * Add BitcoinApplication & RPCConsole tests * Move BitcoinApplication to header so it can be tested * Use std::vector API for construction of test data. * test: Correct ineffectual WithOrVersion from transactions_tests * Add names to Travis jobs * rpc: Document bytessent_per_msg and bytesrecv_per_msg * gui: Fix for Incorrect application name when passing -regtest * Release notes: integrate detached release notes * Release notes: update notes through fb52d0684 * Don't label transactions "Open" while catching up * doc: Add getrpcinfo release notes * qa: Add tests for getrpcinfo * rpc: Add getrpcinfo command * rpc: Track active commands * test: Fix rpc_net.py "pong" race condition * [rpc] Correct reconsiderblock help text, add test * Botbot.me (IRC logs) not available anymore * [Trivial] Update license year range to 2019 * test: Add basic test for BIP34 * Bump manpages * Update copyright headers to 2018 * IsReachable is the inverse of IsLimited (DRY). Includes unit tests * Increase timeout of featuer_assumevalid test to fix flaky tests * If tests are ran with (ASan + LSan), Docker needs access to ptrace * Update Travis base OS to Xenial * wallet: Avoid leaking locktime fingerprint when anti-fee-sniping * Get more info about GUI-related issue on Linux * [test] wallet_txn_clone: Correctly clone txin sequence * doc: Add historical release notes for 0.17.1 * whitespace: Split ~300 char line into multiple ones * scripted-diff: Rename rpc_timewait to rpc_timeout * scripted-diff: Remove unused 'split' parameter to setup_network * validation: Add cs_main locking annotations * blockfilter: Remove default clause in switch statement. * GUI: Restore RPC Console to non-wallet tray icon menu * test: Avoid racy test p2p_timeouts * Fix minor grammar error in doc * Remove misplaced Q_UNUSED and others enhancements * doc: Add comment to cs_main and mempool::cs * test: Bump timeout to run tests in travis thread sanitizer * Fix broken notificator on GNOME * rpc: Fix data race (UB) in InterruptRPC() * Add suppression for InterruptRPC (fRPCRunning) data race * Modify build instructions to work with Command Prompt as well as PowerShell; other minor changes * Made expicit constructor CTransaction(const CMutableTransaction &tx). * Minimal changes to comply with explicit CMutableTransaction -> CTranaction conversion. * wallet: Initialize stop_block to nullptr in CWallet::ScanForWalletTransactions * test: Add missing validation locks * test: Add comment to g_insecure_rand_ctx * clarifying getrawtransaction[time] get help text * test: Undo thread_local g_insecure_rand_ctx * Making supported operating systems more clear * travis: Use trap and set -e errtrace * build: Enable functional tests in the ThreadSanitizer (TSan) build job * [Qt] Restore < Qt5.6 compatibility for addAction * Refactoring with QString::toNSString * [net] add dnsseed.emzy.de to DNS seeds * Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. * fix testmempoolaccept CLI syntax * test: Fix race in mempool_accept * sync: Add RecursiveMutex type alias * rpc: Remove unused PreCommand signal * lint/format-strings: Correctly exclude escaped percent symbols * Select orphan transaction uniformly for eviction * test: add_nodes can only be called once after set_test_params * test: Make g_insecure_rand_ctx thread_local * Revert "tests: Support calling add_nodes more than once" * Remove Python 2 import workarounds * docs: add NSIS setup/install steps to windows docs * Revert "travis: Save cache on build error" * tests: Test for expected return values when calling functions returning a success code * doc: update NetBSD build instructions for 8.0 * Add release notes * Overhaul importmulti logic * Do not permit copying FastRandomContexts * Simplify testing RNG code * Make unit tests use the insecure_rand_ctx exclusively * Bugfix: randbytes should seed when needed (non reachable issue) * Use a FastRandomContext in LimitOrphanTxSize * Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection * Use a local FastRandomContext in a few more places in net * Make addrman use its local RNG exclusively * test: Add tests for truncated scripts * depends: disable unused qt features * depends: qt 5.9.7 * depends: expat 2.2.6 * [test] functional framework: add CScript hex() for Python 3.4 * [test] Travis: enforce Python 3.4 support in functional tests * Removed implicit CTransaction conversion from benchmaks * Removed implicit CTransaction constructor from tests * test: mempool_persist: Verify prioritization is dumped correctly * test: pruning: Check that verifychain can be called when pruned * Add nice table to files.md * test: consensus: Check that final transactions are valid * test: Correctly deserialize without witness * qt: Remove ellipsis from sending/receiving addresses * qt: Add Window menu * qt: Allow to inspect RPCConsole tabs * [docs] add release note for change to GBT * [mining] segwit option must be set in GBT * [tests] Add docstring for wallet_importmulti.py * [tests] add test_address method to wallet_import.py * [tests] add test_importmulti method to wallet_import.py * [tests] add get_multisig function to wallet_importmulti.py * [tests] add get_key function to wallet_importmulti.py * Add E711 to flake8 check * Compare to None with is/is not * RPCHelpMan: Support required arguments after optional ones * doc: Update minimum required qt * Change '== None' to 'is None' * Handle exception as ImportError * threads: fix unitialized members in sched_param * rpc: Document default values for optional arguments * rpc: Assert named arguments are unique in RPCHelpMan * rpc: Avoid creating non-standard raw transactions * [tests] tidy up imports in wallet_importmulti.py * [tests] fix flake8 warnings in wallet_importmulti.py * Fix start with the `-min` option * Improve documentation for running verify-commits.py script * Include util/strencodings.h which is required for IsSpace(...) * [doc] developer-notes.md: point out that UniValue deviates from upstream * add `--retry 5` to curl opts in install_db4.sh * doc: Fix PSBT howto and example parameters * RPCHelpMan: Add space after colons in extended description * Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1 * rpc: Add description to fundrawtransaction vout_index * scripted-diff: Run scripted-diff in subshell * validation: Add and use HaveTxsDownloaded where appropriate * scripts: Add trusted key for Samuel Dobson * Increase maxconnections limit when using poll. * Implement poll() on systems which support it properly. * tests: Modify rpc_bind to conform to #14532 behaviour. * wallet_keypool_topup.py: Test for all keypool address types * Add locking annotations to feeStats, shortStats and longStats * scripted-diff: Rename from cs_feeEstimator to m_cs_fee_estimator * policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator * Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. * Cleanup SplashScreen class * Test coinbase category in wallet rpcs * Add all category options to wallet rpc help * Move SocketEvents logic to private method. * Move GenerateSelectSet logic to private method. * Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. * [tests] Add wallet_balance.py * Improve blocksdir functional test. * Fix broken Gmane URLs * Use const in COutPoint class * Move CheckBlock() call to critical section * tests: have combine_logs default to most recent test dir * make peertimeout a debug argument, remove error message translation * docs: Add more Doxygen information to Developer Notes * Add CScriptNum decode python implementation in functional suite * Remove duplicate libconsensus linking in test make * qt: Remove hidden columns in coin control dialog * validation: assert that pindexPrev is non-null when required * p2p: allow p2ptimeout to be configurable, speed up slow test * Add comments to descriptor tests * Add descriptor expansion cache * [refactor] Combine the ToString and ToPrivateString implementations * [refactor] Use DescriptorImpl internally, permitting access to new methods * [refactor] Add a base DescriptorImpl with most common logic * Add missing lock in CNode::copyStats(...) * Add missing locking annotations * test: add invalid tx templates for use in functional tests * bench: Destroy wallet txs instead of leaking their memory * Replace CAffectedKeysVisitor with descriptor based logic * Fix descriptor_tests not checking ToString output of public descriptors * rpc: Pass argument descriptions to RPCHelpMan * Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize * Bugfix: test/functional/rpc_psbt: Correct test description comment * Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions * Add LSan suppression warnings * Add ASan Travis build * Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase * qa: Add wallet_encryption error tests * qa: clean up assert_memory_usage_stable utility * qa: fix p2p_invalid_messages on macOS * Trivial: add doxygen-compatible comments relating to BerkeleyEnvironment * Tests: add unit tests for GetWalletEnv * Free BerkeleyEnvironment instances when not in use * clarify RPC rawtransaction documentation * Less confusing documentation for `torpassword` * Use window() instead of obsolete topLevelWidget() * Make SafeDbt DB_DBT_MALLOC on default initialization * Add Benchmark to test input de-duplication worst case * squashme: connect thru node interface * Indicate -rpcauth option password hashing alg * http -> https * tests: check readability of cookie file * test: allows test_runner command line to receive parameters for each test * qa: Test bitcond shutdown * http: Remove timeout to exit event loop * http: Remove unnecessary event_base_loopexit call * http: Unlisten sockets after all workers quit * http: Send "Connection: close" header if shutdown is requested * rpc: Add wait argument to stop * Fix detection of copyright holders * Remove UBSan suppression * streams: Remove unused seek(size_t) * Correct misleading "overridden options" label * Allow running rpc_bind.py --nonloopback test without IPv6 * qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning * test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan * travis: --disable-hardening for xenial thread sanitizer * travis: Run thread sanitizer * A few minor formatting fixes and clarifications to descriptors.md * rpcbind: Warn about exposing RPC to untrusted networks * CNetAddr: Add IsBindAny method to check for INADDR_ANY * net: Always default rpcbind to localhost, never "all interfaces" * rpcauth: Improve by using argparse and getpass modules * Add regtest for JSON-RPC batch calls. * tests: Support calling add_nodes more than once * Convert comments to thread safety annotations * test: Add BOOST_REQUIRE to getters returning optional * Do not specify sudo in .travis * Warn unrecognized sections in the config file * revert removal of fstream.hpp header in fs.h * Log env path in BerkeleyEnvironment::Flush * Properly generate salt in rpcauth.py, update tests * Fix running individually through test_runner.py, as suggested by @MarcoFalke (#14732) * Remove unreferenced boost headers * fix an undefined behavior in uint::SetHex * Improve scripted-diff developer docs * fix uninitialized read when stringifying an addrLocal * add test demonstrating addrLocal UB * rpc: Documentation fixups * Add release notes * Add matching descriptors to scantxoutset output + tests * Add descriptors to listunspent and getaddressinfo + tests * Use RPCHelpMan for all RPCs * Implement prevector::fill once * Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h * lint: Must use RPCHelpMan to generate the RPC docs * Bump the minimum Qt version to 5.2 * Rename ListTransactions filter variable * [wallet] Restore ability to list incoming transactions by label * disallow oversized CBlockHeaderAndShortTxIDs * fix a deserialization overflow edge case * add a test demonstrating an overflow in a deserialization edge case * rpc: Correctly name arguments * Add stop_block out arg to ScanForWalletTransactions * qa: Check specific reject reasons in feature_block * GetPubKey: make sigdata const * util.h: explicitly include required QString header * Return a status enum from ScanForWalletTransactions * Make CWallet::ScanForWalletTransactions args and return value const * Introduce SafeDbt to handle DB_DBT_MALLOC raii-style * remove redundant KeyOriginInfo access, already done in CreateSig * CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change * Remove stale comment in CalculateMaximumSignedInputSize * rpc: Add RPCHelpMan for machine-generated help * Release notes: integrate detached release notes * Release notes: update notes through to 11e1ac3ae08 * Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI * qa: Raise ci test_runner timeout to 40 mins * travis: Avoid timeout on verify-commits check * doc: add detached release notes for #14060 * build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString * Better error message for user when corrupt wallet unlock fails * qa: Avoid race in p2p_invalid_block by waiting for the block request * tests: Make feature_block pass on centos * rpc: Include rpc/util.h where needed for RPCHelpMan * build: Add bitcoin-tx.exe into Windows installer * test_node: get_mem_rss fixups * Throw error if CPubKey is invalid during PSBT keypath serialization * Require a public key to be retrieved when signing a P2PKH input * wallet: Create IsDatabaseLoaded function * build: Fix windows build error if `--disable-bip70` * importmulti: Don't add internal addresses to address book * [doc] conf: Remove deprecated options from docs, Other cleanup * tests: Add Python dead code linter (vulture) * tests: Remove unused testing code * blockfilter: Additional constructors for BlockFilter. * blockfilter: Refactor GCS params into struct. * Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers. * Update KNOWN_VIOLATIONS: Remove fixed violations * Use IsSpace(...) instead of boost::is_space * Use ToLower(...) instead of std::tolower * Use IsDigit(...) instead of std::isdigit * Send fewer spam messages in p2p_invalid_messages * Pass chain locked variables where needed * Remove uses of cs_main in wallet code * Remove direct node->wallet calls in init.cpp * Pass chain and client variables where needed * Add skeleton chain and client classes * Add UBSan suppressions needed to pass test suite * Add UBSan options: print_stacktrace + halt_on_error * doc: Add historical release notes for 0.17.0.1 * Add metavar to match var name in help text + Change wording for better readability * appveyor: Script improvement part II * wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory. * Refactor: Move m_db pointers into BerkeleyDatabase * Add test for rpcpassword hash error * Error if rpcpassword in conf contains a hash character * Enable functional tests in UBSAN job. Enable -fsanitize=integer (part of UBSAN). Merge UBSAN Travis job with no depends. * example_test.py: fixup coinbase height argument, derive number clearly * blockfilter: Use unordered_set instead of set in blockfilter. * Extract CSipHasher to it's own file in crypto/ directory. * qa: Add test to ensure node can generate all help texts at runtime * Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes. * tests: Explicitly ignore the return value of DecodeBase58(...) * tests: Check return value of ParseParameters(...) * miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee * trivial: Don't translate in help text * Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) * rpc: Make HTTP RPC debug logging more informative * scripted-diff: Rename misleading 'defaultPort' to 'http_port' * Fix `bitcoin-qt -version` output formatting * Make blockdir always net specific * qt: All tray menu actions call showNormalIfMinimized * qt: Use GUIUtil::bringToFront where possible * qt: Add GUIUtil::bringToFront * scripted-diff: Move util files to separate directory. * warnings: Compiler warning on memset usage for non-trivial type * Remove obj_c for macOS Dock icon menu * Use Qt signal for macOS Dock icon click event * build: Remove illegal spacing in darwin.mk * test_runner: Remove travis specific code * Add regression test for PSBT signing bug #14473 * Refactor PSBTInput signing to enforce invariant * Simplify arguments to SignPSBTInput * Add bool PSBTInputSigned * New PartiallySignedTransaction constructor from CTransction * Remove redundant txConst parameter to FillPSBT * More concise conversion of CDataStream to string * tests: add tests for invalid P2P messages * tests: add P2PConnection.send_raw_message * tests: add utility to assert node memory usage hasn't increased * Avoid using numeric_limits for sequence numbers and lock times * Remove duplicated code * Replace platform dependent type with proper const * [tests] Move deterministic address import to setup_nodes * Tests: Fix a comment * Update release-process.md to include RC version bumping * macOS: disable AppNap during sync * Make clear function argument case in dev notes * Remove obj_c for macOS Dock icon setting * FreeBSD: Document Python 3 requirement for 'gmake check' * doc: Add external interface consistency guarantees * build: include rc number in version number * build: if VERSION_BUILD is non-zero, include it in the package version * align items in contrib init * qt: Remove "Pay only required fee" checkbox * tests: Print dots by default * qt: Improve BitcoinAmountField class * added details about commit messages * Bugfix: RPC: Add address_type named param for createmultisig * gui: explicitly disable "Dark Mode" appearance on macOS * Remove unused `adjustedTime` parameter * Various textual improvements in build docs * travis: Save cache on build error * Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...) * Add tests for InferDescriptor and Descriptor::IsSolvable * Add Descriptor::IsSolvable() to distinguish addr/raw from others * Add support for inferring descriptors from scripts * [tests] Test that nodes respond to getdata with notfound * Remove fs::relative call and fix listwalletdir tests * build: Fix Qt link order for Windows build * wallet: Refactor to use WalletLocation * wallet: Add WalletLocation utility class * Add segwit address tests for importmulti * Make getaddressinfo return solvability * Add release notes for importmulti segwit change * Fix typo in test_framework/blocktools * Add SegWit support to importmulti with some ProcessImport cleanup * appveyor: Enable multiwallet test * tests: add test case for loading copied wallet twice * wallet: Fix duplicate fileid * [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text. * minor p2p_sendheaders fix of height in coinbase * Removed explicit mention of storage requirement (squashed) * Don't link SSL_LIBS with GUI unless BIP70 is enabled * Add BIP70 deprecation warning * qt: cleanup: Move BIP70 functions together in paymentserver * show the progress of functional test * Update documentation to incude origin information * Add tests for key origin support * Add key origin support to descriptors * [macOS] Remove DS_Store WindowBounds bytes object * travis: Compile once on xenial * rpc: Prevent concurrent savemempool * qa: Ensure wallet unload during walletpassphrase timeout * Revert "Make qt wallet test compatible with qt4" * docs: Document lint tests * Fix typo * scripted-diff: Replace boost::bind with std::bind * refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform * rpc: Always throw in getblockstats if -txindex is required * ZMQ: add options to configure outbound message high water mark, aka SNDHWM * doc: Update OpenBSD build guide for 6.4 * gitignore contents of db4 folder * rpc: Fix wallet unload during walletpassphrase timeout * docs: Add release notes for listwalletdir RPC * qa: Add tests for listwalletdir RPC * rpc: Add listwalletdir RPC * interfaces: Add getWalletDir and listWalletDir to Node * wallet: Add ListWalletDir utility * Add `doc/bitcoin-conf.md` * [wallet] Deprecate the generate RPC method * [tests] Add generate method to TestNode * Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG * utils: Fix broken Windows filelock * Textual improvements * Avoid triggering undefined behaviour in base_uint<BITS>::bits() * [docs] Add release note for removing getwitnessaddress * descriptors.md: Refer to descriptors as describing instead of matching * doc: add comment explaining recentRejects-DoS behavior * [tests] Small fixups before deprecating generate * build: Pin to specific versions of Python packages we install from PyPI in Travis * Add ignored word: mut * Revert "qa: Fix codespell error and have lint-spelling error instead of warn" * refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread * Fix listreceivedbyaddress not taking address as a string * tests: add test for 'getaddressinfo' RPC result 'ischange' field * rpcwallet: add 'ischange' field to 'getaddressinfo' response * Fix QCompleter popup regression * bitcoin-tx: Use constant for n pubkeys check * [doc] getblocktemplate: use SegWit in example * tests: Stop node before removing the notification file * Improve CAmount tests * Add compile time checking for cs_main locks which we assert at run time * test: forward timeouts properly in send_blocks_and_test * Fix CLEAN_BITCOIN_TEST to remove .log files for all BITCOIN_TESTS files * clarify rpcwallet flag url change * [rpc] Descriptions: Textual consistency fixes * Add GUARDED_BY(cs_wallet) for setExternalKeyPool, mapKeyMetadata, m_script_metadata and setLockedCoins * Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext * wallet: Add Clang thread safety analysis annotations * wallet: Add missing locks * qt: Revert "Force TLS1.0+ for SSL connections" * build: Add --disable-bip70 configure option * Add missing locks and locking annotations for CAddrMan * Add tooltips for both datadir and blocksdir * Stop requiring imported pubkey to sign non-PKH schemes * tests: Allow closed http server in assert_start_raises_init_error * Fix macOS files description * implements different disk sizes for different networks on intro * [docs] path to descriptors.md fixed * [tests] Remove rpc_zmq.py * Clean systray icon menu for -disablewallet mode * Add "Blocksdir" to Debug window * rpc: creates possibility to preserve labels on importprivkey * Don't access out of bounds array entry array[sizeof(array)] * appveyor: trivial build cache modifications * Fix typos * doc: miss install * doc: RPC documentation * travis: set codespell version to avoid breakage * depends: qt: avoid system harfbuzz and bz2 * doc: Remove "temporary file" notice from 0.17.0 release notes * tests: Make appveyor run with --usecli * doc: Add historical release notes for 0.17.0 * test: Add missing call to skip_if_no_cli() * check that a separator is found for psbt inputs, outputs, and global map * Include some files currently missed by 'make distclean'. * utils: Convert Windows args to utf-8 string * fix converttopsbt permitsigdata arg, add basic test * doc: Add historical release notes for 0.14.3 and 0.15.2 * depends: fix bitcoin-qt back-compat with older freetype versions at runtime * Don't use systray icon on inappropriate systems * Document fixed attribute behavior in critical test framework classes. * Check for specific tx acceptance failures based on script signature * Strictly enforce instance attrs in critical functional test classes. * [docs] Add release notes for removing `-usehd` * doxygen: Fix member comments * Set C locale for amountWidget * [gitian] use versioned unsigned tarballs instead of generically named ones * Make MSVC compiler read the source code using utf-8 * tests: Add test case for std::ios_base::ate * Move boost/std fstream to fsbridge * utils: Add fsbridge fstream function wrapper * qa: Run more tests with wallet disabled * tests: exclude all tests with difference parameters * Consolidate redundant implementations of ParseHashStr * [wallet] remove redundand restart node * AppVeyor: Move AppVeyor YAML to dot-file-style YAML * test: allow arguments to be forwarded to flake8 in lint-python.sh * Move SocketHandler logic to private method. * Move InactivityCheck logic to private method. * tests: write the notification to different files to avoid race condition * Move DisconnectNodes logic to private method. * Move NotifyNumConnectionsChanged logic to private method. * [wallet] Ensure wallet is unlocked before signing * validation: Pass chainparams in AcceptToMemoryPoolWorker(...) * Fix for incorrect version attr set on functional test segwit block. * Don't edit Chainparams after initialization * MOVEONLY: Move versionbits info out of versionbits.o * test: Fix broken segwit test * [REST] improve performance for JSON calls * [wallet] Remove deprecated addwitnessaddress RPC method * [test] Remove deprecated addwitnessaddress from feature_segwit.py * [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py * [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py * [tests] Remove deprecated addwitnessaddress call from wallet_dump.py * [tests] Remove deprecated addwitnessaddress call from feature_nulldummy * [test] Fix flake8 warnings in tests * doc: Add GitHub pr template * [RPC] Remove warning for removed estimatefee RPC * Make fs::path::string() always return utf-8 string * Add test for conversion from non-witness to witness UTXO * Convert non-witness UTXOs to witness if witness sig created * [wallet] Remove -usehd * lcov: filter /usr/lib/ from coverage reports * Add autogen.sh in ARM Cross-compilation * init: Remove deprecated args from hidden args * tests: Use MakeUnique to construct objects owned by unique_ptrs * doc: Split build linux dependencies * wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) * Drop unused setRange arg to BerkeleyBatch::ReadAtCursor * Lift prevector default vals to the member declaration * doc: Split depends installation instructions per arch * doc: Add historical release notes for 0.16.3 * uint256: Remove unnecessary crypto/common.h use * gui: Show watch-only eye instead of HD disabled * [rpc] Add getnodeaddresses RPC command * [qa] Test for duplicate inputs within a transaction * Fix crash bug with duplicate inputs within a transaction * amount: Move CAmount CENT to unit test header * appveyor: Run functional tests on appveyor * Changed functional tests which do not require wallets to run without * tests: Make it possible to run functional tests on Windows * travis: Run feature_dbcrash functional tests in cron job * tests: Reorder tests and move most of extended tests up to normal tests * use integer division instead of double conversion and multiplication for computing amounts * doc: Document -checklevel levels * [qa] Use correct python index slices in example test * build: Remove libssl from LDADD unless gui * convert C-style (void) parameter lists to C++ style () * Fix reference to lint-locale-dependence.sh * [build] remove #ifdef ENABLE_WALLET from interfaces/node * qa: Remove unneded import_deterministic_coinbase_privkeys overwrite, add comments * qa: Fix codespell error and have lint-spelling error instead of warn * Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled * configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx * Pass export privkey DER compression flag correctly * doc: `-help-debug` implies `-help` * wallet: Remove trailing separators from -walletdir arg * wallet: Add walletdir arg unit tests * logging: Replace LogPrint macros with regular functions * build: Move interfaces/* to libbitcoin_server * [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions * Pass tx pool reference into CheckSequenceLocks * Remove redundant BIP174 test from rpc_psbt.json * Call unicode API on Windows * Drop minor GetSerializeSize template * Drop unused GetType() from CSizeComputer * qa: Run all tests even if wallet is not compiled * qa: Premine to deterministic address with -disablewallet * utils: Convert fs error messages from multibyte to utf-8 * [build] remove ENABLE_WALLET ifdef from httprpc.cpp * qa: Fix silent merge conflict in wallet_importmulti * don't translate command line options * travis: avoid timeout without saving caches, also enable all qt * depends: Remove unused Qt 4 dependencies * doc: release notes for -enablebip61 default change * rpc: Remove cs_main lock from blockToJSON and blockHeaderToJSON * rpc: Specify chain tip instead of chain in GetDifficulty * rpc: Fix SoftForkMajorityDesc and SoftForkDesc signatures * Scripts and tools: increased timeout downloading * [build] Move dummy wallet into its own .cpp file. * tx pool: Use class methods to hide raw map iterator impl details * Squashed 'src/univalue/' changes from 51d3ab34ba..7890db99d6 * p2p: Disable BIP 61 by default * qt: Also log and print messages or questions like bitcoind * noui: Move handlers to header file * doc/descriptors.md tweaks * test: Add test for config file parsing errors * Remove reference to deprecated RPC call in build instructions * Docs: Add disable-wallet section to OSX build instructions * Replace duplcate reference with reference to reference doc * Adjust TODO link * Add descriptor reference documentation * doc: Change documentation for =0 for non-boolean options * doxygen: Remove misleading checkpoints comment in CMainParams * lint: Add spell check linter (codespell) * Fix typos reported by codespell * Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader * Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented). * appveyor: Use clcache to speed up build * wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG. * doc: correct GetDifficulty doc after #13288 * gui: Favor macOS show / hide action in dock menu * lint: Make sure we read the command line inputs using utf-8 decoding in python * Trivial: update clang thread-safety docs url * build: avoid getifaddrs when unavailable * Test rpc_help.py failed: Check whether ZMQ is enabled or not. * Switch nPrevNodeCount to vNodesSize. * qa: Read reject reasons from debug log, not p2p messages * scripted-diff: Small locking rename * added note that control port must be enabled and how to do that in torrc config file * utils: Use _wfopen and _wreopen on Windows * Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins * macOS fix: Check for correct version of flake8 to avoid spurious warnings. The brew installed flake8 version is Python 2 based and does not work. * macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew * macOS fix: Work around empty (sub)expression error when using BSD grep * macOS fix: Avoid mapfile due to ancient version of bash shipped with macOS * tests: Dry run bench_bitcoin (-evals=1 -scaling=0: <1 second running time) as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code * Remove RUN_BENCH logic * Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists. * tests: Add missing locking annotations and locks * [wallet] Kill accounts * util: Report parse errors in configuration file * Fix potential deadlock * Add lock annotations (cs_args) * Add missing locks (cs_args) * qa: Use named args in some tests * scripted-diff: Use named arguments in feature_block * scripted-diff: Pass node into p2p_segwit acceptance tests * Remove unused fsbridge::freopen * Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP) * validation: Log FormatStateMessage on ConnectBlock error in ConnectTip * blockfilter: Omit empty scripts from filter contents. * Removes the Boost case_conv.hpp dependency. * Implements custom tolower and toupper functions. * Implements ParseNetwork unit test. * tests: Fix accidental trunction from int to bool * Add regression test: Don't assert(...) with side effects * Don't assert(...) with side effects * index: Fix for indexers skipping genesis block. * Add README.md to linux release tarballs * Hide spendable label if priveate key is disabled * [rpc] Remove deprecated sigrawtransaction rpc method. * [RPC] Remove warning about wallet addresses in createmultisig() * [rpc] Remove deprecated validateaddress usage. * test padding non micro timestamps * travis: add CXXFLAGS=-Wnopsabi at ARM job * add unicode compatible file_lock for Windows * Explicitly initialize prevector _union * Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. * [doc] Add release notes for 'account' API removal * [wallet] Re-sort wallet RPC commands * [wallet] Remove wallet account RPCs * fix missing differentiation between UNIT and FUNCTIONAL tests in travis build * Integration of property based testing into Bitcoin Core * [tests] Remove wallet accounts test * contrib: Adjust output to current test format * Report minfeefilter value in getpeerinfo rpc * use export LC_ALL=C.UTF-8 * make script exit if a command fails * move remaining travis build steps into individual files * number .travis/ script according to build lifecycle and add README to explain * move lint stage up to resemble travis build ui * abort script in END_FOLD on non-zero exit code * move script sections info individual files and comply with shellcheck * utils: run commands using utf-8 string on Windows * auto generate MSVC project files * travis: Run unit tests --with-sanitizers=undefined * qa: Stop txindex thread before calling destructor * Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe * Move cs_main locking annotations from .cpp to .h * Add compile time checking for all cs_main runtime locking assertions * bench: Benchmark GCS filter creation and matching. * blockfilter: Optimization on compilers with int128 support. * blockfilter: Unit test against BIP 158 test vectors. * blockfilter: Additional helper methods to compute hash and header. * blockfilter: Serialization methods on BlockFilter. * blockfilter: Construction of basic block filters. * blockfilter: Simple test for GCSFilter construction and Match. * blockfilter: Implement GCSFilter Match methods. * blockfilter: Implement GCSFilter constructors. * blockfilter: Declare GCSFilter class for BIP 158 impl. * streams: Unit tests for BitStreamReader and BitStreamWriter. * streams: Implement BitStreamReader/Writer classes. * streams: Unit test for VectorReader class. * streams: Create VectorReader stream interface for vectors. * [contrib] Support ARM and RISC-V symbol check * Docs: Fix help message typo optiona -> optional * fix walletcreatefundedpsbt deriv paths, add test * qa: Add some actual witness in rpc_rawtransaction * qa: Add TestNode::assert_debug_log * [Tests] Make combine_logs.py handle multi-line logs * util: Replace boost::signals2 with std::function * depends: Enable unicode support on dbd for Windows * Disallow extended encoding for non-witness transactions * depends: allow CC/CXX to be overridden during configure * Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5 * qa: Remove unused deserialization code in msg_version * Skip stale tip checking if outbound connections are off or if reindexing. * Remove default argument to prevector constructor to remove ambiguity * Add new regtest ports in doc following #10825 ports reattributions * rpc: Avoid locking cs_main in some wallet RPC * test: Add tests for RPC help * p2p: Remove dead code for nVersion=10300 * Bugfix: NSIS: Exclude Makefile* from docs * test: Add lint to prevent SIGNAL/SLOT connect style * qt: Use new Qt5 connect syntax * test: Check RPC settxfee errors * Disable wallet and address book Qt tests on macOS minimal platform * RPCTypeCheck bip32derivs arg in walletcreatefunded * QA: add basic walletcreatefunded optional arg test * walletcreatefundedpsbt: remove duplicate replaceable arg * Preserve a format of RPC command definitions * http: Add const modifier to HTTPRequest methods * depends: fix qt determinism * appveyor: fetch the latest port data * Add checks for settxfee reasonableness * Fix typo in feature_blocksdir.py log message * rpc: Return more specific reject reason for submitblock * refactor: use fs:: over boost::filesystem:: * [trivial] Fix typo in CDiskBlockPos struct's ToString * Use wildcard path in test_bitcoin.vcxproj * Add PSBT documentation * Allow ConstructTransaction to not throw error with 0-input txn * don't report minversion wallet entry as unknown * Import CInv from correct module * ci: Add appveyor.yml to build on MSVC * Make macro compatible with MSVC * tests: Replace usage of tostring() with tobytes() * Remove unused dummy_tx variable from FillPSBT * Serialize non-witness utxo as a non-witness tx but always deserialize as witness * Fix PSBT deserialization of 0-input transactions * qa: Add tests for submitheader * rpc: Expose ProcessNewBlockHeaders * Make SignPSBTInput operate on a private SignatureData object * Pass HD path data through SignatureData * Implement key origin lookup in CWallet * [MOVEONLY] Move ParseHDKeypath to utilstrencodings * Generalize PublicOnlySigningProvider into HidingSigningProvider * Make SigningProvider expose key origin information * Introduce KeyOriginInfo for fingerprint + path * More tests of signer checks * Test that a non-witness script as witness utxo is not signed * Additional sanity checks in SignPSBTInput * Only wipe wrong UTXO type data if overwritten by wallet * gitian: bump descriptors for (0.)18 * build: bump version to 0.17.99 * fix deprecation in bitcoin-util-test.py * Removes unsed `CBloomFilter` constructor. * p2p: Clarify control flow in ProcessMessage() * Cleanup StartRest() * Speed up knapsack_solver_test by not recreating wallet 100 times. * Visual Studio build configuration for Bitcoin Core * No longer shutdown after encrypting the wallet * After encrypting the wallet, reload the database environment * Add function to close all Db's and reload the databae environment * Move BerkeleyEnvironment deletion from internal method to callsite * Fix incorrect Doxygen comments * Add risc-v 64-bit to gitian * [depends] Add riscv qt depends support for cross compiling bitcoin-qt * Log progress while verifying blocks at level 4. * Consistently use ParseHashV to validate hash inputs in rpc * ui: Compile boost:signals2 only once * Remove redundant extern * Enable -Wredundant-decls (gcc) if available * Remove redundant redeclaration of rescanblockchain(...) in same scope * [RPC] Remove getinfo deprecation warning * gui: get special folder in unicode * Drop boost::scoped_array * Use LOCK macros for non-recursive locks * Make LOCK, LOCK2, TRY_LOCK work with CWaitableCriticalSection * MOVEONLY Move AnnotatedMixin declaration * Add unit test for DEBUG_LOCKORDER code * test: Add testing of value_ret for SelectCoinsBnB * Remove unused variable * Remove redundant assignments (dead stores) * Allow quicker shutdowns during LoadBlockIndex() * [qt] TransactionView: highlight replacement tx after fee bump * contrib: Support github pull request gitian-build * scripted-diff: Remove unused first argument to addUnchecked * tx pool: Use the entry's hash instead of the one passed to addUnchecked * Mark CTxMemPoolEntry members that should not be modified const * Add CMerkleTx::IsImmatureCoinBase method * configure: Initialise assembly enable_* variables * configure: Skip assembly support checks, when assembly is disabled * configure: Invert --enable-asm help string since default is now enabled * Mark single-argument constructors "explicit" * [gui] Make proxy icon from statusbar clickable * Return the script type from Solver * Tests: add usage note to check-rpc-mappings.py * Explain when reindex-chainstate can be used instead of reindex * Don't assert(foo()) where foo has side effects * Report progress in ReplayBlocks while rolling forward * Update functional RBF test to check replaceable flag * Add "bip125-replaceable" flag to mempool RPCs * Add AssertLockHeld assertions in CWallet::ListCoins * Let wallet importmulti RPC accept labels for standard scriptPubKeys ------------------------------------------------------------------- Fri Feb 26 09:43:55 UTC 2021 - marec@detebe.org - Update to version 0.17.2: * Build: use std:bind(validation) * http: add missing header bootlegged by boost < 1.72 ------------------------------------------------------------------- Mon Jul 08 16:17:58 UTC 2019 - marec@detebe.org - Update to version 0.17.1: * Monacoin: Update icons for osx * Monacoin: Update copyright * Monacoin: Update documents * Monacoin: Alert-command system * Monacoin: Alert system * Monacoin: Add volatile-checkpoint * Monacoin: Add checkpoint RPC * Monacoin: Add monacoinproject-key.pgp * Monacoin: Fee system * Monacoin: 3rd hardfork 2/2 (DGWv3) * Monacoin: 3rd hardfork 1/2 (Lyra2REv2) * Monacoin: 2nd hardfork (DigiShield) * Monacoin: 1st hardfork (KGW) * Monacoin: Bugfix:Allow old private key at import * Monacoin: Adjust chain parameters and blockchain size * Monacoin: Disable tests and bench * Monacoin: Update hardcoded seeds * Monacoin: Update splashscreen and icon * Monacoin: Adjust port strings * Monacoin: Adjust coin amount * Monacoin: Branding * Litecoin: Adjust splashscreen padding * Litecoin: Bump blockchain size to 22GB * Litecoin: Update man pages * Litecoin: Make it easier to specify gbuild resource limits * Litecoin: Litecoin Core 0.17.1 release notes * Litecoin: Update KR translations * Update zmq to 4.3.1 * Litecoin: Fix RU Qt translations * Litecoin: Update man pages * Litecoin: Fix Qt intro year value * Litecoin: Bump copyright year range * Litecoin: Update Litecoin icons and images * Litecoin: Fee system * Litecoin: Update hardcoded seeds for mainnet and testnet * Litecoin: Update blockchain size * Litecoin: Update default assume valid, chain work and chaintx values * Litecoin: Disable RBF * Litecoin: Qt translations * Litecoin: Update gitian-build script * Litecoin: M prefix added for script addresses * Litecoin: Add scrypt support to Travis * Litecoin: Adjust travis * Litecoin: Update man files * Litecoin: Basic changes for v0.16 release (#482) * Litecoin: Fix various tests * Litecoin: Update bech32 HRP's * Litecoin: Update windeploy cert and timestamping server * Litecoin: Update trusted keys * Litecoin: Update chainparams minimum chain work, default assume valid values and blockchain size * Litecoin: Update hardcoded seeds * Litecoin: Adjust splashscreen for testnet/regtest * Litecoin: Branding * Litecoin: Protocol and default settings * Litecoin: Fix copyright year value * Litecoin: Update gitian descriptors * Litecoin: Fix various tests * Litecoin: Developer gpg keys * Litecoin: Add Litecoin logos and icons * Litecoin: Add scrypt N=1024 PoW * Litecoin: Adjust chain parameters * Litecoin: Add historical release notes * Litecoin: Update README.md * doc: Fill in authors and changelog for 0.17.1 release notes * Stop requiring imported pubkey to sign non-PKH schemes * qa: Ensure wallet unload during walletpassphrase timeout * build: bump version to 0.17.1 * rpc: Fix wallet unload during walletpassphrase timeout * fix converttopsbt permitsigdata arg, add basic test * Add test for conversion from non-witness to witness UTXO * Add regression test for PSBT signing bug #14473 * Refactor PSBTInput signing to enforce invariant * Simplify arguments to SignPSBTInput * Add bool PSBTInputSigned * New PartiallySignedTransaction constructor from CTransction * Remove redundant txConst parameter to FillPSBT * More concise conversion of CDataStream to string * check that a separator is found for psbt inputs, outputs, and global map * [tests] Add wallet_balance.py * CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change * Remove stale comment in CalculateMaximumSignedInputSize * qa: Avoid race in p2p_invalid_block by waiting for the block request * Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) * rpc: Make HTTP RPC debug logging more informative * add test demonstrating addrLocal UB * fix uninitialized read when stringifying an addrLocal * Throw error if CPubKey is invalid during PSBT keypath serialization * Bugfix: RPC: Add address_type named param for createmultisig * gui: explicitly disable "Dark Mode" appearance on macOS * travis: Remove deprecated sudo * build: Add bitcoin-tx.exe into Windows installer * build: Remove illegal spacing in darwin.mk * Fix listreceivedbyaddress not taking address as a string * wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) * Tests: Fix a comment * qa: Add test to ensure node can generate all help texts at runtime * disallow oversized CBlockHeaderAndShortTxIDs * fix a deserialization overflow edge case * add a test demonstrating an overflow in a deserialization edge case * Add autogen.sh in ARM Cross-compilation * [wallet] Ensure wallet is unlocked before signing * doc: Clean out release notes after 0.17.0.1 * qt: Revert "Force TLS1.0+ for SSL connections" * Docs/Release notes: 0.17.0.1 is a minor release * travis: Pin flake8 version to 3.5.0 * build: Bump version for 0.17.0.1 * doc: Update release notes for 0.17.0.1 * [macOS] Remove DS_Store WindowBounds bytes object * Disable wallet and address book Qt tests on macOS minimal platform * descriptors.md: Refer to descriptors as describing instead of matching * doc/descriptors.md tweaks * Import CInv from correct module * qa: Run all tests even if wallet is not compiled * qa: Premine to deterministic address with -disablewallet * Test rpc_help.py failed: Check whether ZMQ is enabled or not. * test: Add tests for RPC help * qa: Use named args in some tests * scripted-diff: Use named arguments in feature_block * scripted-diff: Pass node into p2p_segwit acceptance tests * qa: Add some actual witness in rpc_rawtransaction * [qa] Use correct python index slices in example test * qa: Add TestNode::assert_debug_log * [doc] getblocktemplate: use SegWit in example * [wallet] Restore ability to list incoming transactions by label * doc: Clean out release notes after release 0.17.0 * doc: Update release-notes.md from upstream devwiki * depends: fix bitcoin-qt back-compat with older freetype versions at runtime * [qa] backport: Test for duplicate inputs within a transaction * Fix crash bug with duplicate inputs within a transaction * Convert non-witness UTXOs to witness if witness sig created * Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things * Replace duplcate reference with reference to reference doc * Adjust TODO link * Add descriptor reference documentation * test: Add test for config file parsing errors * util: Report parse errors in configuration file * doc: Update v0.17.0.0 manpages * doc: Change documentation for =0 for non-boolean options * fix walletcreatefundedpsbt deriv paths, add test * Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe * qa: Stop txindex thread before calling destructor * Docs: Fix help message typo optiona -> optional * Bugfix: NSIS: Exclude Makefile* from docs * RPCTypeCheck bip32derivs arg in walletcreatefunded * QA: add basic walletcreatefunded optional arg test * walletcreatefundedpsbt: remove duplicate replaceable arg * Allow ConstructTransaction to not throw error with 0-input txn * depends: fix qt determinism * qt: Pre-rc1 translations update * More tests of signer checks * Test that a non-witness script as witness utxo is not signed * Only wipe wrong UTXO type data if overwritten by wallet * Additional sanity checks in SignPSBTInput * Serialize non-witness utxo as a non-witness tx but always deserialize as witness * Fix PSBT deserialization of 0-input transactions * doc: regenerate manpages * build: bump version to 0.17.0 * contrib: fix GetDesirableServiceFlags typo in seeds/README.md * tests: Use explicit imports * net: Update hardcoded seeds * contrib: in makeseeds, add 0.16.x to PATTERN_AGENT, remove 0.13.x * doc: move-only release notes of individual prs * docs: fixed bitcoin-cli -help output for help2man * qt: Translations update before 0.17 branch * Ported usage of deprecated optparse module to argparse module * Replace median fee rate with feerate percentiles * qa: Add p2p_invalid_locator test * Make format string linter understand basic template parameter syntax * Use 72 byte dummy signatures when watching only inputs may be used * Use 71 byte signature for DUMMY_SIGNATURE_CREATOR * Always create 70 byte signatures with low R values * wallet: shuffle coins before grouping, where warranted * Introduce a maximum size for locators. * qa: blocktools enforce named args for amount * Use pushKV in some new PSBT RPCs. * Squashed 'src/leveldb/' changes from 64052c76c5..524b7e36a8 * Simplify comparison in rpc_blockchain.py. * [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object * [Tests] Cleanup extra instances of create_transaction * [Tests] Rename create_tx and move to blocktools.py * qa: wait_for_verack by default * qa: Remove redundant checkmempool/checkblockindex extra_args * Trivial: Revert translated string change, clarify wallet log messages * [Docs] upgrade rescan time warning from minutes to >1 hour * Add linting of WalletLogPrintf(...) format strings * build: Add format string linter * Docs: fix GetWarnings docs to reflect behavior * shutdown: Stop threads before resetting ptrs * wallet: Catch filesystem_error and raise InitError * [docs] Reformat -help output for help2man * qa: Raise feature_help timeout to 5s * qa: Use files for stdout/stderr to support Windows * qa: Run gen_rpcauth with sys.executable * [trivial] add doxygen-compatible comments to CAffectedKeysVisitor * qa: Close stdout and stderr file when node stops * qa: Create unicode tempdir in test_runner * doc: correct versions in dependencies.md * Docs: Improve "of" grammar * [wallet] Add wallet name to log messages * use only travis jobs: instead of mix of jobs+matrix * trivial: correct typos * trivial: Fixed typos and cleaned up language * fix locale for lint-shell * qa: Quote wallet name for rpc path * gui: Pull initial 017x translations from transifex * tx: Update transifex slug 016x→017x * -prune option -help output aligned with code * qa: Extract rpc_timewait as test param * [trivial,doc] Fix memory consistency model in comment * travis: Run bench_bitcoin once * doc: Remove outdated net comment * bench: Make CoinSelection output groups pass eligibility filter * Ignore unknown config file options for now * Update ValidationInterface() documentation to explicitly specify threading and memory model * Update documentation for SingleThreadedSchedulerClient() to specify the memory model * gui: Reject options dialog when key escape is pressed * gui: Reject edit address dialog when key escape is pressed * gui: Add GUIUtil::ItemDelegate with keyEscapePressed signal * Add BIP174 to list of implemented BIPs * wallet: sum ancestors rather than taking max in output groups * doc: Fix chainTxData comment * use travis:fold in test script steps * contrib: Remove debian and rpm subfolders * [qa] Add test for too-large wallet output groups * Acquire cs_main before ATMP call in block_assemble bench * doc: add note to contributor docs about warranted PR's * Fix osslsigncode compile issue in gitian-build * [wallet] correctly limit output group size * Report when unknown config file options are ignored * chainparams: Update with data from assumed valid chain * doc: Add historical release notes for 0.16.2 * Add aarch64 qt depends support for cross compiling bitcoin-qt * refactor: Avoid locking tx pool cs thrice * Support h instead of ' in hardened descriptor paths * Add experimental warning to scantxoutset * [QA] Extend tests to more combinations * [QA] Add xpub range tests in scantxoutset tests * Swap in descriptors support into scantxoutset * Descriptor tests * Output descriptors module * Add simple FlatSigningProvider * Add more methods to Span class * Fix accidental use of the addition assignment operator ("+="). Remove newlines from error message. * Return void instead of bool for functions that cannot fail * qt: Set BLOCK_CHAIN_SIZE = 220 * Regenerate manpages * Update copyright headers to 2018 * make .travis/yml a bit more readable * net: Add missing verification of IPv6 address in CNetAddr::GetIn6Addr(...) * wallet: Fix accidental use of the comma operator * travis: Retry to fetch docker image * contrib: Fix test-security-check fail in Ubuntu 18.04 * Fix Qt's rcc determinism for depends/gitian * [net_processing] Add thread safety annotations * Annotate AssertLockHeld() with ASSERT_CAPABILITY() for thread safety analysis * scripted-diff: prefer MAC_OSX over __APPLE__ * gui: remove macOS ProgressBar workaround * gui: remove SubstituteFonts * doc: mention that macOS 10.10 is now required * release: bump minimum required macOS to 10.10 * depends: set OSX_MIN_VERSION to 10.10 * scripted-diff: Remove trailing whitespaces * depends: use MacOS friendly sed syntax in qt.mk * doc: Add release notes for -avoidpartialspends * clean-up: Remove no longer used ivars from CInputCoin * wallet: Remove deprecated OutputEligibleForSpending * test: Add basic testing for wallet groups * wallet: Switch to using output groups instead of coins in coin selection * wallet: Add output grouping * Add -avoidpartialspends and m_avoid_partial_spends * wallet: Add input bytes to CInputCoin * moveonly: CoinElegibilityFilter into coinselection.h * utils: Add insert() convenience templates * qt: Update translation source messages * Skip is_closing() check when not available. * Removes Boost predicate.hpp dependency * doc: Adjust bitcoincore.org links * trivial: remove unneeded include * tiny refactor for ArgsManager * Avoid locking mutexes that are already held by the same thread * Use the Travis python language feature on the lint build * Don't unnecessarily install shellcheck on the lint build * trivial: Replace CPubKey::operator[] with CPubKey::vch where possible * Removes the boost/algorithm/string/join dependency * Avoid unnecessarily setting env variables on the lint build * [contrib] Add automatic setup for Ubuntu Bionic * Fix bitcoin-cli --version * [bench] Add benchmark for unserialize prevector * Fix merging of global unknown data in PSBTs * Check that PSBT keys are the correct length * Avoid creating a temporary vector for size-prefixed elements * docs: Specify preferred Python string formatting technique * docs: Link to python style guidelines from developer notes * wallet: Add error handling. Check return value of ParseUInt32(...) in ParseHDKeypath(...). * wallet: Add tests for ParseHDKeypath(...) * [travis] Don't store debug info if --enable-debug is set * tests: fixes mininode's P2PConnection sending messages on closing transport * doc: Improve command to generate list of authors for release notes * doc: Update broken links to now point to gitian-build.py * lint: Add linter for circular dependencies * contrib: correct version check * Remove redundant statement * Remove redundant unused variables * Remove redundant forward declaration * Remove program options from build system * Replace boost program_options * contrib: Clone core repo in gitian-build * depends: disable Werror for zmqlib release, causes ndk build to break * Extract MakeUnique into utilmemory.h * qa: Temporarily disable test that reads the default datadir location * travis: Check that ~/.bitcoin is never created * wallet: Avoid potential null pointer dereference in CWalletTx::GetAvailableCredit(...) * bench: Remove unused variable * Tests for PSBT * Create wallet RPCs for PSBT * Create utility RPCs for PSBT * [doc] Remove outdated comment about mining code ignoring CPFP * Initialize m_next_send_inv_to_incoming * Migrate gitian-build.sh to python * Change gitian-descriptors to use bionic instead * Modified in_addr6 cast in CConman class to work with msvc. * scripted-diff: Fix references to share/rpcuser (now share/rpcauth) * [QA] Add scantxoutset test * scantxoutset: mention that scanning by address will miss P2PK txouts * scantxoutset: support legacy P2PK script type * scantxoutset: add support for scripts * Blockchain/RPC: Add scantxoutset method to scan UTXO set * wallet: Fix backupwallet for multiwallets * [moveonly] Extract RescanWallet to handle a simple rescan * bench_bitcoin: Avoid read/write to default datadir * test_bitcoin: Avoid read/write to default datadir * Bucket for inbound when scheduling invs to hide tx time * SignPSBTInput wrapper function * Refactor transaction creation and transaction funding logic * Methods for interacting with PSBT structs * Add pubkeys and whether input was witness to SignatureData * Implement PSBT Structures and un/serialization methods per BIP 174 * bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes * build: add missing leveldb defines * Privatize CWallet::AddToWalletIfInvolvingMe * Extract CWallet::MarkInputsDirty * qa: Fix some TODOs in p2p_segwit * wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity * Fix that CWallet::AbandonTransaction would only traverse one level * Drop dead code from Stacks * QA: Fix bug in -usecli logic that converts booleans to non-lowercase strings * [QA] add createwallet disableprivatekey test * [Qt] Disable creating receive addresses when private keys are disabled * Add disable privatekeys option to createwallet * Add option to disable private keys during internal wallet creation * Add FindScriptPubKey() to search the UTXO set * [tests] skip rpc_zmq functional test when python3 zmq lib is not present * Tools: fix BIND_NOW check in security-check.py * Add facility to store wallet flags (64 bits) * Use common SetDataDir method to create temp directory in tests. * Add depends 32-bit arm support for bitcoin-qt * Refactors `keystore.h` type aliases. * doc: Add release notes for -printtoconsole and -debuglogfile changes * tests: Use MAX_SCRIPT_ELEMENT_SIZE from script.py * Remove dead service bits code * Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain * Remove unused argument to WitnessSigOps(...) * Remove unused argument to DefaultOptions(...) * Remove unused argument to ThreadHTTP(...) * Make g_enable_bip61 a member variable of PeerLogicValidation * Remove useless mapRequest tracking that just effects Qt display. * Corrected text to reflect new[er] process of specifying fingerprints instead of individual keys. * depends: Mention RISC-V known compilation issue with gcc-7.3.x * [tests] functional test for createmultisig RPC * segwit support for createmultisig RPC * Move AddAndGetDestinationForScript from wallet to outputype module * Add outputtype module * depends: update zmq config.guess/config.sub for riscv support * depends: latest config.sub * depends: latest config.guess * Remove unused argument to ProcessGetBlockData(...) * net: Remove unused interrupt from SendMessages * Fix command line help for -printtoconsole and -debuglogfile * Use __cpuid_count for gnu C to avoid gitian build fail. * bitcoin-tx: Stricter check for valid integers * Upgrade Qt depends to 5.9.6 * Fix depends Qt5.9.4 mac build * Ugrade Qt depends to Qt5.9.4 * fix bench/prevector.cpp * RPC: Add new getzmqnotifications method. * Docs: Modify policy to not translate command-line help * Remove CombineSignatures and replace tests * Replace CombineSignatures with ProduceSignature * Make SignatureData able to store signatures and scripts * Add simple bech32 benchmarks * Docs: Improve doc of options addnode, connect, seednode * scripted-diff: Replace NET_TOR with NET_ONION * Delete double semicolon in wallet.cpp and misc.cpp * Detect if char equals int8_t * logging: avoid nStart may be used uninitialized in AppInitMain warning * Inline Sign1 and SignN * [RPC] [wallet] allow getbalance to use min_conf and watch_only without accounts. * [tests] p2p_segwit: sync_blocks in subtest wrapper. * [tests] p2p_segwit: remove unnecessary arguments from subtests. * [tests] p2p_segwit: log and assert segwit status in subtest wrapper. * [tests] p2p_segwit: Make sure each subtest leaves utxos for the next. * [tests] p2p_segwit: wrap subtests with subtest wrapper. * [tests] p2p_segwit: re-order function definitions. * [tests] p2p_segwit: standardise comments/docstrings. * [tests] p2p_segwit: Fix flake8 warnings. * Make ZMQ notification interface instance global. * [wallet] GetBalance can take a min_depth argument. * [wallet] factor out GetAvailableWatchOnlyBalance() * [wallet] deduplicate GetAvailableCredit logic * [wallet] Factor out GetWatchOnlyBalance() * [wallet] GetBalance can take an isminefilter filter. * Fix AreInputsStandard test to reference the proper scriptPubKey * [wallet] loadwallet shouldn't create new wallets. * bench: Simplify CoinSelection * tests: Fix incorrect documentation for test case cuckoocache_hit_rate_ok * [tests] Check signrawtransaction* errors on missing prevtx info * Error on missing amount in signrawtransaction* * Remove boost dependency (boost/assign/std/vector.hpp) * depends: Update Qt download url * Fix incorrect tests * depends: Add RISC-V support * Docs: More precise explanation of parameter "onlynet" * Show symbol for inbound/outbound in peer table * Use immintrin.h everywhere for intrinsics * Add SHA256 implementation using using Intel SHA intrinsics * qa: Avoid start/stop of the network thread mid-test * [qa] wallet_basic: Specify minimum required amount for listunspent * qt: Move BitcoinGUI initializers to class, fix initializer order warning * [qt] coincontrol: Remove unused qt4 workaround * Break circular dependency: init -> * -> init by extracting shutdown.h * Drop unused init.h includes * Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor) * doc: Clarify that mempool txiter is const_iterator * travis: Build with --enable-debug (x86_64-unknown-linux-gnu) * Add -ftrapv to DEBUG_CXXFLAGS when --enable-debug is used * [Refactor] CPU feature detection logic for SHA256 * bench: Add missing pow.h header * policy: Remove promiscuousmempoolflags * [qa] mininode: Expose connection state through is_connected * [tests] Fix p2p_sendheaders race * [qa] Add a test for merkle proof malleation * Net: Fixed a race condition when disabling the network. * Document FreeBSD quirk. Fix FreeBSD build. * Restrict as much as possible in net_processing to translation unit * bugfix: Delete walletView in WalletFrame::removeWallet * Obsolete #!/bin/bash shebang * Fix parameter count check for importpubkey. * Qt: load wallet in UI after possible init aborts * [move-only] Move things only referenced in net_processing out of header file * Rescope g_enable_bip61 to net_processing * Decouple wallet version from client version * For AVX2 code, also check for AVX, XSAVE, and OS support * [tests] Remove accounts from wallet_importprunedfunds.py * [wallet] Don't use accounts when checking balance in sendmany * [wallet] deprecate sendfrom RPC method. * Test: Harden lint-filenames.sh * doc: Rewrite some validation doc as lock annotations * bugfix: Remove dangling wallet env instance * ui: Support wallets unloaded dynamically * doc: Add release notes for unloadwallet RPC * test: Wallet methods are disabled when no wallet is loaded * test: Add functional tests for unloadwallet RPC * rpc: Add unloadwallet RPC * Follow-up to #13454: Fix broken build by exporting LC_ALL=C * doc: Remove mention of Qt4 from build docs * test: Update travis to not test Qt4 anymore * gui: Remove QT_VERSION fallbacks for Qt < 5 * Move rpc/util.cpp from libbitcoin-util to libbitcoin-server * Add P2WSH destination helper and use it instead of manual hashing * Add additional unit tests for invalid IsMine combinations * Do not expose invalidity from IsMine * Docs: Improve readability of "Squashing commits" * Fix CVE-2018-12356 by hardening the regex. * build: add warning to detect hidden copies in range-for loops * cleanup: avoid hidden copies in range-for loops * doc: Add historical release notes for 0.16.1 * Fix incorrect shell quoting in FreeBSD build instructions. * validation: count blocks correctly for check level < 3 * Add linter: Enforce the source code file naming convention described in the developer notes * Avoid concurrency issue * ScanforWalletTransactions should mark input txns as dirty * have verifytxoutproof check the number of txns in proof structure * Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C" * Add "export LC_ALL=C" to all shell scripts * doc: Remove note to install all boost dev packages * build: Build system changes to support only Qt5 * expose CBlockIndex::nTx in getblock(header) * tests: Drop variadic macro * travis: Change Mac goal to all deploy so that travis can build all executables for Mac. * Add unavailable options to hidden options category * Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python * tests: Fix lock-order-inversion (potential deadlock) in DoS_tests. Reported by TSAN. * Explicitly specify encoding when opening text files in Python code * Improve coverage of SHA256 SelfTest code * travis: Increase travis_wait time while verifying commits * rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest * Use python instead of slow shell script on verify-commits * Reset default -g -O2 flags when enable debug * [build] Tune wildcards for LIBSECP256K1 target * Only set fNewBlock to true in AcceptBlock when we write to disk * When build fails due to lib missing, indicate which one * qa: Log as utf-8 * scripted-diff: Avoid temporary copies when looping over std::map * rpc: Avoid "duplicate" return value for invalid submitblock * wallet: Erase wtxOrderd wtx pointer on removeprunedfunds * test: Add MempoolAncestryTests * mempool: Calculate descendant maximum thoroughly * wallet: Switch to using ancestor/descendant limits * wallet: Strictly greater than for ancestor caps * Remove deprecated TransactionWithinChainLimit * Switch to GetTransactionAncestry() in OutputEligibleForSpending * Add GetTransactionAncestry to CTxMemPool for general purpose chain limit checking * mempool: Fix max descendants check * mempool: Add explicit max_descendants * validation: check the specified number of blocks (off-by-one) * Removed unused == operator from CMutableTransaction. * Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 * Drop ParseHashUV in favor of calling ParseHashStr * qa: Remove portseed_offset from test runner * Make ReceivedBlockTransactions return void * crypto: cleanup sha256 build * speed up of tx_validationcache_tests by reusing of CTransaction. * lint: Add linter to error on #include <*.cpp> * Clarify include recommendation * Enforce the use of bracket syntax includes ("#include <foo.h>") * Use bracket syntax includes ("#include <foo.h>") * docs: Mention lint-locale-dependence.sh in developer-notes.md * build: Add linter for checking accidental locale dependence * Document validationinterace callback blocking deadlock potential. * utils: checking for bitcoin addresses in translations * Drop uint 256 not operator * index: Move index DBs into index/ directory. * index: Remove TxIndexDB from public interface of TxIndex. * MOVEONLY: Move BaseIndex to its own file. * index: Generalize logged statements in BaseIndex. * index: Extract logic from TxIndex into reusable base class. * db: Make reusable base class for index databases. * db: Remove obsolete methods from CBlockTreeDB. * cli: Ignore libevent warnings * Enable double-SHA256-for-64-byte code on 32-bit x86 * Rename “OS X” to the newer “macOS” convention * build: Guard against accidental introduction of new Boost dependencies * bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) * Add stdin, stdout, stderr to ignored export list * Use IN6ADDR_ANY_INIT instead of in6addr_any * GCC-7 and glibc-2.27 compat code * [docs] update transifex doc link * doc: split FreeBSD build instructions out of build-unix.md * Add option to use docker for gitian-build.sh * qa: Increase includeconf test coverage * [wallets] [docs] Add release notes for createwallet RPC. * [wallet] [tests] Add tests for `createwallet` RPC. * Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling * bench: Don't return a bool from main * qa: Fixup setting of PATH env var * qa: Avoid checking reject code for now * wallet: Prevent segfault when sending to unspendable witness * [tests] Add logging to provide anchor points when debugging failures. * Test gArgs erroring on unknown args * Give an error and exit if there are unknown parameters * Use a struct for arguments and nested map for categories * Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction * travis: Skip cache for lint stage * Stop translating command line options * doc: update bitcoin-dot-org links in release-process.md * refactor: add a function for determining if a block is pruned or not * Remove template matching and pseudo opcodes * [MOVEONLY] Move unused Merkle branch code to tests * 8-way AVX2 implementation for double SHA256 on 64-byte inputs * 4-way SSE4.1 implementation for double SHA256 on 64-byte inputs * Use SHA256D64 in Merkle root computation * Specialized double sha256 for 64 byte inputs * policy: Treat segwit as always active * Ensure gitian-build.sh uses bash * doc: remove leftover check-doc documentation * [wallet] [rpc] Add `createwallet` RPC * test: Output should be unlocked when spent * wallet: Unlock spent outputs * Travis: Build tests on Ubuntu 18.04 with docker * Make handling of invalid in IsMine more uniform * test: Move linters to test/lint, add readme * Fix FreeBSD build by including utilstrencodings.h * Do not use uppercase characters in source code filenames * docs: Add a note about the source code filename naming convention * qa: Fix wallet_listreceivedby race * build: split warnings out of CXXFLAGS * Tests: Add data file * Tests: Test new getblockstats RPC * RPC: Introduce getblockstats * wallet: Use shared pointer to retain wallet instance * qa: Initialize lockstack to prevent null pointer deref * docs: Update OpenBSD build instructions for OpenBSD 6.3 * Declare TorReply parsing functions in torcontrol_tests * [wallet] Fix incorrect comment for DeriveNewSeed. * Drop the chain argument to GetDifficulty * trivial: Mark overrides as such. * Increased max width of amount field to prevent number overflow bug. * [docs] Add release notes for HD master key -> HD seed rename * [rpc] [wallet] Add 'hdmasterkeyid' alias return values. * [refactor] manually change remaining instances of master key to seed. * scripted-diff: Rename master key to seed * Qt: use [default wallet] as name for wallet with no name * Drop UpdateTransaction in favor of UpdateInput * Qt/Bugfix: fix handling default wallet with no name * Add Unit Test for SingleThreadedSchedulerClient * fixup! ui: Support wallets loaded dynamically * wallet: Exit SyncMetaData if there are no transactions to sync * [qt] Added satoshi unit "Satoshi (sat)" will be displayed in dropdowns and status bars. "sat" will be used when appended to numbers. * [qt] BitcoinUnits::format with zero decimals Formatting with zero decimals will now result in 123 instead of 123.0 * doc: Bump to Ubuntu Bionic 18.04 in build-windows.md * break circular dependency: random/sync -> util -> random/sync * Wallet: Refactor ReserveKeyFromKeyPool for safety * RPCAuth Detection in Logs * Revert "Merge #12870: make clean removes src/qt/moc_ files" * GUI: Allow generating Bech32 addresses with a legacy-address default * GUI: Rephrase Bech32 checkbox text/tooltip * Add circular dependencies script * [wallet] [docs] Update release notes for removing `getlabeladdress` * [wallet] [rpc] Remove getlabeladdress RPC * ui: Support wallets loaded dynamically * ui: Remove unnecessary variable fFirstWallet * [docs] Add release notes for `loadwallet` RPC. * [wallet] [tests] Test loadwallet * [wallet] [rpc] Add loadwallet RPC * [wallet] Pass error message back from CWallet::Verify() * [wallet] Add CWallet::Verify function * Add unit tests for signals generated by ProcessNewBlock() * [gui] Add proxy icon in statusbar * [wallet] setup wallet background flushing in WalletInit directly * [wallet] Fix potential memory leak in CreateWalletFromFile * [qt] OptionsDialog: add prune setting * net: Serve blocks directly from disk when possible * Break circular dependency: chain -> pow -> chain * Add compile time checking for all cs_wallet runtime locking assertions * doc: Mention disabling BIP61 in bips.md * net: Add option `-enablebip61` to configure sending of BIP61 notifications * bench: Add block assemble benchmark * travis: Rename the build stage "check_doc" to "lint" * Bump wallet version for pre split keypool * Use a keypool of presplit keys after upgrading to hd chain split * Allow -upgradewallet to upgradewallets to HD * Test sethdseed * Add 'sethdseed' RPC to initialize or replace HD seed * Fix concurrency-related bugs in ActivateBestChain * Do not unlock cs_main in ABC unless we've actually made progress. * Enable Travis checking for two Python linting rules we are currently not violating * Enable W191 and W291 flake8 checks. Remove trailing whitespace from Python files. Convert tabs to spaces. * test: Ensure that recursive -includeconf produces appropriate warnings * util: warn about recursive -includeconf arguments in configuration files * [tests] Remove spurious error log in p2p_segwit.py * [qa] Handle disconnect_node race * [qa] Avoid printing to console during cache creation * Make gArgs aware of the arguments * Bugfix: ensure consistency of m_failed_blocks after reconsiderblock * [tests] Allow stderr to be tested against specified string * [Tests] Use LIBC_FATAL_STDERR_=1 in tests * [Tests] Write stdout/stderr to datadir instead of temp file. * wallet: Improve logging when BerkeleyDB environment fails to close * [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs * [tests] Fixed intermittent failure in p2p_sendheaders.py. * [qt]: changes sendcoinsdialog's box layout for improved readability. * qa: Remove unused option --srcdir * Refactor SHA256 code * Benchmark Merkle root computation * Bugfix: the end of a reorged chain is invalid when connect fails * RPC Docs: gettxout*: clarify bestblock and unspent counts * Fix typos * Refactor: RPC: Separate GetBlockChecked() from getblock() * Remove enum specifier (to avoid re-declare scoped enum as unscoped) * replace modulus with FastMod * Add Clang thread safety analysis annotations * Fix missing locking in CTxMemPool::setSanityCheck(double dFrequency) * Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins) * Add compile time checking for all ::mempool.cs runtime locking assertions * Separate HaveKey function that checks whether a key is in a keystore * Cache witness hash in CTransaction * Make CMutableTransaction constructor explicit * qa: Pad scriptPubKeys to get minimum sized txs * Policy to reject extremely small transactions * Add transaction tests for constant scriptCode * Add constant scriptCode policy in non-segwit scripts * Fix MAX_STANDARD_TX_WEIGHT check * doc: Mention good first issue list in CONTRIBUTING.md * Make it clear which functions that are intended to be translation unit local * Add some checks for invalid recursion in IsMine * Simplify IsMine logic * Make IsMine stop distinguishing solvable/unsolvable * Make coincontrol use IsSolvable to determine solvability * [logging] Don't incorrectly log that REJECT messages are unknown. * Fix rescanblockchain rpc to property report progress * wallet: Reset BerkeleyDB handle after connection fails * Print a log message if we fail to shrink the debug log file * refactor: Avoid extra lookups of mapAddressBook in listunspent RPC * rpc: Reduce cs_main lock in listunspent * [tests] Remove 'account' API from wallet functional tests * Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 * devtools: Make linter check LogPrint calls * Add missing newlines to LogPrint debug logging * Make sure initialization occurs in the constructor * wallet: Interrupt rescan on shutdown request * Handle unsuccessful fseek(...):s * logging: remove unused return value from LogPrintStr * logging: Fix potential use-after-free in LogPrintStr(...) * doc: Add release notes for -includeconf * test: Test includeconf parameter. * rpcauth: Make it possible to provide a custom password * [doc] qt: fixes broken link on readme * [tests] Fix flake8 warnings in several wallet functional tests * Revert #12769: Add systemd service to bitcoind in debian package * Add Windows shutdown handler * Remove python2 from configure.ac * [Docs] Add version footnote to tor.md * [tests] Fix race in rpc_deprecated.py * wallet: Add Clang thread safety annotations for variables guarded by cs_db * nit: descendent should be spelled descendant even in the release-notes * scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending * nit: fix typo for entry description string * Remove script to clean up datadirs * util: Store debug log file path in BCLog::Logger member. * scripted-diff: Rename BCLog::Logger member variables. * util: Refactor GetLogCategory. * Add Clang thread safety annotations for variables guarded by cs_warnings * Add Clang thread safety annotations for variables guarded by cs_nTimeOffset * Add Clang thread safety annotations for variables guarded by cs_rpcWarmup * Add missing cs_KeyStore lock * Add locking annotations for variables guarded by cs_KeyStore * util: Encapsulate logCategories within BCLog::Logger. * util: Move debug file management functions into Logger. * util: Establish global logger object. * Use --failfast when running functional tests on Travis * Add --failfast option to functional test runner * Simplify semantics of ChainStateFlushed callback * scripted-diff: Rename SetBestChain callback ChainStateFlushed * Remove "rpc" category from GetWarnings * rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section * tests: Add test for 64-bit PE, modify 32-bit test results * build: sync ax_boost_chrono/unit_test * Remove Safe mode * -includeconf=<path> support in config handler, for including external configuration files * Don't test against min relay fee information in mining_prioritisetransaction.py * Add compile time checking for all cs_KeyStore runtime locking assertions * [doc] Include txindex changes in the release notes. * [test] Simple unit test for TxIndex. * [rpc] Public interfaces to GetTransaction block until synced. * [index] Move disk IO logic from GetTransaction to TxIndex::FindTx. * [validation] Replace tx index code in validation code with TxIndex. * [init] Initialize and start TxIndex in init code. * [index] TxIndex method to wait until caught up. * [index] Allow TxIndex sync thread to be interrupted. * [index] TxIndex initial sync thread. * [index] Create new TxIndex class. * [db] Migration for txindex data to new, separate database. * [db] Create separate database for txindex. * [wallet] [rpc] Fix importaddress help text * [tests] [qt] Add tests for address book manipulation via EditAddressDialog * [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage * [qt] Display more helpful message when adding a send address has failed * Add purpose arg to Wallet::getAddress * test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check * [tests] Make rpcauth.py testable and add unit tests * qa: Clarify documentation for send_txs_and_test * wallet: Make vpwallets usage thread safe * List support for BIP173 in bips.md * Make tests pass after 2020 * wallet: Make fee settings non-static members * Add logging and error handling for file syncing * qt: Don't log to console by default * test: Add rpcauth pair that generated by rpcauth * trivial: Fix relevent typo * qa: Normalize executable location * [tests] Fix feature_block flakiness * [tests] tidy up blocktools.py * [tests] Fix flake8 warnings in blocktools.py * [doc][trivial] no retargeting in regtest mode * Add systemd service for bitcoind * Sync contrib/debian from Matt Corallo's PPA * Use anonymous namespace instead of static functions * Mention removal of bare multisig IsMine in release notes * Do not treat bare multisig as IsMine * Optimization: only test for witness scripts at top level * Track difference between scriptPubKey and P2SH execution in IsMine * Switch to a private version of SigVersion inside IsMine * Do not expose SigVersion argument to IsMine * Output values for "min relay fee not met" error * Fix for utiltime to compile with msvc. * [wallet] [tests] Test disallowed multiwallet params * [wallet] Fix zapwallettxes/multiwallet interaction. * [qa] Attach node index to test_node AssertionError and print messages * trivial: Improve include comment in src/interfaces/wallet.h * node: Removed unused wallet-related methods from the Node interface. * benchmark: Removed bench/perf.cpp * Remove unused IsMine overload * Make CScript -> CScriptID conversion explicit * Consistently log CValidationState on failure * wallet: Add HasWallets * wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets * MOVEONLY: Move logging code from util.{h,cpp} to new files. * refactor: Drop CWalletRef typedef * scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks * Add new fee structure with all sub-fields denominated in BTC * bench: Amend mempool_eviction test for witness txs * bench: Move constructors out of mempool_eviction hot loop * [doc] Add comments for chainparams.h, validation.cpp * [docs] Add release notes for deprecated 'account' API * [wallet] [tests] Add tests for accounts/labels APIs * test: Fix dangling wallet pointer in vpwallets * [wallet] [rpc] Deprecate wallet 'account' API * [wallet] [rpc] Deprecate account RPC methods * Make --enable-debug to pick better options * Print to console by default when not run with -daemon * qa: Add test for orphan handling * Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip * net: Minor accumulated cleanups * [tests] Set -deprecatedrpc=accounts in tests * [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py * [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table * qt:Show the entire Window when double clicking on taskbar * Default to defining endian-conversion DECLs in compat w/o config * [doc] build-windows: Switch to Artful, since Zesty is EOL * tests: Remove redundant bytes² * Enable additional flake8 rules * Minor Python cleanups to make flake8 pass with the new rules enabled * tests: Remove compatibility code not needed now when we're on Python 3 * correcting the array name from pnSeeds6 to pnSeed6 * Avoid launching as admin when NSIS installer ends. * Fix inconsistent namespace formatting guidelines * Note new weight field in release-notes. * Test new weight field in p2p_segwit * Expose a transaction's weight via RPC * [contrib] convert test-security-check to python3 * add lint tool to check python3 shebang * [MOVEONLY] Turn CScript::GetOp2 into a function and move to cpp * [MOVEONLY] Move CSCript::FindAndDelete to interpreter * Delete unused non-const-iterator CSCript::GetOp overloads * Make iterators in CScript::FindAndDelete const * [qa] Test that v0 segwit outputs can't be spent pre-activation * Always enforce SCRIPT_VERIFY_WITNESS with P2SH * [qa] Remove some pre-activation segwit tests * Separate NULLDUMMY enforcement from SEGWIT enforcement * Use P2SH consensus rules for all blocks * wallet: Refactor g_wallet_init_interface to const reference * wallet: Make WalletInitInterface members const * test: Add rpc_bind test to default-run tests * Avoid std::locale/imbue in DateTimeStrFormat * Drop dead code CScript::Find * macOS: Prevent Xcode 9.3 build warnings * Tighten up bech32::Decode(); add tests. * logging: bypass timestamp formatting when not logging * Give an error when rescan is aborted by the user * Add cancel button to rescan progress dialog * Add assertion to guide static analyzers. Clang Static Analyzer needs this guidance. * Fix dead stores. Values were stored but never read. Limit scope. * [doc] Fix comment in FindForkInGlobalIndex * tests: Avoid copies of CTransaction * bitcoin-tx: Remove unused for loop * speed up wallet_hd.py and clarify/augment checks * debug log number of unknown wallet records on load * depends: Fix Qt build with XCode 9.3 * Add shell script linting: Check for shellcheck warnings in shell scripts * Add config changes to release notes * [tests] Unit tests for -testnet/-regtest in [test]/[regtest] sections * ArgsManager: special handling for -regtest and -testnet * [tests] Unit tests for network-specific config entries * ArgsManager: Warn when ignoring network-specific config setting * ArgsManager: limit some options to only apply on mainnet when in default section * [tests] Use regtest section in functional tests configs * [tests] Unit tests for config file sections * ArgsManager: support config file sections * ArgsManager: drop m_negated_args * depends: Add 'make clean' and 'make clean-all' rules * Document how FlushStateMode::NONE is handled * Call FlushStateToDisk(...) regardless of fCheckForPruning * rpc: Drop redundant testing of signrawtransaction prevtxs args * Remove redundant initializations from the constructor * Ignore macOS daemon() depracation warning * ArgsManager: keep command line and config file arguments separate * test: Fix sign for expected values * Extract consts for WITNESS_V0 hash sizes * [docs] Add release notes for wallet 'label' API. * [wallet] [rpc] introduce 'label' API for wallet * Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. * Refine travis check for duplicate includes * Make DummySignatureCreator a singleton * Make BaseSignatureCreator a pure interface * wallet: Remove redundant lambda function arg in handleTransactionChanged * Increase entropy in test temp directory name * Reorder travis builds * tests: run tests in parallel * tests: split up actual tests and helper files * Initialize non-static class members where they are defined * Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor. * Docs: fixed link, replaced QT with Qt * added logging line back that was accidentally removed with #10762 * [qa] Delete cookie file before starting node * Logprint the start of a rescan * util: Remove designator initializer from ScheduleBatchPriority * util: Pass pthread_self() to pthread_setschedparam instead of 0 * [doc] devtools: Setup ots git integration * Add Travis check for duplicate includes * Remove duplicate includes * test: Assert on correct variable * Introduce BigEndian wrapper and use it for netaddress ports * qa: Windows fixups for functional tests * [qa] Ensure bitcoind processes are cleaned up when tests end * Use std::bind instead of boost::bind to re-lock the wallet * [rpcwallet] Clamp walletpassphrase value at 100M seconds * list the types of scripts we should consider for a witness program * Add m_ prefix to WalletBatch::m_batch * Update walletdb comment after renaming. * scripted-diff: Rename wallet database classes * [logging] add lint-logs.sh to check for newline termination. * [logging] Comment all continuing logs. * doc: add qrencode to brew install instructions * scripted-diff: Avoid `interface` keyword to fix windows gitian build * Asserts that the tx version number is a signed 32-bit integer. * tests: Add check for test suite name uniqueness in lint-tests.sh * tests: Add note about uniqueness requirement for test suite names * tests: Avoid test suite name collision in wallet crypto_tests * build: Show enabled sanitizers in configure output * [test] fundrawtransaction: lock watch-only shared address * docs: Fix conflicting statements about initialization in developer notes * wallet: Refactor to WalletInitInterface* const g_wallet_init_interface * wallet: Make WalletInitInterface and DummyWalletInit private * [tests] Add additional unit tests for -nofoo edge cases * [tests] Check GetChainName works with config entries * [tests] Add unit tests for ReadConfigStream * ReadConfigStream: assume the stream is good * Separate out ReadConfigStream from ReadConfigFile * [tests] Add unit tests for GetChainName * Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName * Get rid of ambiguous OutputType::NONE value * Support serializing Span<unsigned char> and use that instead of FLATDATA * Add Slice: a (pointer, size) array view that acts like a container * wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined. * doc: Use bitcoind in Tor documentation * Tests: Add Metaclass for BitcoinTestFramework * Add developer notes about blocking GUI code * Use WalletBalances struct in Qt * Remove direct bitcoin calls from qt/sendcoinsdialog.cpp * Remove direct bitcoin access from qt/guiutil.cpp * Remove direct bitcoin calls from qt transaction table files * Remove direct bitcoin calls from qt/paymentserver.cpp * Remove direct bitcoin calls from qt/addresstablemodel.cpp * Remove direct bitcoin calls from qt/coincontroldialog.cpp * Remove most direct bitcoin calls from qt/walletmodel.cpp * Remove direct bitcoin calls from qt/optionsdialog.cpp * Remove direct bitcoin calls from qt/rpcconsole.cpp * Remove direct bitcoin calls from qt/bantablemodel.cpp * Remove direct bitcoin calls from qt/peertablemodel.cpp * Remove direct bitcoin calls from qt/intro.cpp * Remove direct bitcoin calls from qt/clientmodel.cpp * Remove direct bitcoin calls from qt/splashscreen.cpp * Remove direct bitcoin calls from qt/utilitydialog.cpp * Remove direct bitcoin calls from qt/bitcoingui.cpp * Remove direct bitcoin calls from qt/optionsmodel.cpp * Remove direct bitcoin calls from qt/bitcoin.cpp * [trivial] Add newlines to end of log messages. * Modernize best block mutex/cv/hash variable naming * Fix csBestBlock/cvBlockChange waiting in rpc/mining * Add src/interface/README.md * make clean removes src/qt/moc_ files * [tests] simplify binary and hex response parsing in interface_rest.py * [tests] only use 2 nodes in interface_rest.py * [tests] refactor interface_rest.py to avoid code repetition * [tests] Make json request building more consistent in interface_rest.py * [tests] improve logging and documentation in interface_rest.py * [tests] fix flake8 warnings in interface_rest.py test * [wallet] [rpc] [doc] importprivkey: hint about importmulti * Adding logging for loop iteration level in p2p_sendheaders.py * [moveonly] Extract HelpRequested to dry up the help options testing * [tests] Stop feature_block.py from blowing up memory. * Bugfix: Include <memory> for std::unique_ptr * [tests] Remove Comparison Test Framework * [tests] Remove bip9-softforks.py * doc: Add testmempoolaccept to release-notes * Avoid travis lint-include-guards error * Add P2P, Network, and Qt categories to the desktop icon * qa: Match full plain text by default * travis: Run verify-commits only on cron jobs * rpc: fix type mistmatch in listreceivedbyaddress * [tests] Test starting bitcoind with -h and -version * test: Remove travis checkout depth * Enable flake8 warning F841 ("local variable 'foo' is assigned to but never used") * Remove assigned but never used local variables * [verify-commits] Add some additional useful documentation. * Increase LevelDB max_open_files unless on 32-bit Unix. * Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished * [contrib] fixup symbol-check.py Python3 support * [contrib] fixup security-check.py Python3 support * adapt bumpfee change discard test to be more strict and add note on p2sh discrep * [tests] Fix intermittent rpc_net.py failure. * Add --with-sanitizers option to configure * Improve formatting of developer notes * Add Marco-expired-key-signed-commits to allow-revsig-commits * Revert "test: Update trust git root". * init: Remove help text for non-existent -fuzzmessagestest arg * contrib: Remove unused import string * contrib: Fix check-doc script regexes * [Tests] fix a typo in TestNode.assert_start_raises_init_error() * test: List any failed tests at the end of test_runner output * Make base58 python contrib code work with python3 * test: Make summary row bold-red if any test failed * Track negated arguments in the argument paser. * Add additional tests for GetBoolArg() * qa: Fix function names in feature_blocksdir * Fix error in memory usage calculation (unintended integer division) * [wallet] Add dummy wallet init class * [wallet] Use global g_wallet_init_interface to init/destroy the wallet. * doc: Add note about our preference for scoped enumerations ("enum class") * Set SCHED_BATCH priority on the loadblk thread. * Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion * doc: Refer to witness reserved value as spec. in the BIP * init: Fix help message for checkblockindex * Change all python files to use Python3 * do not truncate .dat extension for wallets in gui * qt: Avoid resetting on resetguisettigs=0 * [wallet] Create wallet init interface. * [wallet] Move wallet init functions into WalletInit class. * [Tests] Use blockmaxweight where tests previously had blockmaxsize * rpc: Adjust ifdef to avoid unreachable code * Qt: hide RPCConsole wallet selector when no wallets are present * Qt: show wallet name in request dlg in case of multiwallet * Qt: show wallet name in send confirmation dlg in case of multiwallet * GUI: RPCConsole: Log wallet changes * Qt: Get wallet name from WalletModel rather than passing it around * Qt: When multiple wallets are used, include in notifications the name * Qt: QComboBox::setVisible doesn't work in toolbars, so defer adding it at all until needed * Qt: Add wallet selector to debug console * Reduce variable scopes * [RPC] Remove field in getblocktemplate help that has never been used * Introduce interface for signing providers * Qt: Remove unused method setupAmountWidget(...) * Add username and ip logging for RPC method requests * [REST] Handle UTXO retrieval when ignoring the mempool * Make CTxMemPool::isSpent() const * rpc: Add testmempoolaccept * Move CKeyStore::cs_KeyStore to CBasicKeyStore * Inline CKeyStore::AddKey(const CKey &) in CBasicKeyStore * [CI]: bump travis timeout for make check to 50m * add release note for sendmany output shuffling * shuffle sendmany recipients ordering to shuffle tx outputs * Docs: Improve documentation on standard communication channels * Add lint-include-guards.sh which checks include guard consistency * Fix missing or inconsistent include guards * Document include guard convention * [config] Remove blockmaxsize option * [tests] Change feature_csv_activation.py to use BitcoinTestFramework * [tests] Move utility functions in feature_csv_activation.py out of class. * [tests] Remove nested loops from feature_csv_activation.py * Move compressor utility functions out of class * Add native support for serializing char arrays without FLATDATA * Replace boost::call_once with std::call_once * feebumper: discard change outputs below discard rate * shuffle selected coins before transaction finalization * Qt: Warn users about invalid-BIP21 URI bitcoin:// * Fix typos * tests: Remove unused argument max_invalid from check_estimates(...) * Fix typos * Make FastRandomContext support standard C++11 RNG interface * use base58 map instead of strchr() * Support serialization as another type without casting * Remove unnecessary NONNEGATIVE_SIGNED * -blocksdir: keep blockindex leveldb database in datadir * tests: Test connecting with non-existing RPC cookie file * tests: Test connecting to a non-existing server * qa: Allow for partial_match when checking init error * scripted-diff: rename TestNode to TestP2PConn in tests * [tests] Improve assert message when wait_until() fails * [tests] Change feature_block.py to use BitcoinTestFramework * qa: Use node.datadir instead of tmpdir in test framework * Rename wallet_accounts.py test * Rename account to label where appropriate * Remove unreachable help conditions * [tests] Add logging to feature_block.py * [tests] Tidy up feature_block.py * [tests] Fix flake8 warnings in feature_block.py * tests: Add lint-tests.sh which checks the test suite naming convention * tests: Rename test suits not following the test suite naming convention * tests: Add note about test suite naming convention * Qt: remove "new" button during receive-mode in addressbook * Avoiding 'file' function name from python2 with more descriptive variable naming * [tests] improve logging in feature_csv_activation.py * [tests] fix flake8 nits in feature_csv_activation.py * [Tests] Require exact match in assert_start_raises_init_eror() * [Tests] Move assert_start_raises_init_error method to TestNode * QA: Add -blocksdir test * wallet: Change output type globals to members * Append scripts to new test_list array to fix bad assignment * [Trivial] Simplify if-else blocks and more descriptive variable naming * Make verify-commits.sh test that merges are clean * test: Use os.path.join consistently in feature_pruning tests * test: Use wait_until in tests where time was used for polling * Add static_assert to prevent VARINT(<signed value>) * Document RPC method aliasing * Test that BnB is not used when there are preset inputs * Remove redundant checks for MSG_* from configure.ac * Do not check for main() in libminiupnpc * ax_boost_{chrono,unit_test_framework}.m4: take changes from upstream * Actually disable BnB when there are preset inputs * Remove unused variable in SortForBlock * Provide relevant error message if datadir is not writable. * Polish interfaces around PeerLogicValidation * Apply hardening measurements in bitcoind systemd service file * Support deserializing into temporaries * Merge READWRITEMANY into READWRITE * Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER * travis: Clone depth 1 unless $CHECK_DOC * Add a test to make sure that negative effective values are filtered * Benchmark BnB in the worst case where it exhausts * Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it * Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee * Move original knapsack solver tests to coinselector_tests.cpp * Move current coin selection algorithm to coinselection.{cpp,h} * Add tests for the Branch and Bound algorithm * Remove coinselection.h -> wallet.h circular dependency * Use a struct for output eligibility * Move output eligibility to a separate function * Implement Branch and Bound coin selection in a new file * [qa] util: Remove unused sync_chain * qt: Avoid querying unnecessary model data when filtering transactions * rpc: Update createrawtransaction examples * Split up and sanitize CAccountingEntry serialization * Ubuntu xenial first dependencies * Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s * Allow to optional specify the directory for the blocks storage * configure: UniValue 1.0.4 is required for pushKV(, bool) * Log fatal LevelDB errors more verbosely * Store effective value, fee, and long term fee in CInputCoin * Calculate and store the number of bytes required to spend an input * Split up and sanitize CWalletTx serialization * scripted-diff: Convert 11 enums into scoped enums (C++11) * Format timestamps using ISO 8601 formatting (e.g. "2018-02-28T12:34:56Z") * bitcoin-cli: Provide a better error message when bitcoind is not running * [wallet] Get rid of CWalletTx default constructor * [wallet] Construct CWalletTx objects in CommitTransaction * qa: Cache only chain and wallet for regtest datadir * [rpc] createrawtransaction: Accept sorted outputs * CheckMinimalPush comments are prescriptive * Simplify Base32 and Base64 conversions * [gitian] Add kallewoof key for signing * [gitian] Re-order keys by owner first name alphabetic order * Add tests of listreceivedbyaddress address filtering * Add address filtering to listreceivedbyaddress * qt: Remove TransactionTableModel::TxIDRole * Generalize ConvertBits * qa: Fix some tests to work on native windows * Limit the number of IPs we use from each DNS seeder * depends: biplist 1.0.3 * Give hint about gitian not able to download * [tests] bind functional test nodes to 127.0.0.1 * p2wpkh, p2wsh and p2sh-nested scripts in decodescript * doc: Mention configure without wallet in FreeBSD instructions * net: Correct addrman logging * Add LookupBlockIndex function * Add documentation to PeerLogicValidation interface and related functions * Add missing cs_lock in CreateWalletFromFile * Fix cs_main lock in LoadExternalBlockFile * Lock cs_main while loading block index in AppInitMain * Assert cs_main is held when accessing mapBlockIndex * Add test-before-evict discipline to addrman * gui: Show messages as text not html * depends: Remove ccache * qt: Set modal overlay hide button as default * doc: SIGNER can contains space inside now. * test: Update trust git root * Add DynamicMemoryUsage() to LevelDB * Bugfix: RPC: Add missing UnregisterHTTPHandler for /wallet/ * Qt: Ensure UI updates only come from the currently selected walletView * Qt: Add a combobox to toolbar to select from multiple wallets * Qt: Load all wallets into WalletModels * depends: patch pthread_set_name_np out of zeromq * depends: zeromq 4.2.3 * [Depends] Fix Qt build with Xcode 9.2 * depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin * Shut down if trying to connect a corrupted block * Add a test for large tx output scripts with segwit input. * Create new wallet databases as directories rather than files * Allow wallet files not in -walletdir directory * Allow wallet files in multiple directories * Remove deprecated PyZMQ call from Python ZMQ example * docs: Update osx brew install instruction * Fix typos and cleanup * Fix ListCoins test failure due to unset g_wallet_allow_fallback_fee * Show a transaction's virtual size in its details dialog. * gitian-build.sh: fix signProg being recognized as two parameters * [qt] Improved "custom fee" explanation in tooltip * [qt] navigate to transaction history page after send * Consensus: Fix bug when compiler do not support __builtin_clz* * [script] lint-whitespace: improve print linenumber * Add tests for HexStr std::reverse_iterator cases * Add tests for HexStr corner cases * [test] Add tests for self usage in arith_uint256 * [arith_uint256] Do not destroy *this content if passed-in operator may reference it * Allow dustrelayfee to be set to zero * [arith_uint256] Avoid unnecessary this-copy using prefix operator * Remove redundant includes. Conform to header include guidelines. * Use memset() to optimize prevector::resize() * Reduce redundant code of prevector and speed it up * Add new prevector benchmarks. * fix version typo * Add build support for 'gprof' profiling. * [docs] Minor improvements to Compatibility Notes * test: Use wait_until to ensure ping goes out * Fix typos * doc: Add historical release notes for 0.16.0 * [Tests] Check output of parent/child tx list from getrawmempool, getmempooldescendants, getmempoolancestors, and REST interface * [RPC] Add list of child transactions to verbose output of getrawmempool * [QA] add wallet-rbf test * Disable wallet fallbackfee by default on mainnet * Avoid unintentional unsigned integer wraparounds in tests * rpc: Allow typeAny in RPCTypeCheck * Don't test against the mempool min fee information in mempool_limit.py * test: Plug memory leaks and stack-use-after-scope * createmultisig no longer takes addresses * Declare CMutableTransaction a struct in rawtransaction.h * [depends] Allow depends system to support armv7l * Bugfix: respect user defined configuration file (-conf) when open conf. file from QT settings * init: Remove translation for `-blockmaxsize` option help * [test] Round target fee to 8 decimals in assert_fee_amount * Split off key_io_tests from base58_tests * Split key_io (address/key encodings) off from base58 * Stop using CBase58Data for ext keys * Replace CBitcoinSecret with {Encode,Decode}Secret * qa: Fix python TypeError in script.py * docs: clarified systemd installation instructions in init.md for Ubuntu users. * Add test for signrawtransaction * scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests * Split signrawtransaction into wallet and non-wallet * Add setter for g_initial_block_download_completed * fixes #12465 added missing terminating newline character in log message * Revert "[tests] bind functional test nodes to 127.0.0.1" * Assert CPubKey::ValidLength to the pubkey's header-relevent size * [doc] dev-notes: Members should be initialized * test: Fix bip68 sequence test to reflect updated rpc error message * scripted-diff: validateaddress to getaddressinfo in tests * Create getaddressinfo RPC and deprecate parts of validateaddress * [rpc] Move DescribeAddressVisitor to rpc/util * Only call NotifyBlockTip when the active chain changes * [tests] Add a (failing) test for waitforblockheight * rpc: Interrupt block generation on shutdown request * test: Add missing signal.h header * [rpc] split wallet and non-wallet parts of DescribeAddressVisitor * gitian: bump descriptors for (0.)17 * travis: Full clone for git subtree check * qa: Improve getchaintxstats functional test * rpc: Refactor blockhash parse in getchaintxstats * devtools: Exclude patches from lint-whitespace * qa: Move common args to bitcoin.conf * Fix overly eager BIP30 bypass * test: Add unit test for LockDirectory * util: Fix multiple use of LockDirectory * fixme: depends: Add D_DARWIN_C_SOURCE to miniupnpc CFLAGS * [depends] latest config.guess and config.sub * [depends] miniupnpc 2.0.20180203 * [depends] ccache 3.4.1 * [depends] expat 2.2.5 * Fix typo in test_runner.py causing error * [qt] send: Clear All also resets coin control options * Make signrawtransaction accept P2SH-P2WSH redeemscripts * Update mac_alias to 2.0.7 * Delete mac_alias patch * [tests] Change invalidblockrequest to use BitcoinTestFramework * [tests] Fix flake8 warnings in invalidblockrequest * [test] Fix nits leftover from 11771 * qt: Initialize members in WalletModel * Remove useless string initialization. * Add some script tests related to BOOL ops and odd values like negative 0. * Fix rescan test failure due to unset g_address_type, g_change_type * fix possible shutdown assertion with -reindex-shutdown * Fix Windows build errors introduced in #10498 * Interrupt loading thread after shutdown request * Reset pblocktree before deleting LevelDB file * Fix a-vs-an typos * rpc: Reject deprecated reserveChangeKey in fundrawtransaction * Improve "Turn Windows Features On or Off" step * scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) * Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba * [scripts] gitian-builder.sh: fix --setup doc, LXC is default * [QA] add NODE_NETWORK_LIMITED address relay and sync test * [QA] fix mininode CAddress ser/deser * [QA] Allow addrman loopback tests (add debug option -addrmantest) * Connect to peers signaling NODE_NETWORK_LIMITED when out-of-IBD * Accept addresses with NODE_NETWORK_LIMITED flag * Fix ignoring tx data requests when fPauseSend is set on a peer * Refactor: One CBaseChainParams should be enough * boost: drop boost threads for [alert|block|wallet]notify * boost: drop boost threads from torcontrol * boost: remove useless threadGroup parameter from Discover * boost: drop boost threads for upnp * [wallet] Indent only change of CWallet::AvailableCoins * [wallet] Make CWallet::ListCoins atomic * Consistently use FormatStateMessage in RPC error output * Add test for 'mempool min fee not met' rpc error * Fix 'mempool min fee not met' debug output * [RPC] Remove deprecated addmultisigaddress return format * [RPC] Remove deprecated createmultisig object * [tests] Remove test for deprecated createmultsig option * qt: Poll ShutdownTimer after init is done * qt: Clarify some comments * qt: Make sure splash screen is freed on AppInitMain fail * http: Remove numThreads and ThreadCounter * Bech32 addresses in dumpwallet * Add gitian PGP key: akx20000 * Fix fast-shutdown crash if genesis block was not loaded * Fix fast-shutdown hang on ThreadImport+GenesisWait * Add braces to meet code style on line-after-the-one-changed. * http: Remove WaitExit from WorkQueue * http: Join worker threads before deleting work queue * Hold mempool.cs for the duration of ATMP. * add fivepiece key fingerprint * wallet: Disallow abandon of conflicted txes * [tests] Update README after filename change * Add AbsPathForConfigVal to consolidate datadir prefixing for path args * Clarify help messages for path args to mention datadir prefix * [rpc] Remove deprecated getmininginfo RPC option * [rpc] remove deprecated estimatefee RPC * Use ptrdiff_t type to more precisely indicate usage and avoid compiler warnings. * Extend #11583 to include the most common message generated by non-contributing peers (port scanners?) 37% of the log default log entries for a node that has been up for ~24hrs was "version handshake timeout..." * [tests] Remove estimatefee from rpc_deprecated.py test * [tests] Remove tests for deprecated estimatefee RPC * [tests] Fix style warnings in feature_fee_estimation.py * Document method for reviewers to verify chainTxData * Properly alphabetize output of CLI --help option. * [rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions * [gui] Defer coin control instancing * net: don't retry failed oneshot connections forever * net: initialize socket to avoid closing random fd's * Remove suggestion to make cloned repository world-writable for Windows build. * QA: segwit.py: s/find_unspent/find_spendable_utxo/ * doc: Explain how to update chainTxData in release process * contrib: Add support for out-of-tree builds in gen-manpages.sh * Fix missing cs_main lock for GuessVerificationProgress() * Organise Linux build instructions to be categorised by distro * Add NetBSD build instruction links * test: Make ua_comment test pass on 0.16.0 * [tests] Change invalidtxrequest to use BitcoinTestFramework * [tests] Fix flake8 warnings in invalidtxrequest * [tests] Add P2PDataStore class * doc: Update manpages to 0.16.99 * build: Bump version to 0.16.99 * [tests] Require all tests to follow naming convention * Refactor HaveKeys to early return on false result * feebumper: Use PreconditionChecks to determine bump eligibility * Enable flake8 warnings for all currently non-violated rules * tests: Fix accidental redefinition of previously defined variable via list comprehension * Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812) * [net] add seed.bitcoin.sprovoost.nl to DNS seeds * [tests] Reduce NodeConn connection logging from info to debug * Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) * Fix typos * Avoid leaking prioritization information when relaying transactions * fee estimator: avoid sorting mempool on shutdown * Build: Add a makefile target for Doxygen documentation * qa: Prepare functional tests for Windows * [Trivial] link mentioned scripted-diff-commit * net: Move misbehaving logging to net logging category * move more bumpfee prechecks to feebumper::PreconditionChecks * Correct mempool mapTx comment * [tests] bind functional test nodes to 127.0.0.1 * Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code. * [scripts] lint-whitespace: check last N commits or unstaged changes * fix nits: variable naming, typos * [scripts] lint-whitespace: use perl instead of grep -P * [qt] Add support to search the address book * Implements a virtual destructor on the BaseRequestHandler class. * Use best-fit strategy in Arena, now O(log(n)) instead O(n) * [Doc] Clarify the meaning of fee delta not being a fee rate in prioritisetransaction RPC * Improve readability by removing redundant casts to same type (on all platforms) * clientversion: Use full commit hash for commit-based version descriptions * [docs] initial QT documentation, move Qt Creator instructions * contrib: Remove xpired 522739F6 key * contrib: Replace developer keys with list of pgp fingerprints * Use std::thread::hardware_concurrency, instead of Boost, to determine available cores * simplify CheckMinimalPush checks, add safety assert * Drop extra script variable in ProduceSignature * Stop special-casing phashBlock handling in validation for TBV * Do not un-mark fInMempool on wallet txn if ATMP fails. * Remove redundant locks * During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after * Use static_cast instead of C-style casts for non-fundamental types ------------------------------------------------------------------- Wed Sep 19 19:21:31 UTC 2018 - marec@detebe.org - Update to version 0.16.3: * Monacoin: 0.16.3 release notes * Monacoin: Bump version to 0.16.3 * Fix crash bug with duplicate inputs within a transaction * Monacoin: Update Qt translations * Monacoin: fix build script * Monacoin: fix wrong comparison * Monacoin: Add sub alert key * Monacoin: normal-alert can't cancel alert-command * Monacoin: Bump date in man pages * -prune option -help output aligned with code ------------------------------------------------------------------- Sun Sep 2 17:25:58 UTC 2018 - marec@detebe.org - Update to version 0.16.2: * Monacoin: fix build script * Monacoin: fix wrong comparison * Monacoin: Add sub alert key * Monacoin: normal-alert can't cancel alert-command * Monacoin: Bump date in man pages * -prune option -help output aligned with code * bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes * [tests] Check signrawtransaction* errors on missing prevtx info * Error on missing amount in signrawtransaction* * Monacoin: Improved alert-cmd and add copyright ------------------------------------------------------------------- Wed Apr 11 19:10:04 UTC 2018 - marec@detebe.org - Update to version 0.15.1: * Monacoin: update regtest params * Monacoin: fix download url * Monacoin: Minor changes for 0.15 * Litecoin: Disable RBF UI * Monacoin: Add monacoinproject-key.pgp * Monacoin: Update copyright * Monacoin: Update release-notes * Monacoin: Automatic Wallet Backup * Monacoin: Update splashscreen and icon * Monacoin: Disable tests ------------------------------------------------------------------- Mon Dec 4 20:43:11 UTC 2017 - marec@detebe.org - initial package build
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor
