File 0002-icE1usb-Fix-inverted-logic-for-clock-timin... of Package dahdi-linux

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-icE1usb-Fix-inverted-logic-for-clock-timing-source.patch of Package dahdi-linux (Revision f87ff277df9e70447a7dd124c6939659)

Currently displaying revision f87ff277df9e70447a7dd124c6939659 , Show latest

From ad31fbd8b40f17cf27395022d7bdc2c31b27bfb3 Mon Sep 17 00:00:00 2001
From: Harald Welte <laforge@osmocom.org>
Date: Wed, 20 Apr 2022 09:23:19 +0200
Subject: [PATCH 2/6] icE1usb: Fix inverted logic for clock timing source

The 'struct dahdi_lineconfig.sync' parameter originates from the
'timing' field of system.conf.  dahdi_cfg passes it via the SPANCONFIG
ioctl into the kernel.

The DAHDI docs say:
> source of the master clock. If you choose 0, the port will never
> be used as a source of timing. This is appropriate when you know the
> far end should always be a slave to you.

So if '0' we should use the local clock, and if > 0, the recovered
remote clock.

Thanks to Christoph Lauter for pointing this out.

Change-Id: If35a5a52c094129c342d0f658f496b488d1826ad
---
 drivers/dahdi/icE1usb/icE1usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c
index e829b2d..7ab751e 100644
--- a/drivers/dahdi/icE1usb/icE1usb.c
+++ b/drivers/dahdi/icE1usb/icE1usb.c
@@ -691,9 +691,9 @@ static int e1u_d_spanconfig(struct file *file, struct dahdi_span *span,
 		ieu->cfg.tx.mode = ICE1USB_TX_MODE_TS0;
 
 	if (lc->sync > 0)
-		ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_LOCAL;
-	else
 		ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_REMOTE;
+	else
+		ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_LOCAL;
 
 	/* (re-)set to sane defaults */
 	ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_OFF;
-- 
2.36.0

Places

File 0002-icE1usb-Fix-inverted-logic-for-clock-timing-source.patch of Package dahdi-linux (Revision f87ff277df9e70447a7dd124c6939659)

Places