File 0003-wcte13xp-Fix-unintended-fall-through-in-t1... of Package dahdi-linux

Overview Repositories Revisions Requests Users Attributes Meta

File 0003-wcte13xp-Fix-unintended-fall-through-in-t13x_set_lin.patch of Package dahdi-linux (Revision e1e7a8761fd5c39f13c975f986c7b0c9)

Currently displaying revision e1e7a8761fd5c39f13c975f986c7b0c9 , Show latest

From ac300cd895160c8d292e1079d6bf95af5ab23874 Mon Sep 17 00:00:00 2001
From: Shaun Ruffell <sruffell@sruffell.net>
Date: Tue, 24 Sep 2019 20:18:31 -0500
Subject: [PATCH 03/12] wcte13xp: Fix unintended fall through in
 t13x_set_linemode for J1

Found by GCC with -Wimplicit-fallthrough.

Also fix the log message to report that the mode was switched to J1 mode.

Signed-off-by: Shaun Ruffell <sruffell@sruffell.net>
---
 drivers/dahdi/wcte13xp-base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c
index b5f8043..9adc4d4 100644
--- a/drivers/dahdi/wcte13xp-base.c
+++ b/drivers/dahdi/wcte13xp-base.c
@@ -1872,9 +1872,10 @@ static int t13x_set_linemode(struct dahdi_span *span, enum spantypes linemode)
 		break;
 	case SPANTYPE_DIGITAL_J1:
 		dev_info(&wc->xb.pdev->dev,
-			 "Changing from %s to E1 line mode.\n",
+			 "Changing from %s to J1 line mode.\n",
 			 dahdi_spantype2str(wc->span.spantype));
 		res = t13x_software_init(wc, J1);
+		break;
 	default:
 		dev_err(&wc->xb.pdev->dev,
 			"Got invalid linemode '%s' from dahdi\n",
-- 
2.29.2

Places

File 0003-wcte13xp-Fix-unintended-fall-through-in-t13x_set_lin.patch of Package dahdi-linux (Revision e1e7a8761fd5c39f13c975f986c7b0c9)

Places