File 0006-dahdi-sysfs-chan-Fix-potential-NULL-pointe... of Package dahdi-linux

Overview Repositories Revisions Requests Users Attributes Meta

File 0006-dahdi-sysfs-chan-Fix-potential-NULL-pointer-deref.patch of Package dahdi-linux (Revision f87ff277df9e70447a7dd124c6939659)

Currently displaying revision f87ff277df9e70447a7dd124c6939659 , Show latest

From 61b449a1535e35fd9ee83ec9679fd1ca2752c7bc Mon Sep 17 00:00:00 2001
From: Harald Welte <laforge@osmocom.org>
Date: Sun, 24 Apr 2022 19:41:42 +0200
Subject: [PATCH 6/6] dahdi-sysfs-chan: Fix potential NULL pointer deref
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Sometimes it is useful to look at compiler warnings:

dahdi-sysfs-chan.c:384:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]

And indeed, we could have de-referenced a NULL pointer here.

Change-Id: I4274e7a92ca6ee7e92c6adb713fb89ffe31b4c72
---
 drivers/dahdi/dahdi-sysfs-chan.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dahdi/dahdi-sysfs-chan.c b/drivers/dahdi/dahdi-sysfs-chan.c
index a91e6ed..8682ea3 100644
--- a/drivers/dahdi/dahdi-sysfs-chan.c
+++ b/drivers/dahdi/dahdi-sysfs-chan.c
@@ -381,10 +381,11 @@ static void fixed_devfiles_remove(void)
 		return;
 	for (i = 0; i < ARRAY_SIZE(fixed_minors); i++) {
 		void *d = fixed_minors[i].dev;
-		if (d && !IS_ERR(d))
+		if (d && !IS_ERR(d)) {
 			dahdi_dbg(DEVICES, "Removing fixed device file %s\n",
 				fixed_minors[i].name);
 			DEL_DAHDI_DEV(fixed_minors[i].minor);
+		}
 	}
 }
 
-- 
2.36.0

Places

File 0006-dahdi-sysfs-chan-Fix-potential-NULL-pointer-deref.patch of Package dahdi-linux (Revision f87ff277df9e70447a7dd124c6939659)

Places