File alsa-utils-alsactl-tlv-comment-fix.diff of Package alsa-utils

Overview Repositories Revisions Requests Users Attributes Meta

File alsa-utils-alsactl-tlv-comment-fix.diff of Package alsa-utils (Revision 88b57bc086f159cd993375fd1f1cc24c)

Currently displaying revision 88b57bc086f159cd993375fd1f1cc24c , Show latest

# HG changeset patch
# User tiwai
# Date 1194884667 -3600
# Node ID 40051fabcab00bd4fcfab41e11b609acf32a6a22
# Parent  19947765f0332b66b5eabab06929f0bbe2061749
alsactl - fix double entry of comment.tlv

The entry comment.tlv can be doubly written via alsactl store, and this
results in an error.  I forgot to remove the old code...

diff -r 19947765f033 -r 40051fabcab0 alsactl/state.c
--- a/alsactl/state.c	Mon Nov 05 12:44:13 2007 +0100
+++ b/alsactl/state.c	Mon Nov 12 17:24:27 2007 +0100
@@ -330,22 +330,6 @@ static int get_control(snd_ctl_t *handle
 			if (err < 0)
 				return err;
 		}
-		if (snd_ctl_elem_info_is_tlv_readable(info)) {
-			unsigned int tlv[MAX_USER_TLV_SIZE];
-			err = snd_ctl_elem_tlv_read(handle, id, tlv, sizeof(tlv));
-			if (err >= 0) {
-				char *s = tlv_to_str(tlv);
-				if (s) {
-					err = snd_config_string_add(comment, "tlv", s);
-					if (err < 0) {
-						error("snd_config_string_add: %s", snd_strerror(err));
-						return err;
-					}
-					free(s);
-				}
-			}
-		}
-		    
 		break;
 	}
 	case SND_CTL_ELEM_TYPE_INTEGER64:

Places

File alsa-utils-alsactl-tlv-comment-fix.diff of Package alsa-utils (Revision 88b57bc086f159cd993375fd1f1cc24c)

Places