File 0002-kerneloops-applet-fix-string-handling-make... of Package kerneloops

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-kerneloops-applet-fix-string-handling-make-window.patch of Package kerneloops (Revision 5091790bee37b030c925660313c49e35)

Currently displaying revision 5091790bee37b030c925660313c49e35 , Show latest

From edc622c1e6dc60cc1abeab6af2f40100eddbd078 Mon Sep 17 00:00:00 2001
From: Brandon Philips <brandon@ifup.org>
Date: Thu, 7 Aug 2008 18:51:39 -0700
Subject: [PATCH] kerneloops-applet: fix string handling, make window scrollable

- Strings weren't being properly terminated
- Make the window scrollable with pageup/pagedown by using native scrolling of
  the TextView
- Fix up some minor whitespace issues

Signed-off-by: Brandon Philips <bphilips@suse.de>
---
 kerneloops-applet.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/kerneloops-applet.c b/kerneloops-applet.c
index 0497f9d..ea3a122 100644
--- a/kerneloops-applet.c
+++ b/kerneloops-applet.c
@@ -172,12 +172,13 @@ static void detail_action(NotifyNotification __unused *notify,
 	detail_data = malloc(statb.st_size+1);
 	if (!detail_data)
 		return;
-	
+
 	if (read(detail_fd, detail_data, statb.st_size) != statb.st_size) {
 		free(detail_data);
 		return;
 	}
 	close(detail_fd);
+	detail_data[statb.st_size] = '\0';
 
 	dialog = gtk_dialog_new();
 	gtk_window_set_title(GTK_WINDOW(dialog), _("Kernel failure details"));
@@ -192,8 +193,8 @@ static void detail_action(NotifyNotification __unused *notify,
 	buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW (view));
 	gtk_text_buffer_set_text(buffer, detail_data, -1);
 	free(detail_data);
-	gtk_scrolled_window_add_with_viewport(
-		GTK_SCROLLED_WINDOW(scrollwindow), view);
+	gtk_container_add (GTK_CONTAINER (scrollwindow), view);
+
 	gtk_text_view_set_editable(GTK_TEXT_VIEW(view), FALSE);
 	button_send = gtk_button_new_with_label (_("Send"));
 	GTK_WIDGET_SET_FLAGS(button_send, GTK_CAN_DEFAULT);
@@ -210,7 +211,7 @@ static void detail_action(NotifyNotification __unused *notify,
 			 G_OBJECT(dialog));
 	g_signal_connect(G_OBJECT(button_send), "clicked",
 			 G_CALLBACK(send_action), NULL);
-  
+
 	gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->action_area),
 		button_send, TRUE, TRUE, 0);
 	gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->action_area),
-- 
1.5.6

Places

File 0002-kerneloops-applet-fix-string-handling-make-window.patch of Package kerneloops (Revision 5091790bee37b030c925660313c49e35)

Places