File lam-7.1.2_strncat_usage.patch of Package lam

Overview Repositories Revisions Requests Users Attributes Meta

File lam-7.1.2_strncat_usage.patch of Package lam (Revision affa3526d9f1e9ddd954108009031f22)

Currently displaying revision affa3526d9f1e9ddd954108009031f22 , Show latest

ERROR: Program might be overflowing a buffer in strncat. Common mistake:
ERROR: BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it takes the left over size as 3rd argument
ERROR: GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1)
ERROR: Please investigate and fix.
Problematic file(s) and their linenumbers:
  ssi_boot_globus_inetexec.c: 106

Index: share/ssi/boot/globus/src/ssi_boot_globus_inetexec.c
===================================================================
--- share/ssi/boot/globus/src/ssi_boot_globus_inetexec.c.orig	2006-02-24 00:27:11.000000000 +0100
+++ share/ssi/boot/globus/src/ssi_boot_globus_inetexec.c	2007-01-23 18:39:30.287941813 +0100
@@ -103,8 +103,8 @@ lam_ssi_boot_globus_inetexec(struct lamn
 
   printable[0] = '\0';
   for (i = 0; i < cmdc; i++) {
-    strncat(printable, cmdv[i], BUFSIZ);
-    strncat(printable, " ", BUFSIZ);
+    strncat(printable, cmdv[i], (sizeof(printable) - strlen(printable) - 1));
+    strncat(printable, " ", (sizeof(printable) - strlen(printable) - 1));
   }
 
   cmdv0 = strdup(cmdv[0]);

Places

File lam-7.1.2_strncat_usage.patch of Package lam (Revision affa3526d9f1e9ddd954108009031f22)

Places