File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui

Overview Repositories Revisions Requests Users Attributes Meta

File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui (Revision b387cdac14b568c0be5319e3ab216b8c)

Currently displaying revision b387cdac14b568c0be5319e3ab216b8c , Show latest

2006-03-31  Federico Mena Quintero  <federico@novell.com>

* file-chooser/gtkfilesystemgnomevfs.c
	(gtk_file_system_gnome_vfs_list_volumes): List only
	user-visible unmounted drives, not all drives.  Conversely,
	list *all* mounted volumes, not just the ones that don't have
	a corresponding drive.  Fixes the libgnomeui part of bug
	http://bugzilla.gnome.org/show_bug.cgi?id=321320

--- file-chooser/gtkfilesystemgnomevfs.c.orig	2007-02-16 21:39:37.042088000 +0100
+++ file-chooser/gtkfilesystemgnomevfs.c	2007-02-16 21:45:18.234550000 +0100
@@ -662,42 +662,39 @@
 
   result = NULL;
 
-  /* User-visible drives */
+  /* User-visible drives which don't have mounted volumes  */
 
   list = gnome_vfs_volume_monitor_get_connected_drives (system_vfs->volume_monitor);
   list = g_list_sort (list, (GCompareFunc) gnome_vfs_drive_compare);
   for (l = list; l; l = l->next)
     {
       drive = GNOME_VFS_DRIVE (l->data);
-
-      if (gnome_vfs_drive_is_user_visible (drive))
-	result = g_slist_prepend (result, drive);
+      
+      if (gnome_vfs_drive_is_user_visible (drive)
+          && !gnome_vfs_drive_is_mounted (drive))
+          result = g_slist_prepend (result, drive);
       else
-	gnome_vfs_drive_unref (drive);
+          gnome_vfs_drive_unref (drive);
     }
 
   g_list_free (list);
 
-  /* User-visible volumes with no corresponding drives */
+  /* User-visible volumes */
 
   list = gnome_vfs_volume_monitor_get_mounted_volumes (system_vfs->volume_monitor);
   list = g_list_sort (list, (GCompareFunc) gnome_vfs_volume_compare);
   for (l = list; l; l = l->next)
     {
       volume = GNOME_VFS_VOLUME (l->data);
-      drive = gnome_vfs_volume_get_drive (volume);
-
-      if (!drive && gnome_vfs_volume_is_user_visible (volume))
-	{
-	  gnome_vfs_drive_unref (drive);
-	  result = g_slist_prepend (result, volume);
-	}
+      if (gnome_vfs_volume_is_user_visible (volume))
+        {
+          result = g_slist_prepend (result, volume);
+        }
       else
-	{
-	  gnome_vfs_drive_unref (drive);
-	  gnome_vfs_volume_unref (volume);
-	}
-    }
+        {
+          gnome_vfs_volume_unref (volume);
+        }
+     }
 
   g_list_free (list);

Places

File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui (Revision b387cdac14b568c0be5319e3ab216b8c)

Places