File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui

Overview Repositories Revisions Requests Users Attributes Meta

File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui (Revision bac9714a7a0e319560d349f0b9c2f697)

Currently displaying revision bac9714a7a0e319560d349f0b9c2f697 , Show latest

2006-03-31  Federico Mena Quintero  <federico@novell.com>

* file-chooser/gtkfilesystemgnomevfs.c
	(gtk_file_system_gnome_vfs_list_volumes): List only
	user-visible unmounted drives, not all drives.  Conversely,
	list *all* mounted volumes, not just the ones that don't have
	a corresponding drive.  Fixes the libgnomeui part of bug
	http://bugzilla.gnome.org/show_bug.cgi?id=321320

Index: file-chooser/gtkfilesystemgnomevfs.c
===================================================================
--- file-chooser/gtkfilesystemgnomevfs.c.orig
+++ file-chooser/gtkfilesystemgnomevfs.c
@@ -662,7 +662,7 @@ gtk_file_system_gnome_vfs_list_volumes (
 
   result = NULL;
 
-  /* User-visible drives */
+  /* User-visible drives which don't have mounted volumes  */
 
   list = gnome_vfs_volume_monitor_get_connected_drives (system_vfs->volume_monitor);
   list = g_list_sort (list, (GCompareFunc) gnome_vfs_drive_compare);
@@ -670,10 +670,11 @@ gtk_file_system_gnome_vfs_list_volumes (
     {
       drive = GNOME_VFS_DRIVE (l->data);
 
-      if (gnome_vfs_drive_is_user_visible (drive))
-	result = g_slist_prepend (result, drive);
+      if (gnome_vfs_drive_is_user_visible (drive)
+          && !gnome_vfs_drive_is_mounted (drive))
+          result = g_slist_prepend (result, drive);
       else
-	gnome_vfs_drive_unref (drive);
+          gnome_vfs_drive_unref (drive);
     }
 
   g_list_free (list);

Places

File libgnomeui-155010-filechooser-show-drives.diff of Package libgnomeui (Revision bac9714a7a0e319560d349f0b9c2f697)

Places