File openssh-5.2p1-blocksigalrm.diff of Package openssh

Overview Repositories Revisions Requests Users Attributes Meta

File openssh-5.2p1-blocksigalrm.diff of Package openssh (Revision 52fbecac9606e3839c78904e7add5624)

Currently displaying revision 52fbecac9606e3839c78904e7add5624 , Show latest

--- log.c
+++ log.c
@@ -51,6 +51,7 @@
 
 #include "xmalloc.h"
 #include "log.h"
+#include <signal.h>
 
 static LogLevel log_level = SYSLOG_LEVEL_INFO;
 static int log_on_stderr = 1;
@@ -336,6 +337,7 @@
 	char fmtbuf[MSGBUFSIZ];
 	char *txt = NULL;
 	int pri = LOG_INFO;
+	sigset_t nset, oset;
 	int saved_errno = errno;
 
 	if (level > log_level)
@@ -387,6 +389,14 @@
 		snprintf(msgbuf, sizeof msgbuf, "%s\r\n", fmtbuf);
 		write(STDERR_FILENO, msgbuf, strlen(msgbuf));
 	} else {
+		/* Prevent a race between the grace_alarm
+		* which writes a log message and terminates
+		* and main sshd code that leads to deadlock 
+		* as syslog is not async safe.
+		*/ 
+		sigemptyset(&nset);
+		sigaddset(&nset, SIGALRM);
+		sigprocmask(SIG_BLOCK, &nset, &oset);
 #if defined(HAVE_OPENLOG_R) && defined(SYSLOG_DATA_INIT)
 		openlog_r(argv0 ? argv0 : __progname, LOG_PID, log_facility, &sdata);
 		syslog_r(pri, &sdata, "%.500s", fmtbuf);
@@ -396,6 +406,7 @@
 		syslog(pri, "%.500s", fmtbuf);
 		closelog();
 #endif
+		sigprocmask(SIG_SETMASK, &oset, NULL);
 	}
 	errno = saved_errno;
 }

Places

File openssh-5.2p1-blocksigalrm.diff of Package openssh (Revision 52fbecac9606e3839c78904e7add5624)

Places