File invalid-filerequires.diff of Package rpmlint

Overview Repositories Revisions Requests Users Attributes Meta

File invalid-filerequires.diff of Package rpmlint (Revision f3b1e372af6679d9134c132ef3273f0c)

Currently displaying revision f3b1e372af6679d9134c132ef3273f0c , Show latest

Index: TagsCheck.py
===================================================================
--- TagsCheck.py.orig
+++ TagsCheck.py
@@ -402,6 +402,7 @@ invalid_version_regex = re.compile('([0-
 # () are here for grouping purpose in the regexp
 forbidden_words_regex = re.compile('(' + Config.getOption('ForbiddenWords') + ')', re.IGNORECASE)
 valid_buildhost_regex = re.compile(Config.getOption('ValidBuildHost'))
+valid_filedep_regex=re.compile('(?:/s?bin/|^/etc/|^/usr/lib/sendmail$)')
 epoch_regex = re.compile('^[0-9]+:')
 use_epoch = Config.getOption('UseEpoch', False)
 use_utf8 = Config.getOption('UseUTF8', Config.USEUTF8_DEFAULT)
@@ -484,6 +485,9 @@ class TagsCheck(AbstractCheck.AbstractCh
             if d[0].startswith('/usr/local/'):
                 printError(pkg, 'invalid-dependency', d[0])
 
+            if d[0].startswith('/') and not valid_filedep_regex.search(d[0]):
+                printWarning(pkg, 'invalid-filepath-dependency', d[0])
+
             if not devel_depend and not is_devel and not is_source:
                 if FilesCheck.devel_regex.search(d[0]):
                     printError(pkg, 'devel-dependency', d[0])
@@ -902,6 +906,12 @@ explicit Requires: tags.''',
 '''This package provides 2 times the same capacity. It should only provide it
 once.''',
 
+'invalid-filepath-dependency',
+'''A package has a file or path based dependency that is not resolveable for
+package solvers because it is not in the whitelist for path based dependencies
+and therefore not available in repository metadata. Please use a symbolic requires
+instead or require a file in bin or /etc.''',
+
 'tag-not-utf8',
 '''The character encoding of the value of this tag is not UTF-8.''',

Places

File invalid-filerequires.diff of Package rpmlint (Revision f3b1e372af6679d9134c132ef3273f0c)

Places