File suse-binarieschecks.diff of Package rpmlint

Overview Repositories Revisions Requests Users Attributes Meta

File suse-binarieschecks.diff of Package rpmlint (Revision f31384ad3fb947a1571edeb054b87b11)

Currently displaying revision f31384ad3fb947a1571edeb054b87b11 , Show latest

--- BinariesCheck.py
+++ BinariesCheck.py
@@ -37,6 +37,9 @@
     unused_regex = re.compile('^\s+(\S+)')
     exit_call_regex = re.compile('\s+FUNC\s+.*?\s+(_?exit(?:@\S+)?)(?:\s|$)')
     fork_call_regex = re.compile('\s+FUNC\s+.*?\s+(fork(?:@\S+)?)(?:\s|$)')
+    debuginfo_regex=re.compile('^\s+\[\s*\d+\]\s+\.debug_.*\s+')
+    symtab_regex=re.compile('^\s+\[\s*\d+\]\s+\.symtab\s+')
+    gethostbyname_call_regex = re.compile('\s+FUNC\s+.*?\s+(gethostbyname(?:@\S+)?)(?:\s|$)')
 
     def __init__(self, pkg, path, file, is_ar, is_shlib):
         self.readelf_error = False
@@ -50,7 +53,10 @@
         self.stack = False
         self.exec_stack = False
         self.exit_calls = []
+        self.calls_gethostbyname = False
         fork_called = False
+        self.debuginfo = 0
+        self.symtab=0
         self.tail = ''
 
         is_debug = path.endswith('.debug')
@@ -93,6 +99,11 @@
                         self.exec_stack = True
                     continue
 
+                r = BinaryInfo.gethostbyname_call_regex.search(l)
+                if r:
+                    self.calls_gethostbyname = True
+                    continue
+
                 if is_shlib:
                     r = BinaryInfo.exit_call_regex.search(l)
                     if r:
@@ -103,6 +114,14 @@
                         fork_called = True
                         continue
 
+                if BinaryInfo.debuginfo_regex.search(l):
+                    self.debuginfo=1
+                    continue
+
+                if BinaryInfo.symtab_regex.search(l):
+                    self.symtab=1
+                    continue
+
             if self.non_pic:
                 self.non_pic = 'TEXTREL' in res[1]
 
@@ -259,6 +278,17 @@
                         bin_info = BinaryInfo(
                             pkg, pkgfile.path, fname, is_ar, is_shlib)
 
+                        # stripped static library
+                        if is_ar:
+                            if bin_info.readelf_error:
+                                pass
+                            elif not bin_info.symtab:
+                                printError(pkg, 'static-library-without-symtab', fname)
+                            elif not bin_info.debuginfo and \
+                                    (os.environ.get('BUILD_IS_RUNNING', None) == None or \
+                                         os.environ.get('BUILD_DEBUG_FLAGS','').find('-g') != -1):
+                                printWarning(pkg, 'static-library-without-debuginfo', fname)
+
                         # so name in library
                         if is_shlib:
                             has_lib = True
@@ -294,6 +324,10 @@
                                 printError(
                                     pkg, 'shlib-with-non-pic-code', fname)
 
+                        # gethostbyname ? 
+                        if bin_info.calls_gethostbyname:
+                            printError(pkg, 'binary-or-shlib-calls-gethostbyname', fname)
+
                         # rpath ?
                         if bin_info.rpath:
                             for p in bin_info.rpath:
@@ -509,6 +543,14 @@
 'ldd-failed',
 '''Executing ldd on this file failed, all checks could not be run.''',
 
+'static-library-without-symtab',
+'''The static library doesn't contain any symbols and therefore can't be linked
+against. This may indicated that it was strip.''',
+
+'static-library-without-debuginfo',
+'''The static library doesn't contain any debuginfo. Binaries linking against
+this static library can't be properly debugged.''',
+
 'executable-stack',
 '''The binary declares the stack as executable.  Executable stack is usually an
 error as it is only needed if the code contains GCC trampolines or similar
@@ -521,6 +563,10 @@
 make the stack executable.  Usual suspects include use of a non-GNU linker or
 an old GNU linker version.''',
 
+'binary-or-shlib-calls-gethostbyname',
+'''The binary calls gethostbyname(). Please port the code to use
+getaddrinfo().''',
+
 'shared-lib-calls-exit',
 '''This library package calls exit() or _exit(), probably in a non-fork()
 context. Doing so from a library is strongly discouraged - when a library

Places

File suse-binarieschecks.diff of Package rpmlint (Revision f31384ad3fb947a1571edeb054b87b11)

Places