File suse-hide-unstripped-outside-build.diff of Package rpmlint

Overview Repositories Revisions Requests Users Attributes Meta

File suse-hide-unstripped-outside-build.diff of Package rpmlint (Revision 3bc29b1e0fda0a07aa54040193905eaa)

Currently displaying revision 3bc29b1e0fda0a07aa54040193905eaa , Show latest

Index: BinariesCheck.py
===================================================================
--- BinariesCheck.py.orig
+++ BinariesCheck.py
@@ -10,6 +10,7 @@
 
 import re
 import stat
+import os
 
 import rpm
 
@@ -284,7 +285,9 @@ class BinariesCheck(AbstractCheck.Abstra
                 continue
 
             # stripped ?
-            if 'not stripped' in pkgfile.magic:
+            if 'not stripped' in pkgfile.magic and \
+               (os.environ.get('BUILD_DIR', '') == '' or
+               os.environ.get('BUILD_DEBUG', '') != ''):
                 printWarning(pkg, 'unstripped-binary-or-object', fname)
 
             # inspect binary file
@@ -581,6 +584,12 @@ form, make sure that rpmbuild does not s
 that use prelink, make sure that prelink does not strip it either, usually by
 placing a blacklist file in /etc/prelink.conf.d.  For more information, see
 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256900#49''',
+
+'unstripped-binary-or-object',
+'''stripping debug info from binaries happens automatically according to global
+project settings. So there's normally no need to manually strip binaries.
+Left over unstripped binaries could therefore indicate a bug in the automatic
+stripping process.''',
 )
 
 # BinariesCheck.py ends here

Places

File suse-hide-unstripped-outside-build.diff of Package rpmlint (Revision 3bc29b1e0fda0a07aa54040193905eaa)

Places