File kvm-qemu-preXX-vnc-fix-a-memory-leak-in-threade... of Package kvm

Overview Repositories Revisions Requests Users Attributes Meta

File kvm-qemu-preXX-vnc-fix-a-memory-leak-in-threaded-vnc-serv.patch of Package kvm (Revision 59c83d47760c02d2eb55590bdd345484)

Currently displaying revision 59c83d47760c02d2eb55590bdd345484 , Show latest

From c53af37f375ce9c4999ff451c51173bdc1167e67 Mon Sep 17 00:00:00 2001
From: Corentin Chary <corentincj@iksaif.net>
Date: Fri, 25 Feb 2011 22:54:53 +0100
Subject: [PATCH] vnc: fix a memory leak in threaded vnc server

VncJobQueue's buffer is intended to be used for
as the output buffer for all operations in this queue,
but unfortunatly.

vnc_async_encoding_start() is in charge of setting this
buffer as the current output buffer, but
vnc_async_encoding_end() was not writting the changes back
to VncJobQueue, resulting in a big and ugly memleak.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 ui/vnc-jobs-async.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Index: qemu-kvm-0.14.0/ui/vnc-jobs-async.c
===================================================================
--- qemu-kvm-0.14.0.orig/ui/vnc-jobs-async.c
+++ qemu-kvm-0.14.0/ui/vnc-jobs-async.c
@@ -182,6 +182,7 @@ static void vnc_async_encoding_end(VncSt
     orig->tight = local->tight;
     orig->zlib = local->zlib;
     orig->hextile = local->hextile;
+    queue->buffer = local->output;
 }
 
 static int vnc_worker_thread_loop(VncJobQueue *queue)

Places

File kvm-qemu-preXX-vnc-fix-a-memory-leak-in-threaded-vnc-serv.patch of Package kvm (Revision 59c83d47760c02d2eb55590bdd345484)

Places