Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
openSUSE:12.2
FastCGI
FastCGI-fix_deprecated_api.patch
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File FastCGI-fix_deprecated_api.patch of Package FastCGI
From: Florian Ragwitz <rafl@debian.org> Date: Sat, 24 Sep 2011 07:54:33 +0000 (+0200) Subject: Stop leaking information across requests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=catagits%2Ffcgi2.git;a=commitdiff_plain;h=297693dc8362d25bb25e473899c72508a0f71d2e Stop leaking information across requests %hash is false if the hash hasn't been assigned to, *or* if the hash is simply empty. This causes the environment from the *second* request (that is, the environment produced by the first request) to be saved as default if the first request had empty environment. This way, request after the first can get access to credentials set up by the first request. Instead of fixing this, I'd much rather remove this old and buggy interface. However, 10 years of deprecation don't seem to have been enough for CGI::Fast to switch to the new and properly supported interface. :-( This is CVE-2011-2766. --- Index: perl/FCGI.PL =================================================================== --- perl/FCGI.PL.orig 2002-12-15 21:02:48.000000000 +0100 +++ perl/FCGI.PL 2011-12-12 11:24:08.885998082 +0100 @@ -291,14 +291,14 @@ sub Request(;***$*$) { sub accept() { warn "accept called as a method; you probably wanted to call Accept" if @_; - if (defined %FCGI::ENV) { - %ENV = %FCGI::ENV; + if ( defined($FCGI::ENV) ) { + %ENV = %$FCGI::ENV; } else { - %FCGI::ENV = %ENV; + $FCGI::ENV = {%ENV}; } my $rc = Accept($global_request); - for (keys %FCGI::ENV) { - $ENV{$_} = $FCGI::ENV{$_} unless exists $ENV{$_}; + for (keys %$FCGI::ENV) { + $ENV{$_} = $FCGI::ENV->{$_} unless exists $ENV{$_}; } # not SFIO @@ -310,7 +310,7 @@ sub accept() { sub finish() { warn "finish called as a method; you probably wanted to call Finish" if @_; - %ENV = %FCGI::ENV if (defined %FCGI::ENV); + %ENV = %$FCGI::ENV if defined($FCGI::ENV); # not SFIO if (tied (*STDIN)) {
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor