File 0024-libudev-queue.c-simplified-open_queue_file... of Package udev

Overview Repositories Revisions Requests Users Attributes Meta

File 0024-libudev-queue.c-simplified-open_queue_file.patch of Package udev (Revision 3472ad684a35e2c19469b54271f049b8)

Currently displaying revision 3472ad684a35e2c19469b54271f049b8 , Show latest

From a267bebf464cbb339d3411370f2e984dfc063567 Mon Sep 17 00:00:00 2001
From: Arvydas Sidorenko <asido4@gmail.com>
Date: Tue, 31 Jul 2012 11:38:08 +0200
Subject: [PATCH] libudev-queue.c: simplified open_queue_file

There is no apparent justification for using util_strscpyl
on the filename since it's a plain hardcoded path.
Older versions used:
util_strscpyl(filename, sizeof(filename), SOME_DIR, "/queue.bin", NULL);
and when changed nobody bothered to simplify it.

Index: udev-182/src/libudev-queue.c
===================================================================
--- udev-182.orig/src/libudev-queue.c
+++ udev-182/src/libudev-queue.c
@@ -208,11 +208,9 @@ ssize_t udev_queue_read_devpath(FILE *qu
 
 static FILE *open_queue_file(struct udev_queue *udev_queue, unsigned long long int *seqnum_start)
 {
-        char filename[UTIL_PATH_SIZE];
         FILE *queue_file;
 
-        util_strscpyl(filename, sizeof(filename), udev_get_run_path(udev_queue->udev), "/queue.bin", NULL);
-        queue_file = fopen(filename, "re");
+        queue_file = fopen("/run/udev/queue.bin", "re");
         if (queue_file == NULL)
                 return NULL;

Places

File 0024-libudev-queue.c-simplified-open_queue_file.patch of Package udev (Revision 3472ad684a35e2c19469b54271f049b8)

Places