File 24466-libxc_Only_retry_mapping_pages_when_ENOEN... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 24466-libxc_Only_retry_mapping_pages_when_ENOENT_is_returned.patch of Package xen

changeset:   24466:fc78d16447b4
user:        Andres Lagar-Cavilla <andres@lagarcavilla.org>
date:        Tue Jan 10 15:35:01 2012 +0000
files:       tools/libxc/xc_linux_osdep.c
description:
libxc: Only retry mapping pages when ENOENT is returned

If the return value from the ioctl() is not ENOENT, it's possible that err[i]
will not be updated and libxc will just loop forever.  Although it's unlikely
that err[i] would not be updated after the ioctl() gets through at least once,
it's better to be defensive.

Signed-off-by: Adin Scannell <adin@scannell.ca>
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

---
 tools/libxc/xc_linux_osdep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: xen-4.1.2-testing/tools/libxc/xc_linux_osdep.c
===================================================================
--- xen-4.1.2-testing.orig/tools/libxc/xc_linux_osdep.c
+++ xen-4.1.2-testing/tools/libxc/xc_linux_osdep.c
@@ -208,7 +208,7 @@ static void *linux_privcmd_map_foreign_b
             do {
                 usleep(100);
                 rc = ioctl(fd, IOCTL_PRIVCMD_MMAPBATCH_V2, &ioctlx);
-            } while ( rc < 0 && err[i] == -ENOENT );
+            } while ( rc < 0 && errno == ENOENT && err[i] == -ENOENT );
         }
     }

Places

File 24466-libxc_Only_retry_mapping_pages_when_ENOENT_is_returned.patch of Package xen

Places