File nm-openvpn-connection-type.patch of Package NetworkManager-openvpn

Overview Repositories Revisions Requests Users Attributes Meta

File nm-openvpn-connection-type.patch of Package NetworkManager-openvpn (Revision b2999d5b8fa9f7f417f7270f628e67f1)

Currently displaying revision b2999d5b8fa9f7f417f7270f628e67f1 , Show latest

--- src/nm-openvpn-service.c
+++ src/nm-openvpn-service.c
@@ -868,6 +868,14 @@ real_connect (NMVPNPlugin   *plugin,
 	user_name = nm_setting_vpn_get_user_name (s_vpn);
 	tmp = nm_setting_vpn_get_data_item (s_vpn, NM_OPENVPN_KEY_CONNECTION_TYPE);
 	connection_type = validate_connection_type (tmp);
+	if (!connection_type) {
+		g_set_error (error,
+		             NM_VPN_PLUGIN_ERROR,
+		             NM_VPN_PLUGIN_ERROR_BAD_ARGUMENTS,
+		             "Invalid connection type `%s'.",
+		             tmp);
+		return FALSE;
+	}
 
 	/* Need a username for any password-based connection types */
 	if (   !strcmp (connection_type, NM_OPENVPN_CONTYPE_PASSWORD_TLS)
@@ -925,6 +933,14 @@ real_need_secrets (NMVPNPlugin *plugin,
 
 	tmp = nm_setting_vpn_get_data_item (s_vpn, NM_OPENVPN_KEY_CONNECTION_TYPE);
 	connection_type = validate_connection_type (tmp);
+	if (!connection_type) {
+		g_set_error (error,
+		             NM_VPN_PLUGIN_ERROR,
+		             NM_VPN_PLUGIN_ERROR_CONNECTION_INVALID,
+		             "Invalid connection type `%s'.",
+		             tmp);
+		return FALSE;
+	}
 
 	if (!strcmp (connection_type, NM_OPENVPN_CONTYPE_PASSWORD_TLS)) {
 		/* Will require a password and maybe private key password */

Places

File nm-openvpn-connection-type.patch of Package NetworkManager-openvpn (Revision b2999d5b8fa9f7f417f7270f628e67f1)

Places