File ocaml-4.05.0-CVE-2018-9838.patch of Package ocaml

Overview Repositories Revisions Requests Users Attributes Meta

File ocaml-4.05.0-CVE-2018-9838.patch of Package ocaml (Revision c2be04886a32107508f9c7969d8f2a45)

Currently displaying revision c2be04886a32107508f9c7969d8f2a45 , Show latest

From 76566ed26c84e6fe800a67b62edbd260ccc30ef9 Mon Sep 17 00:00:00 2001
From: Xavier Leroy <xavier.leroy@inria.fr>
Date: Wed, 11 Apr 2018 12:05:08 +0200
Subject: [PATCH] MPR7765: integer overflows when unmarshaling a bigarray

Malicious or corrupted marshaled data can result in a bigarray
with impossibly large dimensions that cause overflow when computing
the in-memory size of the bigarray.  Disaster ensues when the data
is read in a too small memory area.  This commit checks for overflows
when computing the in-memory size of the bigarray.

Index: ocaml-4.03.0/otherlibs/bigarray/bigarray_stubs.c
===================================================================
--- ocaml-4.03.0.orig/otherlibs/bigarray/bigarray_stubs.c
+++ ocaml-4.03.0/otherlibs/bigarray/bigarray_stubs.c
@@ -963,22 +963,33 @@ static void caml_ba_deserialize_longarra
 uintnat caml_ba_deserialize(void * dst)
 {
   struct caml_ba_array * b = dst;
-  int i, elt_size;
-  uintnat num_elts;
+  int i, overflow;
+  uintnat num_elts, size;
 
   /* Read back header information */
   b->num_dims = caml_deserialize_uint_4();
+  if (b->num_dims < 0 || b->num_dims > CAML_BA_MAX_NUM_DIMS)
+    caml_deserialize_error("input_value: wrong number of bigarray dimensions");
   b->flags = caml_deserialize_uint_4() | CAML_BA_MANAGED;
   b->proxy = NULL;
   for (i = 0; i < b->num_dims; i++) b->dim[i] = caml_deserialize_uint_4();
-  /* Compute total number of elements */
-  num_elts = caml_ba_num_elts(b);
-  /* Determine element size in bytes */
+  /* Compute total number of elements.  Watch out for overflows (MPR#7765). */
+  overflow = 0;
+  num_elts = 1;
+  for (i = 0; i < b->num_dims; i++) {
+    num_elts = caml_ba_multov(num_elts, b->dim[i], &overflow);
+    if (overflow) caml_deserialize_error("input_value: size overflow for bigarray");
+  }
+  /* Determine array size in bytes.  Watch out for overflows (MPR#7765). */
   if ((b->flags & CAML_BA_KIND_MASK) > CAML_BA_CHAR)
     caml_deserialize_error("input_value: bad bigarray kind");
-  elt_size = caml_ba_element_size[b->flags & CAML_BA_KIND_MASK];
+  overflow = 0;
+  size = caml_ba_multov(num_elts,
+                        caml_ba_element_size[b->flags & CAML_BA_KIND_MASK],
+                        &overflow);
+  if (overflow) caml_deserialize_error("input_value: size overflow for bigarray");
   /* Allocate room for data */
-  b->data = malloc(elt_size * num_elts);
+  b->data = malloc(size);
   if (b->data == NULL)
     caml_deserialize_error("input_value: out of memory for bigarray");
   /* Read data */

Places

File ocaml-4.05.0-CVE-2018-9838.patch of Package ocaml (Revision c2be04886a32107508f9c7969d8f2a45)

Places