File 0001-build-resolve-compile-warning-in-servtree.... of Package atheme

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-build-resolve-compile-warning-in-servtree.c.patch of Package atheme (Revision 6e0a8776f04df1212abd84d8686248a0)

Currently displaying revision 6e0a8776f04df1212abd84d8686248a0 , Show latest

From be48e415d9937014c4eac4d957ceb3bcc09b406d Mon Sep 17 00:00:00 2001
From: Jan Engelhardt <jengelh@inai.de>
Date: Tue, 1 Oct 2013 01:56:13 +0200
Subject: [PATCH] build: resolve compile warning in servtree.c

rpmlint is holding up the red flag in atheme 7.0.6

I: Program returns random data in a function
E: atheme no-return-in-nonvoid-function servtree.c:405

gcc had to say:
servtree.c:405:1: warning: control reaches end of non-void
function [-Wreturn-type]

The function added in commit f6fcaaa760913fb242cf0d330178a0078d458861
lacks a return call for the potential case of exiting the loop.
---
 libathemecore/servtree.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libathemecore/servtree.c b/libathemecore/servtree.c
index cc57bee..a4e205b 100644
--- a/libathemecore/servtree.c
+++ b/libathemecore/servtree.c
@@ -402,6 +402,7 @@ service_t *service_find_any(void)
 
 	MOWGLI_PATRICIA_FOREACH(sptr, &state, services_name)
 		return sptr;
+	return NULL;
 }
 
 service_t *service_find(const char *name)
-- 
1.8.2

Places

File 0001-build-resolve-compile-warning-in-servtree.c.patch of Package atheme (Revision 6e0a8776f04df1212abd84d8686248a0)

Places