File 0006-systemctl-fix-resource-leak-CID-1237747.patch of Package systemd

Overview Repositories Revisions Requests Users Attributes Meta

File 0006-systemctl-fix-resource-leak-CID-1237747.patch of Package systemd (Revision 3494bf2ed83c235bc925d99621645482)

Currently displaying revision 3494bf2ed83c235bc925d99621645482 , Show latest

From 48a2900c6612052149a1d0dd88aeacb99b49ce4d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cristian=20Rodr=C3=ADguez?= <crrodriguez@opensuse.org>
Date: Wed, 17 Sep 2014 21:56:25 -0300
Subject: [PATCH] systemctl: fix resource leak CID #1237747

..by simply moving the declaration of "unit" into the STRV_FOREACH
loop as suggested by Andreas.
---
 src/systemctl/systemctl.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git src/systemctl/systemctl.c src/systemctl/systemctl.c
index 88be871..9012128 100644
--- src/systemctl/systemctl.c
+++ src/systemctl/systemctl.c
@@ -4449,7 +4449,6 @@ static int show(sd_bus *bus, char **args) {
 }
 
 static int cat(sd_bus *bus, char **args) {
-        _cleanup_free_ char *unit = NULL;
         _cleanup_strv_free_ char **names = NULL;
         char **name;
         bool first = true;
@@ -4468,6 +4467,8 @@ static int cat(sd_bus *bus, char **args) {
                 _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
                 _cleanup_strv_free_ char **dropin_paths = NULL;
                 _cleanup_free_ char *fragment_path = NULL;
+                _cleanup_free_ char *unit = NULL;
+
                 char **path;
 
                 unit = unit_dbus_path_from_name(*name);
-- 
1.7.9.2

Places

File 0006-systemctl-fix-resource-leak-CID-1237747.patch of Package systemd (Revision 3494bf2ed83c235bc925d99621645482)

Places