File OpenIPMI.changes of Package OpenIPMI

Overview Repositories Revisions Requests Users Attributes Meta

File OpenIPMI.changes of Package OpenIPMI (Revision 405b153edc238ac62fd0d11e1ac9a9fc)

Currently displaying revision 405b153edc238ac62fd0d11e1ac9a9fc , Show latest

-------------------------------------------------------------------
Tue Jun 18 12:31:39 UTC 2024 - Martin Jambor <mjambor@suse.com>

- Add OpenIPMI-c99.patch in order to make the package buildable with
  GCC 14.  Patch comes from upstream
  https://sourceforge.net/p/openipmi/patches/38/ [[boo#1225871]]

-------------------------------------------------------------------
Tue May 10 13:34:05 UTC 2022 - trenn@suse.de

- Update to version 2.0.32.3+git.05faa36e:
  * entity: Handle NULL entity in internal_fru_fetch_done()
  * entity: Keep the entity around duringa FRU fetch
  * Move to version 2.0.32
  * Fix readline and python support
  * sol: Fix multiple flush queuing issue
- Patches that are mainline:
D    fix-conversions.patch
D    unix_thread-Remove-the-fd-handler-sets-before-it-s-set-up.patch
D    lanserv-Add-the-judgment-on-the-validity-of-length-in-emu_cmd.c-and-session-in-lanserv_ipmi.c.patch
D    OpenIPMI-no-return-in-nonvoid-function.patch
- Refreshed patches not yet mainline:
M    openipmi-tinfo.patch
M    fix_dia_version_detection.patch

-------------------------------------------------------------------
Mon May  9 16:41:24 UTC 2022 - Ben Greiner <code@bnavigator.de>

- Add OpenIPMI-autoconf-m4-ax-python-devel-serial25.patch
  which updates m4/ax_python_devel.m4 to serial25, retaining
  upstreams PYTHON_VERSION addition, before the bootstrap runs
  automake, because the new serial 25 can deal with
  Python 3.10 version strings and deprecation of distutils.

-------------------------------------------------------------------
Thu Apr 28 00:16:24 UTC 2022 - Jan Engelhardt <jengelh@inai.de>

- Resolve rpmlint report "libOpenIPMI0.x86_64: E:
  shlib-policy-name-error SONAME: libOpenIPMIui.so.1, expected
  package suffix: 1"
- Trim manual library Provides. Prospective users (packages) ought
  to let rpm find the dependencies (and their name is usually
  "libIPMIlanserv.so.0()(64bit)" not "libIPMIlanserv".

-------------------------------------------------------------------
Tue Oct 12 19:22:34 UTC 2021 - Thomas Renninger <trenn@suse.de>

- Fix file conflict with old python2 version (bsc#1190999):
found conflict of OpenIPMI-python-2.0.25-7.3.1.x86_64 with OpenIPMI-python3-2.0.31-1.1.x86_64
  /usr/bin/openipmigui
  /usr/share/man/man1/openipmigui.1.gz

-------------------------------------------------------------------
Wed Oct  6 07:17:32 UTC 2021 - Thomas Renninger <trenn@suse.de>

- Enhance changelog as demanded in an internal submitrequest

-------------------------------------------------------------------
Tue Sep 28 08:30:14 UTC 2021 - Thomas Renninger <trenn@suse.de>

- Add latest mainline fixes:
A    lanserv-Add-the-judgment-on-the-validity-of-length-in-emu_cmd.c-and-session-in-lanserv_ipmi.c.patch
A    unix_thread-Remove-the-fd-handler-sets-before-it-s-set-up.patch

-------------------------------------------------------------------
Fri Jul  9 08:15:37 UTC 2021 - Thomas Renninger <trenn@suse.de>

- Update to version 2.0.31
  Adopted patches to latest sources:
M    OpenIMPI-add-libncurses.patch
M    OpenIPMI-no-return-in-nonvoid-function.patch
M    OpenIPMI-prefer_perl_vendor.patch
M    fix_dia_version_detection.patch
M    openipmi-tinfo.patch

* sample: Prefer glib for solterm instead of posix
  * sample: Remove -rdynamic from openipmicmd
  * smample: Compile ipmicmd with glib if it is available
  * glib: Allow NULL timeout to perform_one_op()
  * lanserv: Fix an issue with rmcp sending
  * Rework mcserv.h so that marvell-mod can get what it needs
  * lanserv: Move sol_init_mc() into sol code
  * lanserv: Remove all calls from the library to user code
  * Move ipmi_log() to ipmi_log.h
  * ui: export ipmi_ui_cb_handlers
  * ui: Add link libraries to UI library
  * Add -no-undefined to all shared library links
  * Rework ipmi_cmdlang_report_event()
  * Rework ipmi_cmdlang_global_err()
  * Get rid of posix_vlog()
  * lanserv: Use recv, not read, for a network socket
  * A lot windows (DLL, winsock, etc.) enhancements

- Update to version 2.0.30:
  * Switch to python3 by default
  * lanserv: Fix some various bugs
  * sol: Fix some various bugs
  * sdrcomp: Fix some memory leaks
  * sol: Fix some packet handling errors
  * solterm: Clean things up at shutdown
  * Fix a leak in the selector code
  * sol: Rewrite the library code
  * sol: Return errors from close if the send fails
  * Reconfigure the transmitter on a reconnect
  * Refuse writes greater than 255 bytes
  * lan: Fix timer cleanup
  * Fix init/shutdown issues with mcs and domains
  * Fix shutdown on error issues
  * Fix a memory leak at initialization
  * selector: Make the timer stop with done work right when handler running
  * Add parameters to let the lan timeouts be specified
  * initscript: Don't delete ipmi devices if udev created them
  * selector: Rework to allow an arbitrary number of fds with epoll
  * Don't disable fd handlers before setting one up
  * Don't crash if passed in fd is >= FD_SETSIZE

-------------------------------------------------------------------
Mon Jun 28 20:42:15 UTC 2021 - Matej Cepl <mcepl@suse.com>

- Use Python3 instead of Python2 (bsc#1190999).

-------------------------------------------------------------------
Mon Mar  8 14:16:36 UTC 2021 - Matthias Gerstner <matthias.gerstner@suse.com>

- drop -fPIC from CFLAGS which breaks our gcc-PIE profile resulting in
  non-position independent binaries and thus weakened security (bsc#1183046).

-------------------------------------------------------------------
Mon Aug 17 21:38:50 UTC 2020 - Dirk Mueller <dmueller@suse.com>

- update to 2.0.29:
  * Add an external definition for ipmi_malloc_shutdown()
  * Pass 0 to snprintf size when calculating real size
  * selector: Fix a signed/unsigned comparison
  * selector: Fix handling if pselect() returns 0
  * selector: Return the right value for timer already in use
  * selector: Cause the read handler to be called on an exception
  * selector: Fix multi-threading issues
  * selector: Add an selector call to install a sigmask
  * For for brokenness with fork() and epoll()
  * Fix a deadlock when freeing a running timer
  * lanserv: Allow individual group extensions to be registered
  * Include readline history headers where needed

-------------------------------------------------------------------
Mon Jan 20 13:29:35 UTC 2020 - Josef Möllers <josef.moellers@suse.com>

- Update to latest version 2.0.28
  * Fixed a number of potential buffer overruns by appending a NUL
    character to strncpy'd strings.
  * switched from editline to readline
  * some variable and function renaming to avoid leading
    underscores
  * more changes, no documentation available (ChangeLog file
    is unchanged!)
  * Two patches now obsolete.
  [OpenIPMI-2.0.25..HEAD_git.diff,
   0003-Apply-OpenIPMI-2.0.21-nobundle.patch.patch,
   OpenIPMI-2.0.28.tar.gz]

-------------------------------------------------------------------
Sun Mar 17 10:14:37 UTC 2019 - Jan Engelhardt <jengelh@inai.de>

- Use noun phrase in summary. Remove em dashes from summaries.
- Implement shared library packaging policy.

-------------------------------------------------------------------
Tue Sep 11 15:34:15 UTC 2018 - Jan Engelhardt <jengelh@inai.de>

- Use noun phrase in summary. Ensure neutrality of description.
- Update unspecific summaries of subpackages.
- Drop --with-pic which is only relevant for static libs.
- Speedier /usr/bin/find call.

-------------------------------------------------------------------
Fri Sep  7 13:56:06 UTC 2018 - trenn@suse.de

- Update to latest version 2.0.25 plus latest fixes (fate#326195):

- A    OpenIPMI-2.0.25..HEAD_git.diff
Patch to latest git commit:
commit 4ac55d7dc7016c9e5f0c474f69f4e64e7aacac42
Date:   Wed Jul 18 13:59:29 2018 -0500
    unix: Add a way to clear fd handlers with no callbacks

I had to manually edit git diff v2.0.25.. and remove .gitignore deletion
to patch succesfully. Build service wants to have the original
.tar.gz tarball from sourceforge.

I also had to add the bootstrap file which seem to exist in git sources
but not in the exported tarball, even it is not listed in .gitignore:
A bootstrap

OAD
0001-Apply-OpenIPMI-2.0.18-pthread-pkgconfig.patch.patch

- Adjusted patches:
M    0003-Apply-OpenIPMI-2.0.21-nobundle.patch.patch
M    fix-conversions.patch
M    OpenIPMI-prefer_perl_vendor.patch
M    openipmi-tinfo.patch

- Fix build service error (use /usr/bin/python3 in shebang instead of env
A    use_python3_shebang
- Build documentation (IPMI.pdf) ourselves as IPMI.pdf vanished from sources
  For this quite some build requires had to be added as well
A    fix_dia_version_detection.patch

-------------------------------------------------------------------
Wed Jul 25 16:24:55 UTC 2018 - dimstar@opensuse.org

- Replace usage of deprecated py_sitedir macro with
  python_sitearch.

-------------------------------------------------------------------
Fri Jan 19 08:12:06 UTC 2018 - josef.moellers@suse.com

- * added a section defining IPMI_SI_MODULE_NAME to sysconfig.ipmi
  * added code to OpenIPMI.spec/%install to modify sysconfig.ipmi
    according to architecture
  * modified openipmi-helper to load "sysconfig.ipmi" AFTER setting
    default IPMI_SI_MODULE_NAME=ipmi_si
  [bsc#1059820, OpenIPMI.spec, openipmi-helper, sysconfig.ipmi]

-------------------------------------------------------------------
Thu Nov 23 13:37:07 UTC 2017 - rbrown@suse.com

- Replace references to /var/adm/fillup-templates with new 
  %_fillupdir macro (boo#1069468)

-------------------------------------------------------------------
Mon Sep 25 12:58:32 UTC 2017 - josef.moellers@suse.com

- Upgrade to 2.0.24
  * Mainly code cleanup and small rewrites.
  * Variable renaming IPMI_... to OPENIPMI_...
  * Improved internal error handling
  * IPv6 support added/completed.
  [fate#322830, OpenIMPI-add-libncurses.patch,
  OpenIPMI-no-return-in-nonvoid-function.patch]

-------------------------------------------------------------------
Tue Jun 27 11:57:28 UTC 2017 - tchvatal@suse.com

- Version update to lates trelease 2.0.23:
  * There is no longer actively updated changelog
  * Various bugfixes since last git pull from 2016-02-26
- Drop OpenIPMI-libtool.patch which was merged upstream
- Drop OpenIPMI_2.0.21_to_HEAD.patch patch as it is no longer
  needed
- Add patch openipmi-tinfo.patch to detect tinfo properly
- Add patch to fix OpenIPMIpthread pc file (from Fedora)
  0001-Apply-OpenIPMI-2.0.18-pthread-pkgconfig.patch.patch
- Add patch to not bundle libedit (from Fedora)
  0003-Apply-OpenIPMI-2.0.21-nobundle.patch.patch

-------------------------------------------------------------------
Wed Sep 14 09:54:22 UTC 2016 - fgerling@suse.com

- Update spec file to properly install sysconfig.ipmi (bsc#989985, bsc#988443)

-------------------------------------------------------------------
Tue Mar  8 08:44:52 UTC 2016 - dimstar@opensuse.org

- Remove one occurence of perl_requires: once is sufficient.

-------------------------------------------------------------------
Mon Mar  7 16:19:17 UTC 2016 - trenn@suse.de

- Fix perl requires by using the pre-defined macro (bsc#969576)

-------------------------------------------------------------------
Fri Feb 26 08:17:13 UTC 2016 - trenn@suse.de

- Update to latest git commit:
  a01bbe94efff3a5f239b3b5440c8..052d36ec88515c1b1177faa442833e3
Add: OpenIPMI_2.0.21_to_HEAD.patch
Removed modifications for:
 - lanserv/ipmi_sim_chassiscontrol
 - lanserv/marvell-bmc/TODO
due to git repo inconsistencies
- Some spec file cleanups obs complained about
  -> also spec-cleaner run through

-------------------------------------------------------------------
Sat Feb  7 17:14:57 UTC 2015 - dimstar@opensuse.org

- Do not try to register/deregister OpenIPMI.info.gz in post/postun
  of the devel package: we do not install such a file.

-------------------------------------------------------------------
Sat Dec 27 17:42:00 UTC 2014 - Led <ledest@gmail.com>

- fix bashisms in openipmi-helper script

-------------------------------------------------------------------
Wed Nov 19 23:18:06 UTC 2014 - dimstar@opensuse.org

- Replace systemd BuildRequires with pkgconfig(systemd): we do not
  require the full installation / dep chain of systemd.

-------------------------------------------------------------------
Sat Oct 25 13:24:06 UTC 2014 - p.drouand@gmail.com

- Use systemd instead of sysvinit
  + Add ipmi.service
  + Add openipmi-helper to keep capabilities of sysvinit script
  + Add systemd related macros
- Remove obsolete/depreciated macros

-------------------------------------------------------------------
Thu Jul 10 15:08:21 UTC 2014 - trenn@suse.de

- Split OpenIPMI into base package and OpenIPMI-python
  OpenIPMI-python gets OpenIPMI python library and openipmigui which is
  a python based gui.
  Like above the OpenIPMI base package does not need python-tk and tix
  packages any more.

-------------------------------------------------------------------
Thu Feb 13 08:25:50 UTC 2014 - kkaempf@suse.com

- Update to 2.0.21
  Bugfix release
  - marvell: Add a command to directly set the duty cycle of the fans.
  - The IANA numbers are supposed to be in bytes 2-4 off responses to
    IANA commands, but they were not being put there.  Fix this in the
    main IANA handling to do this automatically, and modify the
    command handling to strip the IANA from the command and add it to
    a message field.  This makes handling of IANA commands more
    natural and allows standard message response generation to work.

- Drop upstreamed patches:
    tcl-includes-moved.patch, new-names-for-new-variables,
    OpenIPMI-popt.patch, OpenIPMI-2.0.16-larger-ipmibuf.patch,
    do-fclose.patch, bug-854693_segv_sol.patch

-------------------------------------------------------------------
Thu Jan  9 15:03:26 UTC 2014 - trenn@suse.de

- Cleanup patches:
  Drop: fix-devel-deps.patch
  Add changelog to most of the patches and submitted them mainline.
  Add: bug-854693_segv_sol.patch
  bnc#854693

-------------------------------------------------------------------
Fri Oct  4 08:31:43 UTC 2013 - kkaempf@suse.com

- Fix SLE 11 build

-------------------------------------------------------------------
Thu Nov 15 12:37:58 UTC 2012 - kkaempf@suse.com

- Update to 2.0.20-rc1
  * Rename lanserv_emu to ipmi_sim, and modify ipmi_sim to use
    the OS handler.
  * lanserv, man: Did a massive restructure of lanserv and the
    IPMI simulator for supporting a VM interface.
  * Many bugs fixed

- Suffix all patches with .patch

-------------------------------------------------------------------
Wed Sep 12 07:31:13 UTC 2012 - coolo@suse.com

- use %perl_requires

-------------------------------------------------------------------
Wed Sep  5 15:06:42 UTC 2012 - duwe@suse.com

- fix bnc#714634

-------------------------------------------------------------------
Tue Nov 15 13:10:35 UTC 2011 - coolo@suse.com

- add libtool as buildrequire to avoid implicit dependency

-------------------------------------------------------------------
Sun Oct 23 22:40:29 UTC 2011 - pascal.bleser@opensuse.org

- fix mtime on python .pyc files
- remove python .pyo files (they're useless)
- add reload to init script, which fails with exit code 3 as it is not
  implemented
- update to 2.0.19 (cumulated):
  * ipmi.init - Initscripts should be idempotent, meaning you can safely call
    "start" multiple times in a row and receive a success each time if the
    service is running. This requirement is mentioned in the LSB Spec, version
    3.1, section 20.2.
  * lib/sensor.c: Change the "share count" checking to check if share count is
    > 1, not > 0, because some silly machines set the value to one when they
    should set it to zero, and one is a silly setting
  * add a cache option

-------------------------------------------------------------------
Sun Jan 16 14:58:27 UTC 2011 - aj@suse.de

- Buildrequire python-xml instead of dropped pyxml.

-------------------------------------------------------------------
Thu Mar 11 16:04:00 CET 2010 - duwe@suse.de

- compile and dependency fixes
  (bnc#388026,bnc#529028,bnc#497595,bnc#552480)
- use a large buffer for SoL (bnc#587029)

-------------------------------------------------------------------
Mon Nov 23 00:45:06 CET 2009 - ro@suse.de

- use py_sitedir macro in filelist

-------------------------------------------------------------------
Fri Nov 20 16:17:38 CET 2009 - duwe@suse.de

- update to version 2.0.16, per FATE#307244

-------------------------------------------------------------------
Sun Aug  9 12:43:26 CEST 2009 - coolo@novell.com

- use new python macros

-------------------------------------------------------------------
Mon Mar  2 15:28:27 CET 2009 - crrodriguez@suse.de

- save 3MB by removing static libraries and "la" files

-------------------------------------------------------------------
Thu Sep 11 17:00:59 CEST 2008 - kukuk@suse.de

- Update to 2.0.14 [fate#304439]
- fix at least the worst bugs in init script

-------------------------------------------------------------------
Tue May  6 07:59:42 CEST 2008 - coolo@suse.de

- return in non-void functions

-------------------------------------------------------------------
Tue Apr 15 17:01:26 CEST 2008 - schwab@suse.de

- Fix popt configure check.

-------------------------------------------------------------------
Mon Apr 14 14:04:59 CEST 2008 - schwab@suse.de

- Work around misuse of libtool.

-------------------------------------------------------------------
Sun Apr  6 21:04:19 CEST 2008 - coolo@suse.de

- build with latest tcl, reduce build requires

-------------------------------------------------------------------
Wed Jan 16 16:43:01 CET 2008 - duwe@suse.de

- Update to 2.0.13
  + better sensors support
  + numerous bug fixes, including #310247
- fixed bug#156215

-------------------------------------------------------------------
Fri Apr 20 09:16:14 CEST 2007 - aj@suse.de

- Package does not need latex for normal building, remove build
  dependency.

-------------------------------------------------------------------
Mon Mar 26 15:21:26 CEST 2007 - rguenther@suse.de

- package .la and .so file in OpenIPMI-devel package only
- add gdbm-devel BuildRequires

-------------------------------------------------------------------
Mon Feb  5 15:22:26 CET 2007 - duwe@suse.de

- fix not-really-shadowing variable with questionable behaviour
  (reported in Bug #232439)

-------------------------------------------------------------------
Wed Dec 20 17:38:47 CET 2006 - coyli@suse.de

- fix misconfigured destination library directory for perl
  and python code.
- add openssl-devel and ncurse-devel in Build Requires of
  OpenIPMI-devel.

-------------------------------------------------------------------
Tue Nov  7 10:12:17 CET 2006 - coyli@suse.de

- fix deadlock in openipmigui (BUG #206661)
- get openssl linked in
- remove compiling warning in source code
- modify licnese from GPL to LGPL
- fix an out of range looping bug, which chould cause crash 
  to programs linked with OpenIPMI library

-------------------------------------------------------------------
Thu Sep 14 19:17:28 CEST 2006 - duwe@suse.de

- Update to 2.0.7 (thanks, coly)
  + new front-ends, some graphical ("openipmigui")
  + various bugfixes
  + new FRU interface
  + tcl bindings added
  site_perl spared thanks to Rudi.

-------------------------------------------------------------------
Mon May 29 13:18:04 CEST 2006 - kukuk@suse.de

- ipmi init script: Replace /sbin/udev with /sbin/udevd [#174010]

-------------------------------------------------------------------
Fri Mar  3 16:36:44 CET 2006 - duwe@suse.de

- update to 1.4.26
  - various small bug and memory leak fixes
  - fix local operation on ATCA
  - add support for multiple IPMB channels with different IPMB
    addresses

-------------------------------------------------------------------
Wed Jan 25 21:33:53 CET 2006 - mls@suse.de

- converted neededforbuild to BuildRequires

-------------------------------------------------------------------
Tue Dec 20 14:50:11 CET 2005 - duwe@suse.de

- Add %insserv_prereq and %fillup_prereq fixing Bug #140314

-------------------------------------------------------------------
Mon Dec 19 14:50:50 CET 2005 - ro@suse.de

- fixed filelist

-------------------------------------------------------------------
Tue Nov  8 14:10:16 CET 2005 - dmueller@suse.de

- don't build as root

-------------------------------------------------------------------
Wed Oct 26 16:27:27 CEST 2005 - duwe@suse.de

- add patches by matt to sync with upstream (#128770)

-------------------------------------------------------------------
Mon Oct 10 13:29:35 CEST 2005 - duwe@suse.de

- rc script name change openipmi->ipmi (Bug #120227)
- default start in runlevels 2 3 5 (Bug #121651)

-------------------------------------------------------------------
Thu Sep 22 14:50:15 CEST 2005 - duwe@suse.de

- Update to version 1.4.19 (#117699)
- add initscripts (#117103)

-------------------------------------------------------------------
Mon Jun  6 13:25:32 CEST 2005 - mrueckert@suse.de

- Update to version 1.4.16

-------------------------------------------------------------------
Tue May 10 10:20:19 CEST 2005 - meissner@suse.de

- fixed potential 2 byte overflow due to bug in strncpy().

-------------------------------------------------------------------
Sat Mar 26 15:36:18 CET 2005 - nashif@suse.de

- Fixed license in include file (#74351)

-------------------------------------------------------------------
Fri Feb 18 01:54:13 CET 2005 - nashif@suse.de

- Update to 1.3.17
- Split package

-------------------------------------------------------------------
Sat Jan  8 16:04:13 CET 2005 - nashif@suse.de

- Fixed installation of info files

-------------------------------------------------------------------
Tue Jan  4 19:47:07 CET 2005 - nashif@suse.de

- Update to version 1.3.16

-------------------------------------------------------------------
Thu Oct 28 04:19:27 CEST 2004 - nashif@suse.de

- Updated to version 1.3.11

-------------------------------------------------------------------
Tue Aug 10 23:51:24 CEST 2004 - nashif@suse.de

- Updated to version 1.3.9

-------------------------------------------------------------------
Tue Jun  8 04:23:54 CEST 2004 - nashif@suse.de

- Updated to version 1.3.8

-------------------------------------------------------------------
Thu May  6 01:49:30 CEST 2004 - nashif@suse.de

- Added a way to get the number of entries and free
  bytes in the SEL.

-------------------------------------------------------------------
Fri Apr 30 04:26:59 CEST 2004 - nashif@suse.de

- Fixes by author:
 * lib/sel.c: Fixed a bug in the sel get where the info allocated
   can go away before the operation returns, but the info is used
   after the operation returns.
 * lib/sensor.c: Fix the hysteresis setting to send a message that
   is the right size.

-------------------------------------------------------------------
Wed Apr 28 15:46:12 CEST 2004 - nashif@suse.de

- Updated to 1.3.6 (as per bug #38602)

-------------------------------------------------------------------
Mon Mar 22 19:00:18 CET 2004 - nashif@suse.de

- Enabled sources again
- files with legal issues have been removed upstream

-------------------------------------------------------------------
Mon Mar 22 00:09:30 CET 2004 - nashif@suse.de

- Update to release 1.2.21

-------------------------------------------------------------------
Fri Feb 27 11:41:22 CET 2004 - tsieden@suse.de

- update to release 1.2.7
- replaced test_md2.c with a dummy, switched to a nosrc.rpm
  to avoid legal problems

-------------------------------------------------------------------
Mon Oct 27 09:12:13 CET 2003 - kukuk@suse.de

- Don't link static libraries in shared one without -fPIC compiled
- Fix building on lib64 architectures

-------------------------------------------------------------------
Thu Oct 23 16:29:04 CEST 2003 - tsieden@suse.de

- branched -devel package

-------------------------------------------------------------------
Fri Oct 17 10:35:24 CEST 2003 - tsieden@suse.de

- initial release 1.1.4

Places

File OpenIPMI.changes of Package OpenIPMI (Revision 405b153edc238ac62fd0d11e1ac9a9fc)

Places