openSUSE Build Service

Overview Repositories Revisions Requests Users Attributes Meta

File r729276.diff of Package koffice

------------------------------------------------------------------------
r729276 | mueller | 2007-10-25 15:33:42 +0200 (Thu, 25 Oct 2007) | 4 lines
Changed paths:
   M /branches/koffice/1.6/koffice/kspread/plugins/scripting/kspreadcore/krs_cell.cpp
   M /branches/koffice/1.6/koffice/kspread/plugins/scripting/kspreadcore/krs_cell.h

remove unused parameter. apparently due to a bug (?), 
gcc 4.3 does no longer support default parameters in
template overload resolution

------------------------------------------------------------------------
Index: kspread/plugins/scripting/kspreadcore/krs_cell.cpp
===================================================================
--- kspread/plugins/scripting/kspreadcore/krs_cell.cpp	(revision 729275)
+++ kspread/plugins/scripting/kspreadcore/krs_cell.cpp	(revision 729276)
@@ -174,12 +174,7 @@ const QString Cell::text() const {
 	return m_cell->text();
 }
 
-bool Cell::setText(const QString& text, bool asString) {
-
-	//FIXME: there is some problem with asString parameter, when it's set
-	//to true KSpread says: ASSERT: "f" in Dependencies.cpp (621)
-	//kspread: Cell at row 6, col 1 marked as formula, but formula is NULL
-
+bool Cell::setText(const QString& text) {
 	KSpread::ProtectedCheck prot;
 	prot.setSheet (m_sheet);
 	prot.add (QPoint (m_col, m_row));
@@ -189,7 +184,7 @@ bool Cell::setText(const QString& text, 
 	KSpread::DataManipulator *dm = new KSpread::DataManipulator ();
 	dm->setSheet (m_sheet);
 	dm->setValue (text);
-	dm->setParsing (!asString);
+	dm->setParsing (true);
 	dm->add (QPoint (m_col, m_row));
 	dm->execute ();
 
Index: kspread/plugins/scripting/kspreadcore/krs_cell.h
===================================================================
--- kspread/plugins/scripting/kspreadcore/krs_cell.h	(revision 729275)
+++ kspread/plugins/scripting/kspreadcore/krs_cell.h	(revision 729276)
@@ -131,11 +131,10 @@ class Cell : public Kross::Api::Class<Ce
 		*/
 		const QString text() const;
 		/**
-		* Set the text of the cell. If asString is true, the text
-		* will be handled as string else we try to parse the
-		* string to the expected value.
+		* Set the text of the cell. the text
+		* will be handled as string
 		*/
-		bool setText(const QString& text, bool asString = false);
+		bool setText(const QString& text);
 
 		/**
 		* Return the textcolor as RGB-value in the format "#RRGGBB".

Places

File r729276.diff of Package koffice

Places