File tomboy-html-export-expose-errors.patch of Package tomboy

Overview Repositories Revisions Requests Users Attributes Meta

File tomboy-html-export-expose-errors.patch of Package tomboy (Revision b4ae65a518a92d988d2325219679050a)

Currently displaying revision b4ae65a518a92d988d2325219679050a , Show latest

Novell bug: https://bugzilla.novell.com/show_bug.cgi?id=172414
Upstream bug: http://bugzilla.gnome.org/show_bug.cgi?id=351664

Wed Aug 16 21:26:18 CEST 2006 - btimothy@suse.de
- Fix for BNC #172414.  An error message is now shown to the user
  if the HTML Export fails for any reason.

================================================================================
--- Tomboy/Plugins/ExportToHTML.cs
+++ Tomboy/Plugins/ExportToHTML.cs
@@ -67,14 +67,16 @@
 		ExportToHTMLDialog dialog = new ExportToHTMLDialog (Note.Title + ".html");
 		int response = dialog.Run();
 		string output_path = dialog.Filename;
-		dialog.Destroy ();
 
-		if (response != (int) Gtk.ResponseType.Ok) 
+		if (response != (int) Gtk.ResponseType.Ok) {
+			dialog.Destroy (); 
 			return;
+		}
 
 		Logger.Log ("Exporting Note '{0}' to '{1}'...", Note.Title, output_path);
 
 		StreamWriter writer = null;
+		string error_message = null;
 		try {
 			try {
 				// FIXME: Warn about file existing.  Allow overwrite.
@@ -85,14 +87,62 @@
 			writer = new StreamWriter (output_path);
 			WriteHTMLForNote (writer, Note, dialog.ExportLinked, dialog.ExportLinkedDepth);
 
-			Uri output_uri = new Uri (output_path);
-			Gnome.Url.Show (output_uri.AbsoluteUri);
+			// Save the dialog preferences now that the note has successfully been exported
+                       dialog.SavePreferences ();
+                       dialog.Destroy ();
+                       dialog = null;
+
+                       try     {
+                               Uri output_uri = new Uri (output_path);
+                               Gnome.Url.Show (output_uri.AbsoluteUri);
+                       } catch (Exception ex) {
+                               Console.WriteLine ("Could not open the exported note in a web browser: {0}", ex);
+
+                               // Let the user know the note was saved successfully+                               // even though showing the note in a web browser failed.
+                               HIGMessageDialog msg_dialog =
+                                       new HIGMessageDialog (
+                                               Window,
+                                               Gtk.DialogFlags.DestroyWithParent,
+                                               Gtk.MessageType.Info,
+                                               Gtk.ButtonsType.Ok,
+                                               Catalog.GetString ("Note exported successfully"),
+                                               String.Format (
+                                                       Catalog.GetString ("Your note was exported as \"{0}\"."),
+                                                       output_path));
+                               msg_dialog.Run ();
+                               msg_dialog.Destroy ();
+                       }
+               } catch (UnauthorizedAccessException uae) {
+                       error_message = Catalog.GetString ("Access denied.");
+               } catch (DirectoryNotFoundException dnfe) {
+                       error_message = Catalog.GetString ("Folder does not exist.");
 		} catch (Exception e) {
-			Logger.Log ("Could not export: {0}", e);
+			Console.WriteLine ("Could not export: {0}", e);
+
+                       error_message = e.Message;
 		} finally {
 			if (writer != null) 
 				writer.Close ();
 		}
+
+               if (error_message != null)
+               {
+                       Console.WriteLine ("Could not export: {0}", error_message);
+
+                       HIGMessageDialog msg_dialog =
+                               new HIGMessageDialog (
+                                       dialog,
+                                       Gtk.DialogFlags.DestroyWithParent,
+                                       Gtk.MessageType.Error,
+                                       Gtk.ButtonsType.Ok,
+                                       String.Format (Catalog.GetString ("Could not save the file \"{0}\""), output_path),
+                                       error_message);
+                       msg_dialog.Run ();
+                       msg_dialog.Destroy ();
+               }
+
+               if (dialog != null)
+                       dialog.Destroy ();
 	}
 
 	public void WriteHTMLForNote (TextWriter writer, 
@@ -213,8 +263,6 @@
 
 		DefaultResponse = Gtk.ResponseType.Ok;
 
-		Response += OnResponseCb;
-
 		Gtk.Table table = new Gtk.Table (3, 2, false);
 
 		export_linked = new Gtk.CheckButton (Catalog.GetString ("Include linked notes"));
@@ -265,10 +313,16 @@
 		get { return gtk_file_chooser_get_filename (this.Handle); }
 	}
 	
-	protected void OnResponseCb (object sender, Gtk.ResponseArgs args) 
+	public void SavePreferences () 
 	{
-		if (args.ResponseId == Gtk.ResponseType.Ok) 
-			SavePreferences ();
+		string dir = System.IO.Path.GetDirectoryName (Filename);
+		Preferences.Set (Preferences.EXPORTHTML_LAST_DIRECTORY, dir);
+
+		Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED, ExportLinked);
+		if (export_all_levels.Active)
+			Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED_DEPTH, "all");
+		else
+			Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED_DEPTH, "one");
 	}
 
 	protected void LoadPreferences (string default_file) 
@@ -294,18 +348,6 @@
 			export_one_level.Active = true;
 	}
 
-	protected void SavePreferences () 
-	{
-		string dir = System.IO.Path.GetDirectoryName (Filename);
-		Preferences.Set (Preferences.EXPORTHTML_LAST_DIRECTORY, dir);
-
-		Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED, ExportLinked);
-		if (export_all_levels.Active)
-			Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED_DEPTH, "all");
-		else
-			Preferences.Set (Preferences.EXPORTHTML_EXPORT_LINKED_DEPTH, "one");
-	}
-
 	protected void OnExportLinkedToggled (object sender, EventArgs args)
 	{
 		if (export_linked.Active)

Places

File tomboy-html-export-expose-errors.patch of Package tomboy (Revision b4ae65a518a92d988d2325219679050a)

Places