File 001-adf30349-cli-refactor-get_prop.patch of Package virt-manager

Overview Repositories Revisions Requests Users Attributes Meta

File 001-adf30349-cli-refactor-get_prop.patch of Package virt-manager (Revision c028b6a2e0495ad39e2ff6c57f7a0ba8)

Currently displaying revision c028b6a2e0495ad39e2ff6c57f7a0ba8 , Show latest

References: jsc#SLE-6262, fate#327048: KVM: Boot Configuration Override (virt-manager)

Subject: cli: refactor get_prop
From: Marc Hartmayer mhartmay@linux.ibm.com Tue Feb 26 10:56:31 2019 +0100
Date: Wed Mar 6 13:13:13 2019 -0500:
Git: adf30349c3a0cb07674bc00a4aa2f8e278c584a6

Refactor get_prop since it will be used in the next patches at other
places as well.

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

Index: virt-manager-2.1.0/virtinst/cli.py
===================================================================
--- virt-manager-2.1.0.orig/virtinst/cli.py
+++ virt-manager-2.1.0/virtinst/cli.py
@@ -22,7 +22,7 @@ import libvirt
 
 from virtcli import CLIConfig
 
-from . import util
+from . import util, xmlapi
 from .devices import (Device, DeviceController, DeviceDisk, DeviceGraphics,
         DeviceInterface, DevicePanic)
 from .domain import DomainClock, DomainOs
@@ -1223,12 +1223,7 @@ class VirtCLIParser(metaclass=InitClass)
         """
         if not cls.propname:
             return None
-        parent = obj
-        pieces = cls.propname.split(".")
-        for piece in pieces[:-1]:
-            parent = getattr(parent, piece)
-
-        return getattr(parent, pieces[-1])
+        return xmlapi.get_prop(obj, cls.propname)
 
     @classmethod
     def prop_is_list(cls, obj):
Index: virt-manager-2.1.0/virtinst/xmlapi.py
===================================================================
--- virt-manager-2.1.0.orig/virtinst/xmlapi.py
+++ virt-manager-2.1.0/virtinst/xmlapi.py
@@ -11,6 +11,22 @@ from . import util
 # pylint: disable=protected-access
 
 
+def get_prop(obj, prop_path):
+    """Return value of attribute identified by `prop_path`
+
+    Look up the attribute of `obj` identified by `prop_path`
+    (separated by "."). If any component along the path is missing an
+    `AttributeError` is raised.
+
+    """
+    parent = obj
+    pieces = prop_path.split(".")
+    for piece in pieces[:-1]:
+        parent = getattr(parent, piece)
+
+    return getattr(parent, pieces[-1])
+
+
 class _XPathSegment(object):
     """
     Class representing a single 'segment' of an xpath string. For example,

Places

File 001-adf30349-cli-refactor-get_prop.patch of Package virt-manager (Revision c028b6a2e0495ad39e2ff6c57f7a0ba8)

Places