File fix-crash-on-undocking-toolviews.patch of Package kdevelop5

Overview Repositories Revisions Requests Users Attributes Meta

File fix-crash-on-undocking-toolviews.patch of Package kdevelop5 (Revision 1230432bdb8d1cbe02c55797c2532ec6)

Currently displaying revision 1230432bdb8d1cbe02c55797c2532ec6 , Show latest

From 7f636275a2e41d5137ebc24b23cec2412f561404 Mon Sep 17 00:00:00 2001
From: "Friedrich W. H. Kossebau" <kossebau@kde.org>
Date: Mon, 15 Jul 2019 12:38:05 +0200
Subject: sublime: fix crash on undocking toolviews with Qt 5.13

BUG: 409790
FIXED-IN: 5.3.3
---
 kdevplatform/sublime/idealcontroller.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kdevplatform/sublime/idealcontroller.cpp b/kdevplatform/sublime/idealcontroller.cpp
index 218996d..09c3168 100644
--- a/kdevplatform/sublime/idealcontroller.cpp
+++ b/kdevplatform/sublime/idealcontroller.cpp
@@ -147,6 +147,13 @@ void IdealController::addView(Qt::DockWidgetArea area, View* view)
 
 void IdealController::dockLocationChanged(Qt::DockWidgetArea area)
 {
+    // Seems since Qt 5.13 the signal QDockWidget::dockLocationChanged is emitted also when the dock changes
+    // to be floating, with area = Qt::NoDockWidgetArea. The current code is not designed for this,
+    // so just ignore the signal in that case for now
+    if (area == Qt::NoDockWidgetArea) {
+        return;
+    }
+
     IdealDockWidget *dock = qobject_cast<IdealDockWidget*>(sender());
     View *view = dock->view();
     QAction* action = m_view_to_action.value(view);
-- 
cgit v1.1

Places

File fix-crash-on-undocking-toolviews.patch of Package kdevelop5 (Revision 1230432bdb8d1cbe02c55797c2532ec6)

Places