File 0046-Grow_continue_command-ensure-content-is-pr... of Package mdadm

Overview Repositories Revisions Requests Users Attributes Meta

File 0046-Grow_continue_command-ensure-content-is-properly-ini.patch of Package mdadm (Revision 2ff1dacf7db3f9ec79ba4fc439441afa)

Currently displaying revision 2ff1dacf7db3f9ec79ba4fc439441afa , Show latest

From a250ce240f245df594570a5e25398680d403af67 Mon Sep 17 00:00:00 2001
From: NeilBrown <neilb@suse.com>
Date: Thu, 20 Apr 2017 12:40:05 +1000
Subject: [PATCH] Grow_continue_command: ensure 'content' is properly
 initialised.
Git-commit: a250ce240f245df594570a5e25398680d403af67
Patch-mainline: mdadm-4.0+
References: bsc#1069165, bsc#1069167, bsc#1068030

Grow_continue_command() call verify_reshape_position(), which assumes
that info->sys_name is initialised.
'info' in verify_reshape_position() is 'content' in Grow_continue_command().

In the st->ss->external != 0 branch of that function, sysfs_init() is called
to initialize content->sys_name.
In the st->ss->external == 0 branch, ->sys_name is not initialized so
verify_reshape_position() will not do the right thing.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Signed-off-by: Coly Li <colyli@suse.de>

---
 Grow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Grow.c b/Grow.c
index 15f4ed1..c6967ed 100755
--- a/Grow.c
+++ b/Grow.c
@@ -5002,6 +5002,7 @@ int Grow_continue_command(char *devname, int fd,
 			goto Grow_continue_command_exit;
 		}
 		content = &array;
+		sysfs_init(content, fd, NULL);
 		/* Need to load a superblock.
 		 * FIXME we should really get what we need from
 		 * sysfs
-- 
2.10.2

Places

File 0046-Grow_continue_command-ensure-content-is-properly-ini.patch of Package mdadm (Revision 2ff1dacf7db3f9ec79ba4fc439441afa)

Places