File f23b01be-guest-Add-VirtIO-input-devices-to-s390... of Package virt-manager

Overview Repositories Revisions Requests Users Attributes Meta

File f23b01be-guest-Add-VirtIO-input-devices-to-s390x-guests-with-graphics.patch of Package virt-manager (Revision 565be63c0c0a3f9e17f974665ee80abe)

Currently displaying revision 565be63c0c0a3f9e17f974665ee80abe , Show latest

Subject: guest: Add VirtIO input devices to s390x guests with graphics
From: Andrea Bolognani abologna@redhat.com Wed Mar 20 16:52:35 2019 +0100
Date: Thu Mar 21 15:31:20 2019 +0100:
Git: f23b01be53aa8b5b8d91aadbfb0c06268fa5c7b9

We're not including any input devices in the generated XML
for s390x guests, and the results is that it's not possible
to interact with them short of using the serial console or
connecting through ssh, which is fine but probably not what
is expected when graphics are present.

USB input devices are not a good fit for s390x guests: USB
requires PCI, and PCI is not widely available or used on
s390x; VirtIO devices, on the other hand, are a perfect
match since s390x guests use basically no emulated devices
and rely on VirtIO for most functionality.

https://bugzilla.redhat.com/show_bug.cgi?id=1683609

Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Index: virt-manager-2.1.0/virtinst/guest.py
===================================================================
--- virt-manager-2.1.0.orig/virtinst/guest.py
+++ virt-manager-2.1.0/virtinst/guest.py
@@ -622,6 +622,17 @@ class Guest(XMLBuilder):
             dev.bus = "usb"
             self.add_device(dev)
 
+        # s390x guests need VirtIO input devices
+        if self.os.is_s390x() and self.osinfo.supports_virtioinput():
+            dev = DeviceInput(self.conn)
+            dev.type = "tablet"
+            dev.bus = "virtio"
+            self.add_device(dev)
+            dev = DeviceInput(self.conn)
+            dev.type = "keyboard"
+            dev.bus = "virtio"
+            self.add_device(dev)
+
     def _add_default_console_device(self):
         if self.skip_default_console:
             return

Places

File f23b01be-guest-Add-VirtIO-input-devices-to-s390x-guests-with-graphics.patch of Package virt-manager (Revision 565be63c0c0a3f9e17f974665ee80abe)

Places