File 0001-Fix-gst_buffer_unref-assertion-in-chromapr... of Package clementine

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-gst_buffer_unref-assertion-in-chromaprinter.patch of Package clementine (Revision c19ba2309df02f3a9bd5563275d43d5d)

Currently displaying revision c19ba2309df02f3a9bd5563275d43d5d , Show latest

From 8094957e09a43e0dcbaebf36d01b48922119b2c4 Mon Sep 17 00:00:00 2001
From: Jonas Kvinge <jonas@jkvinge.net>
Date: Fri, 26 Apr 2019 20:40:42 +0200
Subject: [PATCH] Fix gst_buffer_unref assertion in chromaprinter

---
 src/musicbrainz/chromaprinter.cpp | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

Index: Clementine-3b76fa62752f25b445ee2a71f02c0c9d7581735a/src/musicbrainz/chromaprinter.cpp
===================================================================
--- Clementine-3b76fa62752f25b445ee2a71f02c0c9d7581735a.orig/src/musicbrainz/chromaprinter.cpp	2019-05-22 12:25:58.153436956 +0200
+++ Clementine-3b76fa62752f25b445ee2a71f02c0c9d7581735a/src/musicbrainz/chromaprinter.cpp	2019-05-22 12:26:34.126826663 +0200
@@ -208,12 +208,16 @@ GstFlowReturn Chromaprinter::NewBufferCa
   Chromaprinter* me = reinterpret_cast<Chromaprinter*>(self);
 
   GstSample* sample = gst_app_sink_pull_sample(app_sink);
+  if (!sample) return GST_FLOW_ERROR;
   GstBuffer* buffer = gst_sample_get_buffer(sample);
-  GstMapInfo map;
-  gst_buffer_map(buffer, &map, GST_MAP_READ);
-  me->buffer_.write(reinterpret_cast<const char*>(map.data), map.size);
-  gst_buffer_unmap(buffer, &map);
-  gst_buffer_unref(buffer);
+  if (buffer) {
+    GstMapInfo map;
+    if (gst_buffer_map(buffer, &map, GST_MAP_READ)) {
+      me->buffer_.write(reinterpret_cast<const char*>(map.data), map.size);
+      gst_buffer_unmap(buffer, &map);
+    }
+  }
+  gst_sample_unref(sample);
 
   return GST_FLOW_OK;
 }

Places

File 0001-Fix-gst_buffer_unref-assertion-in-chromaprinter.patch of Package clementine (Revision c19ba2309df02f3a9bd5563275d43d5d)

Places