File 0001-Fix-potential-use-of-streamer-element-afte... of Package clementine

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-potential-use-of-streamer-element-after-deletion.patch of Package clementine (Revision c19ba2309df02f3a9bd5563275d43d5d)

Currently displaying revision c19ba2309df02f3a9bd5563275d43d5d , Show latest

From 102c529f80c057d90d45c13e10771fcf2742e337 Mon Sep 17 00:00:00 2001
From: Jim Broadus <jbroadus@gmail.com>
Date: Tue, 19 Mar 2019 18:47:19 -0700
Subject: [PATCH] Fix potential use of streamer element after deletion.

If ReplaceDecodeBin fails from TransitionToNext, uridecodebin_ will not be
replaced with a new element. Since TransitionToNext does not check the return
value, it unknowingly deletes uridecodebin_.
---
 src/engines/gstenginepipeline.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: Clementine-36cc5b82f4daf5c2d4e93dc8072665e5a3ca622b/src/engines/gstenginepipeline.cpp
===================================================================
--- Clementine-36cc5b82f4daf5c2d4e93dc8072665e5a3ca622b.orig/src/engines/gstenginepipeline.cpp	2019-02-13 06:02:56.000000000 +0200
+++ Clementine-36cc5b82f4daf5c2d4e93dc8072665e5a3ca622b/src/engines/gstenginepipeline.cpp	2019-03-27 12:24:45.226455370 +0200
@@ -1011,7 +1011,10 @@ void GstEnginePipeline::TransitionToNext
 
   ignore_tags_ = true;
 
-  ReplaceDecodeBin(next_url_);
+  if (!ReplaceDecodeBin(next_url_)) {
+    qLog(Error) << "ReplaceDecodeBin failed with " << next_url_;
+    return;
+  }
   gst_element_set_state(uridecodebin_, GST_STATE_PLAYING);
   MaybeLinkDecodeToAudio();

Places

File 0001-Fix-potential-use-of-streamer-element-after-deletion.patch of Package clementine (Revision c19ba2309df02f3a9bd5563275d43d5d)

Places