File 0001-gst-Prevent-a-crash-when-stopping-device-p... of Package pipewire

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-gst-Prevent-a-crash-when-stopping-device-provider.patch of Package pipewire (Revision c076e4cb0276b89a9345bdfa7ecd0911)

Currently displaying revision c076e4cb0276b89a9345bdfa7ecd0911 , Show latest

From 140374d2071e6204fded4ca65645d4e9a3dd053e Mon Sep 17 00:00:00 2001
From: Philippe Normand <philn@igalia.com>
Date: Fri, 4 Aug 2023 10:01:07 +0100
Subject: [PATCH] gst: Prevent a crash when stopping device provider

The provider might fail to connect to the PipeWire core when starting up, so
when stopping we need to check the core is valid before attempting to acquire a
mutex on its loop.
---
 src/gst/gstpipewiredeviceprovider.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/gst/gstpipewiredeviceprovider.c b/src/gst/gstpipewiredeviceprovider.c
index a9d8dd8b2..9f82507b3 100644
--- a/src/gst/gstpipewiredeviceprovider.c
+++ b/src/gst/gstpipewiredeviceprovider.c
@@ -665,11 +665,16 @@ gst_pipewire_device_provider_stop (GstDeviceProvider * provider)
 {
   GstPipeWireDeviceProvider *self = GST_PIPEWIRE_DEVICE_PROVIDER (provider);
 
-  pw_thread_loop_lock (self->core->loop);
+  /* core might be NULL if we failed to connect in _start. */
+  if (self->core != NULL) {
+    pw_thread_loop_lock (self->core->loop);
+  }
   GST_DEBUG_OBJECT (self, "stopping provider");
 
   g_clear_pointer ((struct pw_proxy**)&self->registry, pw_proxy_destroy);
-  pw_thread_loop_unlock (self->core->loop);
+  if (self->core != NULL) {
+    pw_thread_loop_unlock (self->core->loop);
+  }
   g_clear_pointer (&self->core, gst_pipewire_core_release);
 }
 
-- 
GitLab

Places

File 0001-gst-Prevent-a-crash-when-stopping-device-provider.patch of Package pipewire (Revision c076e4cb0276b89a9345bdfa7ecd0911)

Places