File qpdf-data-loss-fix.patch of Package qpdf

Overview Repositories Revisions Requests Users Attributes Meta

File qpdf-data-loss-fix.patch of Package qpdf (Revision 84b4b318e0d2392c1651b6c5d276bb4d)

Currently displaying revision 84b4b318e0d2392c1651b6c5d276bb4d , Show latest

From 4bc434000c42a7191e705c8a38216ca6743ad9ff Mon Sep 17 00:00:00 2001
From: Jay Berkenbilt <ejb@ql.org>
Date: Thu, 17 Jan 2019 08:50:19 -0500
Subject: [PATCH] Copy subdictionaries when removing resources (fixes #276)

When removing unreferenced resources, the code was copying the overall
resource dictionaries but not the subdictionaries being modified. This
was a "typo" in the code -- the comment clearly stated the need to do
this, but the code replaced the dictionary with itself rather than
with a shallow copy of itself.
---
 libqpdf/QPDFPageObjectHelper.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libqpdf/QPDFPageObjectHelper.cc b/libqpdf/QPDFPageObjectHelper.cc
index 611f33ea..ba647372 100644
--- a/libqpdf/QPDFPageObjectHelper.cc
+++ b/libqpdf/QPDFPageObjectHelper.cc
@@ -156,6 +156,7 @@ QPDFPageObjectHelper::removeUnreferencedResources()
         {
             continue;
         }
+        dict = dict.shallowCopy();
         resources.replaceKey(*d_iter, dict);
         std::set<std::string> keys = dict.getKeys();
         for (std::set<std::string>::iterator k_iter = keys.begin();

Places

File qpdf-data-loss-fix.patch of Package qpdf (Revision 84b4b318e0d2392c1651b6c5d276bb4d)

Places