File 813c775c-fix-filename-leak-on-transfer-dialog.p... of Package virt-viewer

Overview Repositories Revisions Requests Users Attributes Meta

File 813c775c-fix-filename-leak-on-transfer-dialog.patch of Package virt-viewer (Revision ff14302b96100adfe395a5698cbf1a40)

Currently displaying revision ff14302b96100adfe395a5698cbf1a40 , Show latest

Subject: Fix filename leak on transfer dialog
From: Victor Toso victortoso@redhat.com Wed Aug 3 15:40:14 2016 +0200
Date: Fri Aug 5 10:59:23 2016 +0200:
Git: 813c775cc9a111ddb0be9e32e797c61fb797fa55

spice_file_transfer_task_get_filename() was wrongly annotated as
transfer none. We can safely free this string after usage.

Index: virt-viewer-4.0/src/virt-viewer-file-transfer-dialog.c
===================================================================
--- virt-viewer-4.0.orig/src/virt-viewer-file-transfer-dialog.c
+++ virt-viewer-4.0/src/virt-viewer-file-transfer-dialog.c
@@ -101,11 +101,14 @@ typedef struct {
 static TaskWidgets *task_widgets_new(SpiceFileTransferTask *task)
 {
     TaskWidgets *w = g_new0(TaskWidgets, 1);
+    gchar *filename;
 
     w->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 6);
     w->hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 12);
     w->progress = gtk_progress_bar_new();
-    w->label = gtk_label_new(spice_file_transfer_task_get_filename(task));
+    filename = spice_file_transfer_task_get_filename(task);
+    w->label = gtk_label_new(filename);
+    g_free(filename);
     w->cancel = gtk_button_new_from_icon_name("gtk-cancel", GTK_ICON_SIZE_SMALL_TOOLBAR);
     gtk_widget_set_hexpand(w->progress, TRUE);
     gtk_widget_set_valign(w->progress, GTK_ALIGN_CENTER);

Places

File 813c775c-fix-filename-leak-on-transfer-dialog.patch of Package virt-viewer (Revision ff14302b96100adfe395a5698cbf1a40)

Places