File virtview-git-transport-segv.patch of Package virt-viewer

Overview Repositories Revisions Requests Users Attributes Meta

File virtview-git-transport-segv.patch of Package virt-viewer (Revision 8fb4fcd80bb1b9900acbd2446bec9e83)

Currently displaying revision 8fb4fcd80bb1b9900acbd2446bec9e83 , Show latest

Subject: Don't SIGSEGV if no transport is used.
From: Michal Privoznik mprivozn@redhat.com Wed Nov 14 15:20:58 2012 +0100
Date: Wed Nov 14 15:20:58 2012 +0100:
Git: 9983fe74dd7eae1fac17bafa31ae44995ce28769

One of previous commits (74b1b62510d939) allowed us to connect to
localhost directly if ssh transport was used. However, if there's
not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as
one of arguments. Change this to g_strcmp0 which does the same
service but is more friendly to NULL arguments.

Index: virt-viewer-0.5.4/src/virt-viewer.c
===================================================================
--- virt-viewer-0.5.4.orig/src/virt-viewer.c
+++ virt-viewer-0.5.4/src/virt-viewer.c
@@ -376,7 +376,7 @@ virt_viewer_extract_connect_info(VirtVie
      */
     if (virt_viewer_replace_host(ghost)) {
         gchar *replacement_host = NULL;
-        if (g_str_equal(transport, "ssh")) {
+        if (g_strcmp0(transport, "ssh") == 0) {
             replacement_host = g_strdup("localhost");
         } else {
             replacement_host = g_strdup(host);

Places

File virtview-git-transport-segv.patch of Package virt-viewer (Revision 8fb4fcd80bb1b9900acbd2446bec9e83)

Places