File srp_daemon-handle-SM-lid-change.patch of Package rdma-core

Overview Repositories Revisions Requests Users Attributes Meta

File srp_daemon-handle-SM-lid-change.patch of Package rdma-core (Revision d6bf959a81ab0372808dff6945929ddf)

Currently displaying revision d6bf959a81ab0372808dff6945929ddf , Show latest

commit 2fbc501061218e7df8e37bb2df6db73e00005e9b
Author: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
Date:   Mon Dec 4 15:15:55 2017 +0100

srp_daemon: handle SM lid change
    
    When srp_daemon was running and the master SM host changes,
     srp_daemon output these errors at every scan:
    srp_daemon[25394]: No response to inform info registration
    srp_daemon[25394]: Fail to register to traps, maybe there is no opensm
     running on fabric or IB port is down
    
    This was introduced by commit 4952e5f Fix a memory leak.
    A side effect of this patch was that create_ah was only called when the
     port lid changes. Which meant register_to_traps used an older, obsolete,
     version of sm_lid and failed to connect to it.
    
    This patch fixes this behaviour by checking for both local lid changes and
     SM lid changes, and calling create_ah on any of these events.
    
    Fixes: 4952e5f7 (Fix a memory leak)
    Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
    Cc: stable@linux-rdma.org # v14, v15, v16

diff --git srp_daemon/srp_daemon.c srp_daemon/srp_daemon.c
index 2465ccd9..36df5c3b 100644
--- srp_daemon/srp_daemon.c
+++ srp_daemon/srp_daemon.c
@@ -1103,7 +1103,7 @@ static int get_shared_pkeys(struct resources *res,
 	int i, num_pkeys = 0;
 	uint16_t pkey;
 	uint16_t local_port_lid = get_port_lid(res->ud_res->ib_ctx,
-					       config->port_num);
+					       config->port_num, NULL);
 
 	in_mad_buf = malloc(sizeof(struct ib_user_mad) +
 			    node_table_response_size);
@@ -2092,7 +2092,7 @@ int main(int argc, char *argv[])
 {
 	int			ret;
 	struct resources       *res;
-	uint16_t 		lid;
+	uint16_t 		lid, sm_lid;
 	uint16_t 		pkey;
 	union umad_gid 		gid;
 	struct target_details  *target;
@@ -2196,8 +2196,10 @@ catas_start:
 
 			pr_debug("Starting a recalculation\n");
 			port_lid = get_port_lid(res->ud_res->ib_ctx,
-					   config->port_num);
-			if (port_lid != res->ud_res->port_attr.lid) {
+						config->port_num, &sm_lid);
+			if (port_lid != res->ud_res->port_attr.lid ||
+				sm_lid != res->ud_res->port_attr.sm_lid) {
+
 				if (res->ud_res->ah) {
 					ibv_destroy_ah(res->ud_res->ah);
 					res->ud_res->ah = NULL;
diff --git srp_daemon/srp_daemon.h srp_daemon/srp_daemon.h
index 5d268ed3..864b3d42 100644
--- srp_daemon/srp_daemon.h
+++ srp_daemon/srp_daemon.h
@@ -299,7 +299,7 @@ void *run_thread_listen_to_events(void *res_in);
 int get_node(struct umad_resources *umad_res, uint16_t dlid, uint64_t *guid);
 int create_trap_resources(struct ud_resources *ud_res);
 int register_to_traps(struct resources *res, int subscribe);
-uint16_t get_port_lid(struct ibv_context *ib_ctx, int port_num);
+uint16_t get_port_lid(struct ibv_context *ib_ctx, int port_num, uint16_t *sm_lid);
 int create_ah(struct ud_resources *ud_res);
 void push_gid_to_list(struct sync_resources *res, union umad_gid *gid,
 		      uint16_t pkey);
diff --git srp_daemon/srp_handle_traps.c srp_daemon/srp_handle_traps.c
index 6d94634e..25f2b9ab 100644
--- srp_daemon/srp_handle_traps.c
+++ srp_daemon/srp_handle_traps.c
@@ -340,12 +340,20 @@ int ud_resources_create(struct ud_resources *res)
 	return 0;
 }
 
-uint16_t get_port_lid(struct ibv_context *ib_ctx, int port_num)
+uint16_t get_port_lid(struct ibv_context *ib_ctx, int port_num, uint16_t *sm_lid)
 {
 	struct ibv_port_attr port_attr;
+	int ret;
+
+	ret = ibv_query_port(ib_ctx, port_num, &port_attr);
 
-	return ibv_query_port(ib_ctx, port_num, &port_attr) == 0 ?
-		port_attr.lid : 0;
+	if (!ret) {
+		if (sm_lid)
+			*sm_lid = port_attr.sm_lid;
+		return port_attr.lid;
+	}
+
+	return 0;
 }
 
 int create_ah(struct ud_resources *ud_res)

Places

File srp_daemon-handle-SM-lid-change.patch of Package rdma-core (Revision d6bf959a81ab0372808dff6945929ddf)

Places