File 0001-impl-node-improve-suspend.patch of Package pipewire

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-impl-node-improve-suspend.patch of Package pipewire (Revision c46b4298976efb5fe8fb8ab19942c393)

Currently displaying revision c46b4298976efb5fe8fb8ab19942c393 , Show latest

From 3b052eaa9986c2f5182eb8a1b2f2b5c10be31a12 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Thu, 24 Aug 2023 09:50:28 +0200
Subject: [PATCH] impl-node: improve suspend

Make sure we can only suspend when the node is (going to) IDLE. We don't
really want to allow applications to suspend a node that is running or
starting up.

This might fix a race when a node is suspended at the same time it is
started and cause silence. It also fixes the issue of total silence when
doing "pactl suspend <node> 1" on a running node.

See #3378
---
 src/pipewire/impl-node.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/pipewire/impl-node.c b/src/pipewire/impl-node.c
index ca431c389..ff9effedc 100644
--- a/src/pipewire/impl-node.c
+++ b/src/pipewire/impl-node.c
@@ -591,6 +591,7 @@ static int node_send_command(void *object, const struct spa_command *command)
 {
 	struct resource_data *data = object;
 	struct pw_impl_node *node = data->node;
+	struct impl *impl = SPA_CONTAINER_OF(node, struct impl, this);
 	uint32_t id = SPA_NODE_COMMAND_ID(command);
 
 	pw_log_debug("%p: got command %d (%s)", node, id,
@@ -598,7 +599,9 @@ static int node_send_command(void *object, const struct spa_command *command)
 
 	switch (id) {
 	case SPA_NODE_COMMAND_Suspend:
-		suspend_node(node);
+		if (node->info.state == PW_NODE_STATE_ERROR ||
+		    impl->pending_state == PW_NODE_STATE_IDLE)
+			suspend_node(node);
 		break;
 	default:
 		spa_node_send_command(node->node, command);
-- 
GitLab

Places

File 0001-impl-node-improve-suspend.patch of Package pipewire (Revision c46b4298976efb5fe8fb8ab19942c393)

Places