File gst-ugly-fix-caps-and-memory-leaks.patch of Package gstreamer-plugins-ugly

Overview Repositories Revisions Requests Users Attributes Meta

File gst-ugly-fix-caps-and-memory-leaks.patch of Package gstreamer-plugins-ugly (Revision 9d1a055bc4072ab02216a75f37bcc9ca)

Currently displaying revision 9d1a055bc4072ab02216a75f37bcc9ca , Show latest

From b93b55cc62e5e5d99afb2642fe55e108827569b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= <tim@centricular.com>
Date: Sat, 15 Jul 2017 14:59:42 +0100
Subject: x264enc: fix caps leak

Move creation of supported sink pads into class_init function
which is also the only place where they're used. Unref the
caps when no longer needed, the pad template will take its
own ref.

https://bugzilla.gnome.org/show_bug.cgi?id=784982

diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c
index 49d99f1..4287cf9 100644
--- a/ext/x264/gstx264enc.c
+++ b/ext/x264/gstx264enc.c
@@ -140,7 +140,6 @@ struct _GstX264EncVTable
 static GstX264EncVTable default_vtable;
 
 static GstX264EncVTable *vtable_8bit = NULL, *vtable_10bit = NULL;
-static GstCaps *supported_sinkcaps = NULL;
 
 #define LOAD_SYMBOL(name) G_STMT_START { \
   if (!g_module_symbol (module, #name, (gpointer *) &vtable->name)) { \
@@ -324,14 +323,6 @@ load_x264_libraries (void)
   if (!vtable_8bit && !vtable_10bit)
     return FALSE;
 
-  supported_sinkcaps = gst_caps_new_simple ("video/x-raw",
-      "framerate", GST_TYPE_FRACTION_RANGE, 0, 1, G_MAXINT, 1,
-      "width", GST_TYPE_INT_RANGE, 16, G_MAXINT,
-      "height", GST_TYPE_INT_RANGE, 16, G_MAXINT, NULL);
-
-  gst_x264_enc_add_x264_chroma_format (gst_caps_get_structure
-      (supported_sinkcaps, 0), TRUE, TRUE, TRUE);
-
   return TRUE;
 }
 
@@ -874,6 +865,7 @@ gst_x264_enc_class_init (GstX264EncClass * klass)
   GstVideoEncoderClass *gstencoder_class;
   const gchar *partitions = NULL;
   GstPadTemplate *sink_templ;
+  GstCaps *supported_sinkcaps;
 
   x264enc_defaults = g_string_new ("");
 
@@ -1134,9 +1126,19 @@ gst_x264_enc_class_init (GstX264EncClass * klass)
       "Josef Zlomek <josef.zlomek@itonis.tv>, "
       "Mark Nauwelaerts <mnauw@users.sf.net>");
 
+  supported_sinkcaps = gst_caps_new_simple ("video/x-raw",
+      "framerate", GST_TYPE_FRACTION_RANGE, 0, 1, G_MAXINT, 1,
+      "width", GST_TYPE_INT_RANGE, 16, G_MAXINT,
+      "height", GST_TYPE_INT_RANGE, 16, G_MAXINT, NULL);
+
+  gst_x264_enc_add_x264_chroma_format (gst_caps_get_structure
+      (supported_sinkcaps, 0), TRUE, TRUE, TRUE);
+
   sink_templ = gst_pad_template_new ("sink",
       GST_PAD_SINK, GST_PAD_ALWAYS, supported_sinkcaps);
 
+  gst_caps_unref (supported_sinkcaps);
+
   gst_element_class_add_pad_template (element_class, sink_templ);
   gst_element_class_add_static_pad_template (element_class, &src_factory);
 }
-- 
cgit v0.10.2

From f0fb1135c676e90cf8036ad2ef4bb56bf9f5348a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= <tim@centricular.com>
Date: Sat, 15 Jul 2017 14:57:49 +0100
Subject: mpg123audiodec: fix caps leak

The pad template takes its own ref, so we should unref the caps.

https://bugzilla.gnome.org/show_bug.cgi?id=784982

diff --git a/ext/mpg123/gstmpg123audiodec.c b/ext/mpg123/gstmpg123audiodec.c
index cfd017e..fa6743c 100644
--- a/ext/mpg123/gstmpg123audiodec.c
+++ b/ext/mpg123/gstmpg123audiodec.c
@@ -167,6 +167,7 @@ gst_mpg123_audio_dec_class_init (GstMpg123AudioDecClass * klass)
     src_template_caps = gst_caps_from_string (s->str);
     src_template = gst_pad_template_new ("src", GST_PAD_SRC, GST_PAD_ALWAYS,
         src_template_caps);
+    gst_caps_unref (src_template_caps);
 
     g_string_free (s, TRUE);
   }
-- 
cgit v0.10.2

From f0a224a90871fd07d1aaf3589482654a548dc388 Mon Sep 17 00:00:00 2001
From: Satya Prakash Gupta <sp.gupta@samsung.com>
Date: Tue, 25 Jul 2017 13:36:17 +0530
Subject: dvdreadsrc: Fix string memory leak

https://bugzilla.gnome.org/show_bug.cgi?id=785388

diff --git a/ext/dvdread/dvdreadsrc.c b/ext/dvdread/dvdreadsrc.c
index 234f251..18e9f70 100644
--- a/ext/dvdread/dvdreadsrc.c
+++ b/ext/dvdread/dvdreadsrc.c
@@ -559,6 +559,7 @@ gst_dvd_read_src_goto_title (GstDvdReadSrc * src, gint title, gint angle)
       lang_code[0] = (u->lang_code >> 8) & 0xff;
       lang_code[1] = u->lang_code & 0xff;
       gst_structure_set (s, t, G_TYPE_STRING, lang_code, NULL);
+      g_free (t);
       t = g_strdup_printf ("subpicture-%d-stream", i);
       gst_structure_set (s, t, G_TYPE_INT, (int) sid, NULL);
       g_free (t);
-- 
cgit v0.10.2

Places

File gst-ugly-fix-caps-and-memory-leaks.patch of Package gstreamer-plugins-ugly (Revision 9d1a055bc4072ab02216a75f37bcc9ca)

Places