File iplink-double-the-buffer-size-also-in-iplink_ge... of Package iproute2

Overview Repositories Revisions Requests Users Attributes Meta

File iplink-double-the-buffer-size-also-in-iplink_get.patch of Package iproute2 (Revision a676a75422eb4a29196697ff288fcc87)

Currently displaying revision a676a75422eb4a29196697ff288fcc87 , Show latest

From: Michal Kubecek <mkubecek@suse.cz>
Date: Fri, 1 Sep 2017 18:39:16 +0200
Subject: iplink: double the buffer size also in iplink_get()
Patch-mainline: v4.13.0
Git-commit: 460c03f3f3cc436ff4673d75722ba68a6ec9343d
References: bsc#1056261

Commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") increased
the buffer size for "ip link show" command to 32 KB to handle NICs with
large number of VFs. With "dev" filter, a different code path is taken and
iplink_get() still uses only 16 KB buffer.

The size of 32768 is not very future-proof as NICs supporting 120-128 VFs
are already in use so that single RTM_NEWLINK message in the dump can
exceed 30000 bytes. But it's what rtnl_talk() and rtnl_dump_filter_l() use
so let's be consistent. Once this proves insufficient, all three sizes
should be increased.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

---
 ip/iplink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/iplink.c b/ip/iplink.c
index 8d811ae83bca..215c1f515520 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -1020,7 +1020,7 @@ int iplink_get(unsigned int flags, char *name, __u32 filt_mask)
 	};
 	struct {
 		struct nlmsghdr n;
-		char buf[16384];
+		char buf[32768];
 	} answer;
 
 	if (name) {
-- 
2.14.1

Places

File iplink-double-the-buffer-size-also-in-iplink_get.patch of Package iproute2 (Revision a676a75422eb4a29196697ff288fcc87)

Places