File 0081-wdc-Fix-strncpy-warning.patch of Package nvme-cli

Overview Repositories Revisions Requests Users Attributes Meta

File 0081-wdc-Fix-strncpy-warning.patch of Package nvme-cli (Revision ae92a91306e7a3b1140279fd37e16eea)

Currently displaying revision ae92a91306e7a3b1140279fd37e16eea , Show latest

From 326306a7361fc129f1311176fe47810361e06780 Mon Sep 17 00:00:00 2001
From: Keith Busch <keith.busch@intel.com>
Date: Wed, 24 Oct 2018 10:21:56 -0600
Subject: [PATCH] wdc: Fix strncpy warning

Some compilers were complaining copying from the constant source was
truncating it. The size is supposed to protect the destination buffer,
so this patch uses that size instead.

Signed-off-by: Keith Busch <keith.busch@intel.com>
---
 wdc-nvme.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/wdc-nvme.c b/wdc-nvme.c
index 55b2889..8d61fa7 100644
--- a/wdc-nvme.c
+++ b/wdc-nvme.c
@@ -1148,9 +1148,9 @@ static int wdc_crash_dump(int fd, char *file, int type)
 	}
 
 	if (type == WDC_NVME_PFAIL_DUMP_TYPE)
-		strncpy(dump_type, "_pfail_dump", 11);
+		strncpy(dump_type, "_pfail_dump", PATH_MAX - 1);
 	else
-		strncpy(dump_type, "_crash_dump", 11);
+		strncpy(dump_type, "_crash_dump", PATH_MAX - 1);
 
 	if (wdc_get_serial_name(fd, f, PATH_MAX, dump_type) == -1) {
 		fprintf(stderr, "ERROR : WDC : failed to generate file name\n");
-- 
2.13.7

Places

File 0081-wdc-Fix-strncpy-warning.patch of Package nvme-cli (Revision ae92a91306e7a3b1140279fd37e16eea)

Places