File replace-obsolete-network-configuration-commands... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File replace-obsolete-network-configuration-commands-in-s.patch of Package xen (Revision da1aeaf971c983a736d9e8c175f8b853)

Currently displaying revision da1aeaf971c983a736d9e8c175f8b853 , Show latest

From 5e1e18fde92bae1ae87f78d470e80b1ffc9350d1 Mon Sep 17 00:00:00 2001
From: Michal Kubecek <mkubecek@suse.cz>
Date: Wed, 26 Jul 2017 10:28:54 +0200
Subject: [PATCH] replace obsolete network configuration commands in scripts

Some scripts still use obsolete network configuration commands ifconfig and
brctl. Replace them by commands from iproute2 package.
---
 README                                                     |  3 +--
 tools/hotplug/Linux/colo-proxy-setup                       | 14 ++++++--------
 tools/hotplug/Linux/remus-netbuf-setup                     |  3 ++-
 tools/hotplug/Linux/vif-bridge                             |  7 ++++---
 tools/hotplug/Linux/vif-nat                                |  2 +-
 tools/hotplug/Linux/vif-route                              |  6 ++++--
 tools/hotplug/Linux/vif2                                   |  6 +++---
 tools/hotplug/Linux/xen-network-common.sh                  |  6 ++----
 .../i386-dm/qemu-ifup-Linux                                |  5 +++--
 9 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/README b/README
index de13bf4ae803..27f3074c62cd 100644
--- a/README
+++ b/README
@@ -57,8 +57,7 @@ provided by your OS distributor:
     * Development install of GLib v2.0 (e.g. libglib2.0-dev)
     * Development install of Pixman (e.g. libpixman-1-dev)
     * pkg-config
-    * bridge-utils package (/sbin/brctl)
-    * iproute package (/sbin/ip)
+    * iproute package (/sbin/ip, /sbin/bridge)
     * GNU bison and GNU flex
     * GNU gettext
     * ACPI ASL compiler (iasl)
diff --git a/tools/hotplug/Linux/colo-proxy-setup b/tools/hotplug/Linux/colo-proxy-setup
index 94e203445282..aa3eaaf02dd7 100755
--- a/tools/hotplug/Linux/colo-proxy-setup
+++ b/tools/hotplug/Linux/colo-proxy-setup
@@ -76,10 +76,9 @@ function teardown_primary()
 
 function setup_secondary()
 {
-    do_without_error brctl delif $bridge $vifname
-    do_without_error brctl addbr $forwardbr
-    do_without_error brctl addif $forwardbr $vifname
-    do_without_error brctl addif $forwardbr $forwarddev
+    do_without_error ip link add "$forwardbr" type bridge
+    do_without_error ip link set "$vifname" master "$forwardbr"
+    do_without_error ip link set "$forwarddev" master "$forwardbr"
     do_without_error ip link set dev $forwardbr up
     do_without_error modprobe xt_SECCOLO
 
@@ -91,10 +90,9 @@ function setup_secondary()
 
 function teardown_secondary()
 {
-    do_without_error brctl delif $forwardbr $forwarddev
-    do_without_error brctl delif $forwardbr $vifname
-    do_without_error brctl delbr $forwardbr
-    do_without_error brctl addif $bridge $vifname
+    do_without_error ip link set "$forwarddev" nomaster
+    do_without_error ip link set "$vifname" master "$bridge"
+    do_without_error ip link del "$forwardbr"
 
     do_without_error iptables -t mangle -D PREROUTING -m physdev --physdev-in \
         $vifname -j SECCOLO --index $index
diff --git a/tools/hotplug/Linux/remus-netbuf-setup b/tools/hotplug/Linux/remus-netbuf-setup
index 87dfa6977864..4cca30374a16 100644
--- a/tools/hotplug/Linux/remus-netbuf-setup
+++ b/tools/hotplug/Linux/remus-netbuf-setup
@@ -139,8 +139,9 @@ check_ifb() {
 
 setup_ifb() {
 
-    for ifb in `ifconfig -a -s|egrep ^ifb|cut -d ' ' -f1`
+    for ifb in $(ip --oneline link show type ifb | cut -d ' ' -f2)
     do
+        ifb="${ifb%:}"
         check_ifb "$ifb" || continue
         REMUS_IFB="$ifb"
         break
diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge
index a10b16d84704..db4eae635ecb 100644
--- a/tools/hotplug/Linux/vif-bridge
+++ b/tools/hotplug/Linux/vif-bridge
@@ -40,7 +40,8 @@ bridge=$(xenstore_read_default "$XENBUS_PATH/bridge" "$bridge")
 
 if [ -z "$bridge" ]
 then
-  bridge=$(brctl show | awk 'NR==2{print$1}')
+  bridge=$(ip --oneline link show type bridge | awk '(NR == 1) { print $2; }')
+  bridge="${bridge%:}"
 
   if [ -z "$bridge" ]
   then
@@ -89,8 +90,8 @@ case "$command" in
         ;;
 
     offline)
-        do_without_error brctl delif "$bridge" "$dev"
-        do_without_error ifconfig "$dev" down
+        do_without_error ip link set "$dev" nomaster
+        do_without_error ip link set "$dev" down
         ;;
 
     add)
diff --git a/tools/hotplug/Linux/vif-nat b/tools/hotplug/Linux/vif-nat
index a76d9c784b5f..d06d31d50df0 100644
--- a/tools/hotplug/Linux/vif-nat
+++ b/tools/hotplug/Linux/vif-nat
@@ -174,7 +174,7 @@ case "$command" in
         ;;
     offline)
         [ "$dhcp" != 'no' ] && dhcp_down
-        do_without_error ifconfig "${dev}" down
+        do_without_error ip link set "${dev}" down
         ;;
 esac
 
diff --git a/tools/hotplug/Linux/vif-route b/tools/hotplug/Linux/vif-route
index d49eb20795bf..98798fe5e4c3 100644
--- a/tools/hotplug/Linux/vif-route
+++ b/tools/hotplug/Linux/vif-route
@@ -23,13 +23,15 @@ main_ip=$(dom0_ip)
 
 case "${command}" in
     online)
-        ifconfig ${dev} ${main_ip} netmask 255.255.255.255 up
+        ip addr add "${main_ip}/32" dev "$dev"
+        ip link set "dev" up
         echo 1 >/proc/sys/net/ipv4/conf/${dev}/proxy_arp
         ipcmd='add'
         cmdprefix=''
         ;;
     offline)
-        do_without_error ifdown ${dev}
+        do_without_error ip addr flush dev "$dev"
+        do_without_error ip link set "$dev" down
         ipcmd='del'
         cmdprefix='do_without_error'
         ;;
diff --git a/tools/hotplug/Linux/vif2 b/tools/hotplug/Linux/vif2
index 2c155be68c2c..dff180b1d7a2 100644
--- a/tools/hotplug/Linux/vif2
+++ b/tools/hotplug/Linux/vif2
@@ -7,13 +7,13 @@ dir=$(dirname "$0")
 bridge=$(xenstore_read_default "$XENBUS_PATH/bridge" "$bridge")
 if [ -z "$bridge" ]
     then
-    nr_bridges=$(($(brctl show | cut -f 1 | grep -v "^$" | wc -l) - 1))
+    nr_bridges=$(ip --oneline link show type bridge | wc -l)
     if [ "$nr_bridges" != 1 ]
 	then
 	fatal "no bridge specified, and don't know which one to use ($nr_bridges found)"
     fi
-    bridge=$(brctl show | cut -d "
-" -f 2 | cut -f 1)
+    bridge=$(ip --oneline link show type bridge | head -1 | cut -d ' ' -f2)
+    bridge="${bridge%:}"
 fi
 
 command="$1"
diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
index 92ffa603f7e5..7e1ae94dc6d9 100644
--- a/tools/hotplug/Linux/xen-network-common.sh
+++ b/tools/hotplug/Linux/xen-network-common.sh
@@ -111,9 +111,7 @@ create_bridge () {
 
     # Don't create the bridge if it already exists.
     if [ ! -e "/sys/class/net/${bridge}/bridge" ]; then
-	brctl addbr ${bridge}
-	brctl stp ${bridge} off
-	brctl setfd ${bridge} 0
+	ip link add "$bridge" type bridge stp_state 0 forward_delay 0
     fi
 }
 
@@ -127,7 +125,7 @@ add_to_bridge () {
 	ip link set dev ${dev} up || true
 	return
     fi
-    brctl addif ${bridge} ${dev}
+    ip link set "$dev" master "$bridge"
     ip link set dev ${dev} up
 }

Places

File replace-obsolete-network-configuration-commands-in-s.patch of Package xen (Revision da1aeaf971c983a736d9e8c175f8b853)

Places