File gnome-shell-cleanup-signal-handlers-on-destroy.... of Package gnome-shell

Overview Repositories Revisions Requests Users Attributes Meta

File gnome-shell-cleanup-signal-handlers-on-destroy.patch of Package gnome-shell (Revision ac63402217813384ce73237ebe511580)

Currently displaying revision ac63402217813384ce73237ebe511580 , Show latest

From 7945c56a9f2cb5c2dc8736bc46e92d225cca9251 Mon Sep 17 00:00:00 2001
From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Mon, 17 Oct 2011 15:18:25 +0200
Subject: [PATCH] IMStatusChooserItem: clean up signal handlers on destroy()

Extensions (like alternative-status-menu) expect that calling
destroy() on a menu item will not leave signal handlers around.

https://bugzilla.gnome.org/show_bug.cgi?id=660520
---
 js/ui/userMenu.js |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/js/ui/userMenu.js b/js/ui/userMenu.js
index 40ca2f3..8bedfb9 100644
--- a/js/ui/userMenu.js
+++ b/js/ui/userMenu.js
@@ -199,6 +199,21 @@ IMStatusChooserItem.prototype = {
         }));
     },
 
+    destroy: function() {
+        // clean up signal handlers
+        if (this._userLoadedId != 0) {
+            this._user.disconnect(this._userLoadedId);
+            this._userLoadedId = 0;
+        }
+
+        if (this._userChangedId != 0) {
+            this._user.disconnect(this._userChangedId);
+            this._userChangedId = 0;
+        }
+
+        PopupMenu.PopupBaseMenuItem.prototype.destroy.call(this);
+    },
+
     // Override getColumnWidths()/setColumnWidths() to make the item
     // independent from the overall column layout of the menu
     getColumnWidths: function() {
-- 
1.7.6.4

Places

File gnome-shell-cleanup-signal-handlers-on-destroy.patch of Package gnome-shell (Revision ac63402217813384ce73237ebe511580)

Places