File openssl-dsa_paramgen2_check.patch of Package openssl-1_1

Overview Repositories Revisions Requests Users Attributes Meta

File openssl-dsa_paramgen2_check.patch of Package openssl-1_1 (Revision 2e631cef87c265252fa197ea111e7610)

Currently displaying revision 2e631cef87c265252fa197ea111e7610 , Show latest

From 3afd38b277a806b901e039c6ad281c5e5c97ef67 Mon Sep 17 00:00:00 2001
From: Vitezslav Cizek <vcizek@suse.com>
Date: Thu, 25 Oct 2018 13:53:26 +0200
Subject: [PATCH] DSA: Check for sanity of input parameters

dsa_builtin_paramgen2 expects the L parameter to be greater than N,
otherwise the generation will get stuck in an infinite loop.

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7493)
---
 crypto/dsa/dsa_gen.c | 6 ++++++
 1 file changed, 6 insertions(+)

Index: openssl-1.1.0i/crypto/dsa/dsa_gen.c
===================================================================
--- openssl-1.1.0i.orig/crypto/dsa/dsa_gen.c	2018-11-05 11:49:00.917987206 +0100
+++ openssl-1.1.0i/crypto/dsa/dsa_gen.c	2018-11-05 11:49:01.301989321 +0100
@@ -357,6 +357,12 @@ int dsa_builtin_paramgen2(DSA *ret, size
     }
 # endif
 
+    /* make sure L > N, otherwise we'll get trapped in an infinite loop */
+    if (L <= N) {
+        DSAerr(DSA_F_DSA_BUILTIN_PARAMGEN2, DSA_R_INVALID_PARAMETERS);
+        goto err;
+    }
+
     if (evpmd == NULL) {
         if (N == 160)
             evpmd = EVP_sha1();

Places

File openssl-dsa_paramgen2_check.patch of Package openssl-1_1 (Revision 2e631cef87c265252fa197ea111e7610)

Places