File 0001-Stop-multiplying-duration-values.patch of Package plasma5-desktop

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Stop-multiplying-duration-values.patch of Package plasma5-desktop

From 757df5031279ac7ebe608bf5a43fbc0b0088a202 Mon Sep 17 00:00:00 2001
From: Nate Graham <nate@kde.org>
Date: Tue, 24 Mar 2020 08:15:12 -0600
Subject: [PATCH] Stop multiplying duration values

Summary:
After D28144, some animations are now too long because they were inappropriately
multiplying a duration value. That's no longer necessary, so let's remove the
multiplication.

Depends on D28144

Test Plan: Various things that were a bit too slow before feel just right now

Reviewers: #vdg, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28239
---
 applets/taskmanager/package/contents/ui/Task.qml           | 2 +-
 applets/taskmanager/package/contents/ui/TaskList.qml       | 2 +-
 .../contents/configuration/PanelConfiguration.qml          | 4 ++--
 desktoppackage/contents/explorer/WidgetExplorer.qml        | 7 +++----
 toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml     | 6 +++---
 5 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/applets/taskmanager/package/contents/ui/Task.qml b/applets/taskmanager/package/contents/ui/Task.qml
index 1327f35e0..b85578d13 100644
--- a/applets/taskmanager/package/contents/ui/Task.qml
+++ b/applets/taskmanager/package/contents/ui/Task.qml
@@ -293,7 +293,7 @@ MouseArea {
         Timer {
             id: timer
 
-            interval: units.longDuration * 2
+            interval: units.longDuration
             repeat: false
 
             onTriggered: {
diff --git a/applets/taskmanager/package/contents/ui/TaskList.qml b/applets/taskmanager/package/contents/ui/TaskList.qml
index 594420baa..6d6bc456c 100644
--- a/applets/taskmanager/package/contents/ui/TaskList.qml
+++ b/applets/taskmanager/package/contents/ui/TaskList.qml
@@ -34,7 +34,7 @@ Flow {
             NumberAnimation {
                 properties: "x, y"
                 easing.type: Easing.OutQuad
-                duration: units.longDuration * 2
+                duration: units.longDuration
             }
 
             PropertyAction { target: taskList; property: "animating"; value: false }
diff --git a/desktoppackage/contents/configuration/PanelConfiguration.qml b/desktoppackage/contents/configuration/PanelConfiguration.qml
index 0e11a964d..33e3fbc05 100644
--- a/desktoppackage/contents/configuration/PanelConfiguration.qml
+++ b/desktoppackage/contents/configuration/PanelConfiguration.qml
@@ -103,7 +103,7 @@ PlasmaCore.FrameSvgItem {
                     return panel.screenGeometry.y + panel.screenGeometry.height - panel.height - panel.distance
                 }
             }
-            duration: units.shortDuration * 3
+            duration: units.shortDuration
         }
 
         NumberAnimation {
@@ -122,7 +122,7 @@ PlasmaCore.FrameSvgItem {
                     return panel.screenGeometry.y + panel.screenGeometry.height - panel.height - configDialog.height - panel.distance
                 }
             }
-            duration: units.shortDuration * 3
+            duration: units.shortDuration
         }
     }
 //END Animations
diff --git a/desktoppackage/contents/explorer/WidgetExplorer.qml b/desktoppackage/contents/explorer/WidgetExplorer.qml
index 1b531dc6f..0c5c6be26 100644
--- a/desktoppackage/contents/explorer/WidgetExplorer.qml
+++ b/desktoppackage/contents/explorer/WidgetExplorer.qml
@@ -306,8 +306,7 @@ Item {
                     properties: "x"
                     from: -list.width
                     to: 0
-                    duration: units.shortDuration * 3
-
+                    duration: units.shortDuration
                 }
             }
 
@@ -316,7 +315,7 @@ Item {
                 NumberAnimation {
                     properties: "x"
                     to: list.width
-                    duration: units.shortDuration * 3
+                    duration: units.shortDuration
                 }
             }
 
@@ -329,7 +328,7 @@ Item {
             displaced: Transition {
                 NumberAnimation {
                     properties: "y"
-                    duration: units.shortDuration * 3
+                    duration: units.shortDuration
                 }
             }
         }
diff --git a/toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml b/toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
index e8055ec1e..3549a077d 100644
--- a/toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
+++ b/toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
@@ -54,14 +54,14 @@ Item {
     }
     Behavior on rotation {
         NumberAnimation {
-            duration: units.shortDuration * 3;
+            duration: units.shortDuration;
             easing.type: Easing.InOutExpo;
         }
         enabled: visible
     }
     Behavior on x {
         NumberAnimation {
-            duration: units.shortDuration * 3;
+            duration: units.shortDuration;
             easing.type: Easing.InOutExpo;
         }
         enabled: visible
@@ -69,7 +69,7 @@ Item {
     }
     Behavior on y {
         NumberAnimation {
-            duration: units.shortDuration * 3;
+            duration: units.shortDuration;
             easing.type: Easing.InOutExpo;
         }
         enabled: visible
-- 
2.25.1

Places

File 0001-Stop-multiplying-duration-values.patch of Package plasma5-desktop

Places