File hg-mpatch-fix09.patch of Package mercurial

Overview Repositories Revisions Requests Users Attributes Meta

File hg-mpatch-fix09.patch of Package mercurial (Revision 33bb7a8b56801c95e68e2568ffbb811e)

Currently displaying revision 33bb7a8b56801c95e68e2568ffbb811e , Show latest

# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1525141498 14400
# Node ID 9c5ced5276d6e7d54f7c3dadf5247b7ee98ec79c
# Parent  59837a16896da36d26e795881f4ba4454cb8ae41
mpatch: avoid integer overflow in combine() (SEC)

All the callers of this function can handle a NULL return, so that
appears to be the "safe" way to report an error.

diff -r 59837a16896d -r 9c5ced5276d6 mercurial/mpatch.c
--- a/mercurial/mpatch.c	Mon Apr 30 22:23:06 2018 -0400
+++ b/mercurial/mpatch.c	Mon Apr 30 22:24:58 2018 -0400
@@ -247,8 +247,18 @@
 
 			/* insert new hunk */
 			ct = c->tail;
-			ct->start = bh->start - offset;
-			ct->end = bh->end - post;
+			ct->start = bh->start;
+			ct->end = bh->end;
+			if (!safesub(offset, &(ct->start)) ||
+			    !safesub(post, &(ct->end))) {
+				/* It was already possible to exit
+				 * this function with a return value
+				 * of NULL before the safesub()s were
+				 * added, so this should be fine. */
+				mpatch_lfree(c);
+				c = NULL;
+				goto done;
+			}
 			ct->len = bh->len;
 			ct->data = bh->data;
 			c->tail++;
@@ -259,7 +269,7 @@
 		memcpy(c->tail, a->head, sizeof(struct mpatch_frag) * lsize(a));
 		c->tail += lsize(a);
 	}
-
+done:
 	mpatch_lfree(a);
 	mpatch_lfree(b);
 	return c;

Places

File hg-mpatch-fix09.patch of Package mercurial (Revision 33bb7a8b56801c95e68e2568ffbb811e)

Places