File check-for-self-provides.diff of Package rpmlint

Overview Repositories Revisions Requests Users Attributes Meta

File check-for-self-provides.diff of Package rpmlint (Revision 8b8461139cf1e2768ca3af91a0633e93)

Currently displaying revision 8b8461139cf1e2768ca3af91a0633e93 , Show latest

From: Ludwig Nussel <ludwig.nussel@suse.de>
Date: Fri, 10 Apr 2015 14:54:18 +0200
Subject: [PATCH] check for self provides

---
 TagsCheck.py | 6 ++++++
 1 file changed, 6 insertions(+)

Index: rpmlint-rpmlint-1.10/TagsCheck.py
===================================================================
--- rpmlint-rpmlint-1.10.orig/TagsCheck.py
+++ rpmlint-rpmlint-1.10/TagsCheck.py
@@ -891,6 +891,8 @@ class TagsCheck(AbstractCheck.AbstractCh
         for p in pkg.provides():
             value = Pkg.formatRequire(*p)
             self._unexpanded_macros(pkg, 'Provides %s' % (value,), value)
+            if p[0] == pkg.name and not p[1]:
+                printError(pkg, 'unversioned-explicit-self-provides', p[0])
 
         for c in pkg.conflicts():
             value = Pkg.formatRequire(*c)
@@ -1215,6 +1217,10 @@ objects should thus not be depended on a
 in the containing package.  Get rid of the provides if appropriate, for example
 by filtering it out during build.  Note that in some cases this may require
 disabling rpmbuild's internal dependency generator.''',
+
+'unversioned-explicit-self-provides',
+'''This package provides it's own name explicitely, which might break
+upgrade path. self-provides are autogenerated. Remove the provide.''',
 )
 
 for i in ("obsoletes", "conflicts", "provides", "recommends", "suggests",

Places

File check-for-self-provides.diff of Package rpmlint (Revision 8b8461139cf1e2768ca3af91a0633e93)

Places