File 1eae52b9-rpc-fix-double-unref.patch of Package libvirt.29527

Overview Repositories Revisions Requests Users Attributes Meta

File 1eae52b9-rpc-fix-double-unref.patch of Package libvirt.29527

commit 1eae52b9f1f2c0232d14e0effa47e8e6e5cce28d
Author: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date:   Thu Jul 9 10:59:33 2020 +0300

rpc: don't unref service ref on socket behalf twice
    
    Second unref was added in [1]. We don't need it actually as
    we pass free callback to virNetSocketAddIOCallback thus
    when we call virNetSocketRemoveIOCallback the extra ref for
    callback will be dropped without extra efforts.
    
    [1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets
    
    Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Index: libvirt-6.0.0/src/rpc/virnetserverservice.c
===================================================================
--- libvirt-6.0.0.orig/src/rpc/virnetserverservice.c
+++ libvirt-6.0.0/src/rpc/virnetserverservice.c
@@ -453,6 +453,5 @@ void virNetServerServiceClose(virNetServ
     for (i = 0; i < svc->nsocks; i++) {
         virNetSocketRemoveIOCallback(svc->socks[i]);
         virNetSocketClose(svc->socks[i]);
-        virObjectUnref(svc);
     }
 }

Places

File 1eae52b9-rpc-fix-double-unref.patch of Package libvirt.29527

Places