File poppler-CVE-2020-36024.patch of Package poppler-qt5

Overview Repositories Revisions Requests Users Attributes Meta

File poppler-CVE-2020-36024.patch of Package poppler-qt5 (Revision f9469c02575d96eac42034a793e5e0d6)

Currently displaying revision f9469c02575d96eac42034a793e5e0d6 , Show latest

From 3cc28b66132e66ed2dfe13a9a285ac41ac7267d5 Mon Sep 17 00:00:00 2001
From: Albert Astals Cid <aacid@kde.org>
Date: Wed, 23 Dec 2020 23:27:02 +0100
Subject: [PATCH] FoFiType1C: Fix crashes with broken files

---
 fofi/FoFiType1C.cc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: poppler-0.79.0/fofi/FoFiType1C.cc
===================================================================
--- poppler-0.79.0.orig/fofi/FoFiType1C.cc
+++ poppler-0.79.0/fofi/FoFiType1C.cc
@@ -198,7 +198,6 @@ void FoFiType1C::convertToType1(const ch
   Type1CIndexVal val;
   GooString *buf;
   char buf2[256];
-  const char **enc;
   bool ok;
   int i;
 
@@ -310,9 +309,9 @@ void FoFiType1C::convertToType1(const ch
     (*outputFunc)(outputStream, "256 array\n", 10);
     (*outputFunc)(outputStream,
 		  "0 1 255 {1 index exch /.notdef put} for\n", 40);
-    enc = newEncoding ? newEncoding : (const char **)encoding;
+    const char **enc = newEncoding ? newEncoding : (const char **)encoding;
     for (i = 0; i < 256; ++i) {
-      if (enc[i]) {
+      if (enc && enc[i]) {
 	buf = GooString::format("dup {0:d} /{1:s} put\n", i, enc[i]);
 	(*outputFunc)(outputStream, buf->c_str(), buf->getLength());
 	delete buf;
@@ -2018,7 +2017,7 @@ bool FoFiType1C::parse() {
       readPrivateDict(0, 0, &privateDicts[0]);
     } else {
       getIndex(topDict.fdArrayOffset, &fdIdx, &parsedOk);
-      if (!parsedOk) {
+      if (!parsedOk || fdIdx.len <= 0) {
 	return false;
       }
       nFDs = fdIdx.len;

Places

File poppler-CVE-2020-36024.patch of Package poppler-qt5 (Revision f9469c02575d96eac42034a793e5e0d6)

Places