File 0154-qcow2-Avoid-duplication-in-setting-.patch of Package qemu.20749

Overview Repositories Revisions Requests Users Attributes Meta

File 0154-qcow2-Avoid-duplication-in-setting-.patch of Package qemu.20749

From: Leonid Bloch <lbloch@janustech.com>
Date: Wed, 26 Sep 2018 19:04:42 +0300
Subject: qcow2: Avoid duplication in setting the refcount cache size

Include-If: %if 0%{?suse_version} == 1315

The refcount cache size does not need to be set to its minimum value in
read_cache_sizes(), as it is set to at least its minimum value in
qcow2_update_options_prepare().

Signed-off-by: Leonid Bloch <lbloch@janustech.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 657ada52abb85140e56949f522ecec527b256450)
[LM: BSC#1139926]
Signed-off-by: Lin Ma <lma@suse.com>
---
 block/qcow2.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 313b7dea45ae487cdea0f6cad056..5b337b749d2e776edd0cf4c0535e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -794,10 +794,9 @@ static void read_cache_sizes(BlockDriverState *bs, QemuOpts *opts,
                                  (uint64_t)DEFAULT_L2_CACHE_CLUSTERS
                                  * s->cluster_size);
         }
-        if (!refcount_cache_size_set) {
-            *refcount_cache_size = min_refcount_cache;
-        }
     }
+    /* l2_cache_size and refcount_cache_size are ensured to have at least
+     * their minimum values in qcow2_update_options_prepare() */
 }
 
 typedef struct Qcow2ReopenState {

Places

File 0154-qcow2-Avoid-duplication-in-setting-.patch of Package qemu.20749

Places