File pacemaker#3332-0001-Low-tools-Fix-memory-leak-i... of Package pacemaker

Overview Repositories Revisions Requests Users Attributes Meta

File pacemaker#3332-0001-Low-tools-Fix-memory-leak-in-crm_mon-with-HTML-outpu.patch of Package pacemaker (Revision 62c55229c1ad7b329c8df61bca2b23dd)

Currently displaying revision 62c55229c1ad7b329c8df61bca2b23dd , Show latest

From b8b531520b526f3d7c17cee4ac53d06e84ef6977 Mon Sep 17 00:00:00 2001
From: Reid Wahl <nrwahl@protonmail.com>
Date: Tue, 23 Jan 2024 00:01:43 -0800
Subject: [PATCH] Low: tools: Fix memory leak in crm_mon with HTML output

pcmk__itoa() allocates memory, which needs to be freed.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
---
 tools/crm_mon.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Index: pacemaker-2.1.7+20231219.0f7f88312/tools/crm_mon.c
===================================================================
--- pacemaker-2.1.7+20231219.0f7f88312.orig/tools/crm_mon.c
+++ pacemaker-2.1.7+20231219.0f7f88312/tools/crm_mon.c
@@ -1674,10 +1674,16 @@ main(int argc, char **argv)
         show_opts |= pcmk_show_inactive_rscs | pcmk_show_timing;
     }
 
-    if ((output_format == mon_output_html || output_format == mon_output_cgi) &&
-        out->dest != stdout) {
-        pcmk__html_add_header("meta", "http-equiv", "refresh", "content",
-                              pcmk__itoa(options.reconnect_ms / 1000), NULL);
+    if ((output_format == mon_output_html || output_format == mon_output_cgi)
+        && (out->dest != stdout)) {
+
+        char *content = pcmk__itoa(options.reconnect_ms / 1000);
+
+        pcmk__html_add_header("meta",
+                              "http-equiv", "refresh",
+                              "content", content,
+                              NULL);
+        free(content);
     }
 
 #ifdef PCMK__COMPAT_2_0

Places

File pacemaker#3332-0001-Low-tools-Fix-memory-leak-in-crm_mon-with-HTML-outpu.patch of Package pacemaker (Revision 62c55229c1ad7b329c8df61bca2b23dd)

Places